[jira] [Commented] (HIVE-16693) beeline "source" command freezes if you have a comment in it?

2017-05-20 Thread Carter Shanklin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018515#comment-16018515
 ] 

Carter Shanklin commented on HIVE-16693:


Looks good

> beeline "source" command freezes if you have a comment in it?
> -
>
> Key: HIVE-16693
> URL: https://issues.apache.org/jira/browse/HIVE-16693
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Affects Versions: 3.0.0
>Reporter: Carter Shanklin
>Assignee: Ferdinand Xu
> Attachments: HIVE-16693.patch
>
>
> As far as I'm observing in my environment, which is HDP 2.6.1, version 
> identified as 2.1.0.2.6.1.0-69 rc65de77a7cab18faf09a1f8e54c5ad5c44af8957
> Call this file temp.sql:
> {code}
> -- comment
> select 1;
> {code}
> Then in beeline run:
> {code}
> source temp.sql;
> {code}
> When I do this beeline freezes and must be killed.
> The jstacks indicate a tight loop in 
> org.apache.hive.beeline.Commands.sourceFileInternal:
>  main,org.apache.hive.beeline.Commands.sourceFileInternal(877)
>  main,org.apache.hive.beeline.Commands.sourceFile(860)
>  main,org.apache.hive.beeline.Commands.executeInternal(933)
>  main,org.apache.hive.beeline.Commands.execute(1161)
>  main,org.apache.hive.beeline.Commands.sql(1076)
>  main,org.apache.hive.beeline.BeeLine.dispatch(1145)
> There's never any other active thread.
> Looking at 
> https://github.com/apache/hive/blob/455ffdd9125bdfe73b2c7f7ddebaeff138b77f53/beeline/src/java/org/apache/hive/beeline/Commands.java#L896
> Don't you need to read the next line before you continue?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16693) beeline "source" command freezes if you have a comment in it?

2017-05-19 Thread Xuefu Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018210#comment-16018210
 ] 

Xuefu Zhang commented on HIVE-16693:


+1

> beeline "source" command freezes if you have a comment in it?
> -
>
> Key: HIVE-16693
> URL: https://issues.apache.org/jira/browse/HIVE-16693
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Affects Versions: 3.0.0
>Reporter: Carter Shanklin
>Assignee: Ferdinand Xu
> Attachments: HIVE-16693.patch
>
>
> As far as I'm observing in my environment, which is HDP 2.6.1, version 
> identified as 2.1.0.2.6.1.0-69 rc65de77a7cab18faf09a1f8e54c5ad5c44af8957
> Call this file temp.sql:
> {code}
> -- comment
> select 1;
> {code}
> Then in beeline run:
> {code}
> source temp.sql;
> {code}
> When I do this beeline freezes and must be killed.
> The jstacks indicate a tight loop in 
> org.apache.hive.beeline.Commands.sourceFileInternal:
>  main,org.apache.hive.beeline.Commands.sourceFileInternal(877)
>  main,org.apache.hive.beeline.Commands.sourceFile(860)
>  main,org.apache.hive.beeline.Commands.executeInternal(933)
>  main,org.apache.hive.beeline.Commands.execute(1161)
>  main,org.apache.hive.beeline.Commands.sql(1076)
>  main,org.apache.hive.beeline.BeeLine.dispatch(1145)
> There's never any other active thread.
> Looking at 
> https://github.com/apache/hive/blob/455ffdd9125bdfe73b2c7f7ddebaeff138b77f53/beeline/src/java/org/apache/hive/beeline/Commands.java#L896
> Don't you need to read the next line before you continue?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16693) beeline "source" command freezes if you have a comment in it?

2017-05-19 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017231#comment-16017231
 ] 

Hive QA commented on HIVE-16693:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12868906/HIVE-16693.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10739 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union36] (batchId=83)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_1]
 (batchId=147)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_3] 
(batchId=97)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3] 
(batchId=97)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query24] 
(batchId=231)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5346/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5346/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5346/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12868906 - PreCommit-HIVE-Build

> beeline "source" command freezes if you have a comment in it?
> -
>
> Key: HIVE-16693
> URL: https://issues.apache.org/jira/browse/HIVE-16693
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Affects Versions: 3.0.0
>Reporter: Carter Shanklin
>Assignee: Ferdinand Xu
> Attachments: HIVE-16693.patch
>
>
> As far as I'm observing in my environment, which is HDP 2.6.1, version 
> identified as 2.1.0.2.6.1.0-69 rc65de77a7cab18faf09a1f8e54c5ad5c44af8957
> Call this file temp.sql:
> {code}
> -- comment
> select 1;
> {code}
> Then in beeline run:
> {code}
> source temp.sql;
> {code}
> When I do this beeline freezes and must be killed.
> The jstacks indicate a tight loop in 
> org.apache.hive.beeline.Commands.sourceFileInternal:
>  main,org.apache.hive.beeline.Commands.sourceFileInternal(877)
>  main,org.apache.hive.beeline.Commands.sourceFile(860)
>  main,org.apache.hive.beeline.Commands.executeInternal(933)
>  main,org.apache.hive.beeline.Commands.execute(1161)
>  main,org.apache.hive.beeline.Commands.sql(1076)
>  main,org.apache.hive.beeline.BeeLine.dispatch(1145)
> There's never any other active thread.
> Looking at 
> https://github.com/apache/hive/blob/455ffdd9125bdfe73b2c7f7ddebaeff138b77f53/beeline/src/java/org/apache/hive/beeline/Commands.java#L896
> Don't you need to read the next line before you continue?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-16693) beeline "source" command freezes if you have a comment in it?

2017-05-19 Thread Ferdinand Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-16693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017112#comment-16017112
 ] 

Ferdinand Xu commented on HIVE-16693:
-

[~cartershanklin] [~xuefuz], could you help me review it? Thanks!

> beeline "source" command freezes if you have a comment in it?
> -
>
> Key: HIVE-16693
> URL: https://issues.apache.org/jira/browse/HIVE-16693
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Affects Versions: 3.0.0
>Reporter: Carter Shanklin
>Assignee: Ferdinand Xu
> Attachments: HIVE-16693.patch
>
>
> As far as I'm observing in my environment, which is HDP 2.6.1, version 
> identified as 2.1.0.2.6.1.0-69 rc65de77a7cab18faf09a1f8e54c5ad5c44af8957
> Call this file temp.sql:
> {code}
> -- comment
> select 1;
> {code}
> Then in beeline run:
> {code}
> source temp.sql;
> {code}
> When I do this beeline freezes and must be killed.
> The jstacks indicate a tight loop in 
> org.apache.hive.beeline.Commands.sourceFileInternal:
>  main,org.apache.hive.beeline.Commands.sourceFileInternal(877)
>  main,org.apache.hive.beeline.Commands.sourceFile(860)
>  main,org.apache.hive.beeline.Commands.executeInternal(933)
>  main,org.apache.hive.beeline.Commands.execute(1161)
>  main,org.apache.hive.beeline.Commands.sql(1076)
>  main,org.apache.hive.beeline.BeeLine.dispatch(1145)
> There's never any other active thread.
> Looking at 
> https://github.com/apache/hive/blob/455ffdd9125bdfe73b2c7f7ddebaeff138b77f53/beeline/src/java/org/apache/hive/beeline/Commands.java#L896
> Don't you need to read the next line before you continue?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)