[jira] [Commented] (HIVE-17260) Typo: exception has been created and lost in the ThriftJDBCBinarySerDe

2017-08-07 Thread Oleg Danilov (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-17260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116546#comment-16116546
 ] 

Oleg Danilov commented on HIVE-17260:
-

[~pvary], correct. These failures are not related to the patch.


> Typo: exception has been created and lost in the ThriftJDBCBinarySerDe
> --
>
> Key: HIVE-17260
> URL: https://issues.apache.org/jira/browse/HIVE-17260
> Project: Hive
>  Issue Type: Bug
>Reporter: Oleg Danilov
>Priority: Minor
> Attachments: HIVE-17260.patch
>
>
> Line 100:
> {code:java}
> } catch (Exception e) {
>   new SerDeException(e);
> }
> {code}
> Seems like it should be thrown there :-)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17260) Typo: exception has been created and lost in the ThriftJDBCBinarySerDe

2017-08-07 Thread Peter Vary (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-17260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116457#comment-16116457
 ] 

Peter Vary commented on HIVE-17260:
---

[~olegd]: Am I right, that the failures are not related?

Thanks,
Peter

> Typo: exception has been created and lost in the ThriftJDBCBinarySerDe
> --
>
> Key: HIVE-17260
> URL: https://issues.apache.org/jira/browse/HIVE-17260
> Project: Hive
>  Issue Type: Bug
>Reporter: Oleg Danilov
>Priority: Minor
> Attachments: HIVE-17260.patch
>
>
> Line 100:
> {code:java}
> } catch (Exception e) {
>   new SerDeException(e);
> }
> {code}
> Seems like it should be thrown there :-)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17260) Typo: exception has been created and lost in the ThriftJDBCBinarySerDe

2017-08-07 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-17260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116415#comment-16116415
 ] 

Hive QA commented on HIVE-17260:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12880616/HIVE-17260.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10992 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[llap_uncompressed] 
(batchId=56)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_vectorized_dynamic_partition_pruning]
 (batchId=168)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3] 
(batchId=99)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] 
(batchId=234)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] 
(batchId=234)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema
 (batchId=179)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema
 (batchId=179)
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation 
(batchId=179)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6278/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6278/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6278/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12880616 - PreCommit-HIVE-Build

> Typo: exception has been created and lost in the ThriftJDBCBinarySerDe
> --
>
> Key: HIVE-17260
> URL: https://issues.apache.org/jira/browse/HIVE-17260
> Project: Hive
>  Issue Type: Bug
>Reporter: Oleg Danilov
>Priority: Minor
> Attachments: HIVE-17260.patch
>
>
> Line 100:
> {code:java}
> } catch (Exception e) {
>   new SerDeException(e);
> }
> {code}
> Seems like it should be thrown there :-)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17260) Typo: exception has been created and lost in the ThriftJDBCBinarySerDe

2017-08-07 Thread Peter Vary (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-17260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116269#comment-16116269
 ] 

Peter Vary commented on HIVE-17260:
---

Could you please provide a patch in the formal method: 
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-ContributingYourWork,
 so the pre-commit tests will be triggered?

Otherwise +1, pending pre-commit tests.

Thanks for the catch,
Peter

> Typo: exception has been created and lost in the ThriftJDBCBinarySerDe
> --
>
> Key: HIVE-17260
> URL: https://issues.apache.org/jira/browse/HIVE-17260
> Project: Hive
>  Issue Type: Bug
>Reporter: Oleg Danilov
>Priority: Minor
>
> Line 100:
> {code:java}
> } catch (Exception e) {
>   new SerDeException(e);
> }
> {code}
> Seems like it should be thrown there :-)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HIVE-17260) Typo: exception has been created and lost in the ThriftJDBCBinarySerDe

2017-08-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-17260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115947#comment-16115947
 ] 

ASF GitHub Bot commented on HIVE-17260:
---

GitHub user dosoft opened a pull request:

https://github.com/apache/hive/pull/224

HIVE-17260: Fixed typo (non-thrown exception)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dosoft/hive HIVE-17260

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #224


commit 5076224de84f98e363588a03295fdb1e93b1c893
Author: Oleg Danilov 
Date:   2017-08-06T21:57:10Z

HIVE-17260: Fixed typo (non-thrown exception)




> Typo: exception has been created and lost in the ThriftJDBCBinarySerDe
> --
>
> Key: HIVE-17260
> URL: https://issues.apache.org/jira/browse/HIVE-17260
> Project: Hive
>  Issue Type: Bug
>Reporter: Oleg Danilov
>Priority: Minor
>
> Line 100:
> {code:java}
> } catch (Exception e) {
>   new SerDeException(e);
> }
> {code}
> Seems like it should be thrown there :-)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)