[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379270#comment-16379270
]
Thejas M Nair commented on HIVE-17735:
--
[~aihuaxu]
Looks like this needs to be marked as resolved
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363054#comment-16363054
]
Aihua Xu commented on HIVE-17735:
-
Pushed to master. Thanks [~ychena] for reviewing.
>
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361695#comment-16361695
]
Yongzhi Chen commented on HIVE-17735:
-
The change looks good. +1
> ObjectStore.addNotificationEvent
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356106#comment-16356106
]
Yongzhi Chen commented on HIVE-17735:
-
By theory, it is. Just to double check, for our pattern to
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356054#comment-16356054
]
Alexander Kolbasov commented on HIVE-17735:
---
[~ychena] The lock is held till the end of
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356000#comment-16356000
]
Yongzhi Chen commented on HIVE-17735:
-
I am not clear about the change related to lockForUpdate.
If
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355338#comment-16355338
]
Hive QA commented on HIVE-17735:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355289#comment-16355289
]
Hive QA commented on HIVE-17735:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354427#comment-16354427
]
Aihua Xu commented on HIVE-17735:
-
Patch-2: fix one test failure. The others don't seem related.
>
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353529#comment-16353529
]
Hive QA commented on HIVE-17735:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353482#comment-16353482
]
Hive QA commented on HIVE-17735:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353099#comment-16353099
]
Aihua Xu commented on HIVE-17735:
-
patch-1: seems a couple of places are leaking the query object.
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195464#comment-16195464
]
Alexander Kolbasov commented on HIVE-17735:
---
[~anishek], [~spena] FYI
>
[
https://issues.apache.org/jira/browse/HIVE-17735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195463#comment-16195463
]
Alexander Kolbasov commented on HIVE-17735:
---
There is a second leak:
{code}
private void
14 matches
Mail list logo
