[jira] [Commented] (HIVE-17995) Run checkstyle on standalone-metastore module with proper configuration
[
https://issues.apache.org/jira/browse/HIVE-17995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255486#comment-16255486
]
Adam Szita commented on HIVE-17995:
---
Yetus will call {{checkstyle:checkstyle}} which doesn't fail the task itself.
Nevertheless we indeed want upgrade the checkstyle plugin version. Right now it
completely skips source files that contain a lambda, rendering the whole thing
pointless.
I've opened a jira for this: HIVE-18084
> Run checkstyle on standalone-metastore module with proper configuration
> ---
>
> Key: HIVE-17995
> URL: https://issues.apache.org/jira/browse/HIVE-17995
> Project: Hive
> Issue Type: Sub-task
>Reporter: Adam Szita
>Assignee: Adam Szita
> Fix For: 3.0.0
>
> Attachments: HIVE-17995.0.patch, HIVE-17995.1.patch
>
>
> Maven module standalone-metastore is obviously not connected to Hive root
> pom, therefore if someone (or an automated Yetus check) runs {{mvn
> checkstyle}} it will not consider Hive-specific checkstyle settings (e.g.
> validates row lengths against 80, not 100)
> We need to make sure standalone-metastore pom has the proper checkstyle
> configuration
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17995) Run checkstyle on standalone-metastore module with proper configuration
[
https://issues.apache.org/jira/browse/HIVE-17995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246612#comment-16246612
]
Hive QA commented on HIVE-17995:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12896848/HIVE-17995.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 11374 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dbtxnmgr_showlocks]
(batchId=77)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=62)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1]
(batchId=146)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=156)
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc]
(batchId=94)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=111)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=206)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=223)
org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery
(batchId=233)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7741/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7741/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7741/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12896848 - PreCommit-HIVE-Build
> Run checkstyle on standalone-metastore module with proper configuration
> ---
>
> Key: HIVE-17995
> URL: https://issues.apache.org/jira/browse/HIVE-17995
> Project: Hive
> Issue Type: Sub-task
>Reporter: Adam Szita
>Assignee: Adam Szita
> Attachments: HIVE-17995.0.patch, HIVE-17995.1.patch
>
>
> Maven module standalone-metastore is obviously not connected to Hive root
> pom, therefore if someone (or an automated Yetus check) runs {{mvn
> checkstyle}} it will not consider Hive-specific checkstyle settings (e.g.
> validates row lengths against 80, not 100)
> We need to make sure standalone-metastore pom has the proper checkstyle
> configuration
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17995) Run checkstyle on standalone-metastore module with proper configuration
[
https://issues.apache.org/jira/browse/HIVE-17995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245510#comment-16245510
]
Adam Szita commented on HIVE-17995:
---
[~alangates], I agree, it makes sense to copy the checkstyle config folder
anyway since at some point when we separate HMS out from under Hive it will
need it anyway.
Attached new patch with this change: [^HIVE-17995.1.patch]
> Run checkstyle on standalone-metastore module with proper configuration
> ---
>
> Key: HIVE-17995
> URL: https://issues.apache.org/jira/browse/HIVE-17995
> Project: Hive
> Issue Type: Sub-task
>Reporter: Adam Szita
>Assignee: Adam Szita
> Attachments: HIVE-17995.0.patch, HIVE-17995.1.patch
>
>
> Maven module standalone-metastore is obviously not connected to Hive root
> pom, therefore if someone (or an automated Yetus check) runs {{mvn
> checkstyle}} it will not consider Hive-specific checkstyle settings (e.g.
> validates row lengths against 80, not 100)
> We need to make sure standalone-metastore pom has the proper checkstyle
> configuration
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17995) Run checkstyle on standalone-metastore module with proper configuration
[
https://issues.apache.org/jira/browse/HIVE-17995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242694#comment-16242694
]
Hive QA commented on HIVE-17995:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12896414/HIVE-17995.0.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 11 failed/errored test(s), 11366 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=62)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook]
(batchId=12)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1]
(batchId=146)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=156)
org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc]
(batchId=94)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi]
(batchId=111)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14]
(batchId=243)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query23]
(batchId=243)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut
(batchId=206)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanQpChanges
(batchId=281)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=223)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7687/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7687/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7687/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 11 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12896414 - PreCommit-HIVE-Build
> Run checkstyle on standalone-metastore module with proper configuration
> ---
>
> Key: HIVE-17995
> URL: https://issues.apache.org/jira/browse/HIVE-17995
> Project: Hive
> Issue Type: Sub-task
>Reporter: Adam Szita
>Assignee: Adam Szita
> Attachments: HIVE-17995.0.patch
>
>
> Maven module standalone-metastore is obviously not connected to Hive root
> pom, therefore if someone (or an automated Yetus check) runs {{mvn
> checkstyle}} it will not consider Hive-specific checkstyle settings (e.g.
> validates row lengths against 80, not 100)
> We need to make sure standalone-metastore pom has the proper checkstyle
> configuration
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17995) Run checkstyle on standalone-metastore module with proper configuration
[
https://issues.apache.org/jira/browse/HIVE-17995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242474#comment-16242474
]
Alan Gates commented on HIVE-17995:
---
When running this from inside standalone-metastore it fails to find the
checkstyle.xml. Rather than try to reference the one in the Hive build I think
it makes more sense to copy it into standalone-metastore. Otherwise I think
you'll run into problems like you have now where it works from hive but not
from standalone-metastore or vice versa.
> Run checkstyle on standalone-metastore module with proper configuration
> ---
>
> Key: HIVE-17995
> URL: https://issues.apache.org/jira/browse/HIVE-17995
> Project: Hive
> Issue Type: Sub-task
>Reporter: Adam Szita
>Assignee: Adam Szita
> Attachments: HIVE-17995.0.patch
>
>
> Maven module standalone-metastore is obviously not connected to Hive root
> pom, therefore if someone (or an automated Yetus check) runs {{mvn
> checkstyle}} it will not consider Hive-specific checkstyle settings (e.g.
> validates row lengths against 80, not 100)
> We need to make sure standalone-metastore pom has the proper checkstyle
> configuration
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
