[jira] [Commented] (HIVE-18127) Do not strip '--' comments from shell commands issued from CliDriver
[ https://issues.apache.org/jira/browse/HIVE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281452#comment-16281452 ] Lefty Leverenz commented on HIVE-18127: --- Okay, thanks Andrew. > Do not strip '--' comments from shell commands issued from CliDriver > > > Key: HIVE-18127 > URL: https://issues.apache.org/jira/browse/HIVE-18127 > Project: Hive > Issue Type: Bug >Reporter: Andrew Sherman >Assignee: Andrew Sherman > Fix For: 3.0.0 > > Attachments: HIVE-18127.1.patch, HIVE-18127.2.patch > > > CLiDriver has the ability to run shell commands by prefixing them with '!". > This behavior is not widely used (there are only 3 examples in .q files). > Since HIVE-16935 started stripping comments starting with '\-\-', a shell > command containing '--' will not work correctly. > Fix this by using the unstripped command for shell commands. > Note that it would be a security hole for HS2 to allow execution of arbitrary > shell commands from a client command. > Add tests to nail down correct behavior with '--' comments: > * CliDriver should not strip strings starting with '--' in a shell command > (FIXED in this change). > * HiveCli should strip '--' comments. > * A Jdbc program should allow commands starting with "!" but these will fail > in the sql parser. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18127) Do not strip '--' comments from shell commands issued from CliDriver
[ https://issues.apache.org/jira/browse/HIVE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280411#comment-16280411 ] Andrew Sherman commented on HIVE-18127: --- Hi [~leftylev] thanks for checking, I don't think this needs to be documented in the wiki. It is a bug fix which makes the system behave as expected. > Do not strip '--' comments from shell commands issued from CliDriver > > > Key: HIVE-18127 > URL: https://issues.apache.org/jira/browse/HIVE-18127 > Project: Hive > Issue Type: Bug >Reporter: Andrew Sherman >Assignee: Andrew Sherman > Fix For: 3.0.0 > > Attachments: HIVE-18127.1.patch, HIVE-18127.2.patch > > > CLiDriver has the ability to run shell commands by prefixing them with '!". > This behavior is not widely used (there are only 3 examples in .q files). > Since HIVE-16935 started stripping comments starting with '\-\-', a shell > command containing '--' will not work correctly. > Fix this by using the unstripped command for shell commands. > Note that it would be a security hole for HS2 to allow execution of arbitrary > shell commands from a client command. > Add tests to nail down correct behavior with '--' comments: > * CliDriver should not strip strings starting with '--' in a shell command > (FIXED in this change). > * HiveCli should strip '--' comments. > * A Jdbc program should allow commands starting with "!" but these will fail > in the sql parser. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18127) Do not strip '--' comments from shell commands issued from CliDriver
[ https://issues.apache.org/jira/browse/HIVE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279798#comment-16279798 ] Lefty Leverenz commented on HIVE-18127: --- Does any of this need to be documented in the wiki? > Do not strip '--' comments from shell commands issued from CliDriver > > > Key: HIVE-18127 > URL: https://issues.apache.org/jira/browse/HIVE-18127 > Project: Hive > Issue Type: Bug >Reporter: Andrew Sherman >Assignee: Andrew Sherman > Fix For: 3.0.0 > > Attachments: HIVE-18127.1.patch, HIVE-18127.2.patch > > > CLiDriver has the ability to run shell commands by prefixing them with '!". > This behavior is not widely used (there are only 3 examples in .q files). > Since HIVE-16935 started stripping comments starting with '\-\-', a shell > command containing '--' will not work correctly. > Fix this by using the unstripped command for shell commands. > Note that it would be a security hole for HS2 to allow execution of arbitrary > shell commands from a client command. > Add tests to nail down correct behavior with '--' comments: > * CliDriver should not strip strings starting with '--' in a shell command > (FIXED in this change). > * HiveCli should strip '--' comments. > * A Jdbc program should allow commands starting with "!" but these will fail > in the sql parser. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18127) Do not strip '--' comments from shell commands issued from CliDriver
[ https://issues.apache.org/jira/browse/HIVE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275008#comment-16275008 ] Andrew Sherman commented on HIVE-18127: --- Thanks [~stakiar] > Do not strip '--' comments from shell commands issued from CliDriver > > > Key: HIVE-18127 > URL: https://issues.apache.org/jira/browse/HIVE-18127 > Project: Hive > Issue Type: Bug >Reporter: Andrew Sherman >Assignee: Andrew Sherman > Fix For: 3.0.0 > > Attachments: HIVE-18127.1.patch, HIVE-18127.2.patch > > > CLiDriver has the ability to run shell commands by prefixing them with '!". > This behavior is not widely used (there are only 3 examples in .q files). > Since HIVE-16935 started stripping comments starting with '\-\-', a shell > command containing '--' will not work correctly. > Fix this by using the unstripped command for shell commands. > Note that it would be a security hole for HS2 to allow execution of arbitrary > shell commands from a client command. > Add tests to nail down correct behavior with '--' comments: > * CliDriver should not strip strings starting with '--' in a shell command > (FIXED in this change). > * HiveCli should strip '--' comments. > * A Jdbc program should allow commands starting with "!" but these will fail > in the sql parser. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18127) Do not strip '--' comments from shell commands issued from CliDriver
[ https://issues.apache.org/jira/browse/HIVE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272049#comment-16272049 ] Sahil Takiar commented on HIVE-18127: - +1 > Do not strip '--' comments from shell commands issued from CliDriver > > > Key: HIVE-18127 > URL: https://issues.apache.org/jira/browse/HIVE-18127 > Project: Hive > Issue Type: Bug >Reporter: Andrew Sherman >Assignee: Andrew Sherman > Attachments: HIVE-18127.1.patch, HIVE-18127.2.patch > > > CLiDriver has the ability to run shell commands by prefixing them with '!". > This behavior is not widely used (there are only 3 examples in .q files). > Since HIVE-16935 started stripping comments starting with '\-\-', a shell > command containing '--' will not work correctly. > Fix this by using the unstripped command for shell commands. > Note that it would be a security hole for HS2 to allow execution of arbitrary > shell commands from a client command. > Add tests to nail down correct behavior with '--' comments: > * CliDriver should not strip strings starting with '--' in a shell command > (FIXED in this change). > * HiveCli should strip '--' comments. > * A Jdbc program should allow commands starting with "!" but these will fail > in the sql parser. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18127) Do not strip '--' comments from shell commands issued from CliDriver
[ https://issues.apache.org/jira/browse/HIVE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263657#comment-16263657 ] Andrew Sherman commented on HIVE-18127: --- Test failures are not caused by this change. [~stakiar] please review when you have time > Do not strip '--' comments from shell commands issued from CliDriver > > > Key: HIVE-18127 > URL: https://issues.apache.org/jira/browse/HIVE-18127 > Project: Hive > Issue Type: Bug >Reporter: Andrew Sherman >Assignee: Andrew Sherman > Attachments: HIVE-18127.1.patch, HIVE-18127.2.patch > > > CLiDriver has the ability to run shell commands by prefixing them with '!". > This behavior is not widely used (there are only 3 examples in .q files). > Since HIVE-16935 started stripping comments starting with '\-\-', a shell > command containing '--' will not work correctly. > Fix this by using the unstripped command for shell commands. > Note that it would be a security hole for HS2 to allow execution of arbitrary > shell commands from a client command. > Add tests to nail down correct behavior with '--' comments: > * CliDriver should not strip strings starting with '--' in a shell command > (FIXED in this change). > * HiveCli should strip '--' comments. > * A Jdbc program should allow commands starting with "!" but these will fail > in the sql parser. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18127) Do not strip '--' comments from shell commands issued from CliDriver
[ https://issues.apache.org/jira/browse/HIVE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263656#comment-16263656 ] Andrew Sherman commented on HIVE-18127: --- logged [HIVE-18136] for asflicense issue > Do not strip '--' comments from shell commands issued from CliDriver > > > Key: HIVE-18127 > URL: https://issues.apache.org/jira/browse/HIVE-18127 > Project: Hive > Issue Type: Bug >Reporter: Andrew Sherman >Assignee: Andrew Sherman > Attachments: HIVE-18127.1.patch, HIVE-18127.2.patch > > > CLiDriver has the ability to run shell commands by prefixing them with '!". > This behavior is not widely used (there are only 3 examples in .q files). > Since HIVE-16935 started stripping comments starting with '\-\-', a shell > command containing '--' will not work correctly. > Fix this by using the unstripped command for shell commands. > Note that it would be a security hole for HS2 to allow execution of arbitrary > shell commands from a client command. > Add tests to nail down correct behavior with '--' comments: > * CliDriver should not strip strings starting with '--' in a shell command > (FIXED in this change). > * HiveCli should strip '--' comments. > * A Jdbc program should allow commands starting with "!" but these will fail > in the sql parser. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18127) Do not strip '--' comments from shell commands issued from CliDriver
[
https://issues.apache.org/jira/browse/HIVE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263534#comment-16263534
]
Hive QA commented on HIVE-18127:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12898930/HIVE-18127.2.patch
{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 11413 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=154)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=162)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query39]
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=224)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=230)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=230)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=230)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7975/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7975/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7975/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12898930 - PreCommit-HIVE-Build
> Do not strip '--' comments from shell commands issued from CliDriver
>
>
> Key: HIVE-18127
> URL: https://issues.apache.org/jira/browse/HIVE-18127
> Project: Hive
> Issue Type: Bug
>Reporter: Andrew Sherman
>Assignee: Andrew Sherman
> Attachments: HIVE-18127.1.patch, HIVE-18127.2.patch
>
>
> CLiDriver has the ability to run shell commands by prefixing them with '!".
> This behavior is not widely used (there are only 3 examples in .q files).
> Since HIVE-16935 started stripping comments starting with '\-\-', a shell
> command containing '--' will not work correctly.
> Fix this by using the unstripped command for shell commands.
> Note that it would be a security hole for HS2 to allow execution of arbitrary
> shell commands from a client command.
> Add tests to nail down correct behavior with '--' comments:
> * CliDriver should not strip strings starting with '--' in a shell command
> (FIXED in this change).
> * HiveCli should strip '--' comments.
> * A Jdbc program should allow commands starting with "!" but these will fail
> in the sql parser.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18127) Do not strip '--' comments from shell commands issued from CliDriver
[
https://issues.apache.org/jira/browse/HIVE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263467#comment-16263467
]
Hive QA commented on HIVE-18127:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
10s{color} | {color:red} cli: The patch generated 1 new + 37 unchanged - 1
fixed = 38 total (was 38) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
12s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / a988c15 |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-7975/yetus/diff-checkstyle-cli.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-7975/yetus/patch-asflicense-problems.txt
|
| modules | C: beeline cli itests/hive-unit U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-7975/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Do not strip '--' comments from shell commands issued from CliDriver
>
>
> Key: HIVE-18127
> URL: https://issues.apache.org/jira/browse/HIVE-18127
> Project: Hive
> Issue Type: Bug
>Reporter: Andrew Sherman
>Assignee: Andrew Sherman
> Attachments: HIVE-18127.1.patch, HIVE-18127.2.patch
>
>
> CLiDriver has the ability to run shell commands by prefixing them with '!".
> This behavior is not widely used (there are only 3 examples in .q files).
> Since HIVE-16935 started stripping comments starting with '\-\-', a shell
> command containing '--' will not work correctly.
> Fix this by using the unstripped command for shell commands.
> Note that it would be a security hole for HS2 to allow execution of arbitrary
> shell commands from a client command.
> Add tests to nail down correct behavior with '--' comments:
> * CliDriver should not strip strings starting with '--' in a shell command
> (FIXED in this change).
> * HiveCli should strip '--' comments.
> * A Jdbc program should allow commands starting with "!" but these will fail
> in the sql parser.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18127) Do not strip '--' comments from shell commands issued from CliDriver
[
https://issues.apache.org/jira/browse/HIVE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261953#comment-16261953
]
Hive QA commented on HIVE-18127:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12898769/HIVE-18127.1.patch
{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 13 failed/errored test(s), 11413 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[add_jar_with_file_removed]
(batchId=67)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dbtxnmgr_showlocks]
(batchId=77)
org.apache.hadoop.hive.cli.TestCliDriverMethods.testThatCliDriverDoesNotStripComments
(batchId=182)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1]
(batchId=146)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=154)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=162)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan]
(batchId=165)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2]
(batchId=102)
org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query39]
(batchId=246)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=224)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=230)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=230)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=230)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7952/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7952/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7952/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 13 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12898769 - PreCommit-HIVE-Build
> Do not strip '--' comments from shell commands issued from CliDriver
>
>
> Key: HIVE-18127
> URL: https://issues.apache.org/jira/browse/HIVE-18127
> Project: Hive
> Issue Type: Bug
>Reporter: Andrew Sherman
>Assignee: Andrew Sherman
> Attachments: HIVE-18127.1.patch
>
>
> CLiDriver has the ability to run shell commands by prefixing them with '!".
> This behavior is not widely used (there are only 3 examples in .q files).
> Since HIVE-16935 started stripping comments starting with '\-\-', a shell
> command containing '--' will not work correctly.
> Fix this by using the unstripped command for shell commands.
> Note that it would be a security hole for HS2 to allow execution of arbitrary
> shell commands from a client command.
> Add tests to nail down correct behavior with '--' comments:
> * CliDriver should not strip strings starting with '--' in a shell command
> (FIXED in this change).
> * HiveCli should strip '--' comments.
> * A Jdbc program should allow commands starting with "!" but these will fail
> in the sql parser.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
