[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354309#comment-16354309
]
Vihang Karajgaonkar commented on HIVE-18347:
latest patch looks good to me +1
> Allow dynamic
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354253#comment-16354253
]
Szehon Ho commented on HIVE-18347:
--
[~vihangk1] do you want to have another review on my rebased patch ?
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353207#comment-16353207
]
Hive QA commented on HIVE-18347:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353160#comment-16353160
]
Hive QA commented on HIVE-18347:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352752#comment-16352752
]
Szehon Ho commented on HIVE-18347:
--
Thanks a lot. Also I guess HIVE-18449 conflicts with this, so
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350788#comment-16350788
]
Vihang Karajgaonkar commented on HIVE-18347:
Hi [~szehon] Yes you are right. HIVE-18449
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350780#comment-16350780
]
Szehon Ho commented on HIVE-18347:
--
Hi Vihang, thanks for the review! Sorry about the late response.
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341405#comment-16341405
]
Vihang Karajgaonkar commented on HIVE-18347:
Hi [~szehon] Thanks for the changes. I left some
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335975#comment-16335975
]
Hive QA commented on HIVE-18347:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334604#comment-16334604
]
Szehon Ho commented on HIVE-18347:
--
Thanks for the message, [~thejas]! Included a review request for a
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330884#comment-16330884
]
Thejas M Nair commented on HIVE-18347:
--
[~szehon] can you also please include a github pull request
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330882#comment-16330882
]
Thejas M Nair commented on HIVE-18347:
--
I think adding the support for hook and leaving the Consul
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330785#comment-16330785
]
Szehon Ho commented on HIVE-18347:
--
After reading the discussion on HIVE-18449, this looks like still a
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328727#comment-16328727
]
Szehon Ho commented on HIVE-18347:
--
Thanks for the response guys. What Vihang says makes sense, I am
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327541#comment-16327541
]
Alan Gates commented on HIVE-18347:
---
cc [~thejas], as he's done work in this area.
> Allow dynamic
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326606#comment-16326606
]
Vihang Karajgaonkar commented on HIVE-18347:
Hi [~szehon]
I like the idea of having a
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326348#comment-16326348
]
Szehon Ho commented on HIVE-18347:
--
[~alangates] [~vihangk1] any thoughts on whether this is a useful
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306497#comment-16306497
]
Hive QA commented on HIVE-18347:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306465#comment-16306465
]
Hive QA commented on HIVE-18347:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306443#comment-16306443
]
Hive QA commented on HIVE-18347:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306408#comment-16306408
]
Hive QA commented on HIVE-18347:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
21 matches
Mail list logo
