[jira] [Commented] (HIVE-18769) Vectorization: Disable vectorization of key-less outer joins

2018-02-22 Thread Matt McCline (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373852#comment-16373852
 ] 

Matt McCline commented on HIVE-18769:
-

[~gopalv] thank you for your code review.

> Vectorization: Disable vectorization of key-less outer joins
> 
>
> Key: HIVE-18769
> URL: https://issues.apache.org/jira/browse/HIVE-18769
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Matt McCline
>Priority: Major
> Attachments: HIVE-18769.01.patch, HIVE-18769.02.patch
>
>
> Left & Right outer joins without keys are valid in SQL and they have 
> different semantics from cross-products
> {code}
> create temporary table foo(x int) stored as orc;
> insert into foo values(1),(2);
> create temporary table bar(y int) stored as orc;
> select count(*) from bar right outer join foo; -- = 2
> select count(*) from bar, foo; -- = 0 
> {code}
> canSpecializeMapJoin should bail on these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18769) Vectorization: Disable vectorization of key-less outer joins

2018-02-22 Thread Matt McCline (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373853#comment-16373853
 ] 

Matt McCline commented on HIVE-18769:
-

Committed to master.

> Vectorization: Disable vectorization of key-less outer joins
> 
>
> Key: HIVE-18769
> URL: https://issues.apache.org/jira/browse/HIVE-18769
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Matt McCline
>Priority: Major
> Attachments: HIVE-18769.01.patch, HIVE-18769.02.patch
>
>
> Left & Right outer joins without keys are valid in SQL and they have 
> different semantics from cross-products
> {code}
> create temporary table foo(x int) stored as orc;
> insert into foo values(1),(2);
> create temporary table bar(y int) stored as orc;
> select count(*) from bar right outer join foo; -- = 2
> select count(*) from bar, foo; -- = 0 
> {code}
> canSpecializeMapJoin should bail on these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18769) Vectorization: Disable vectorization of key-less outer joins

2018-02-22 Thread Matt McCline (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373850#comment-16373850
 ] 

Matt McCline commented on HIVE-18769:
-

Lots of test failures – none, however, appear to be related to this fix.

> Vectorization: Disable vectorization of key-less outer joins
> 
>
> Key: HIVE-18769
> URL: https://issues.apache.org/jira/browse/HIVE-18769
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Matt McCline
>Priority: Major
> Attachments: HIVE-18769.01.patch, HIVE-18769.02.patch
>
>
> Left & Right outer joins without keys are valid in SQL and they have 
> different semantics from cross-products
> {code}
> create temporary table foo(x int) stored as orc;
> insert into foo values(1),(2);
> create temporary table bar(y int) stored as orc;
> select count(*) from bar right outer join foo; -- = 2
> select count(*) from bar, foo; -- = 0 
> {code}
> canSpecializeMapJoin should bail on these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18769) Vectorization: Disable vectorization of key-less outer joins

2018-02-22 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373824#comment-16373824
 ] 

Hive QA commented on HIVE-18769:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12911589/HIVE-18769.02.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 84 failed/errored test(s), 13409 tests 
executed
*Failed tests:*
{noformat}
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=93)

[jira] [Commented] (HIVE-18769) Vectorization: Disable vectorization of key-less outer joins

2018-02-22 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373782#comment-16373782
 ] 

Hive QA commented on HIVE-18769:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
 5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git 
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
17s{color} | {color:red} The patch generated 49 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 58s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-9320/dev-support/hive-personality.sh
 |
| git revision | master / 7a8f105 |
| Default Java | 1.8.0_111 |
| whitespace | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-9320/yetus/whitespace-eol.txt 
|
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-9320/yetus/patch-asflicense-problems.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-9320/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Vectorization: Disable vectorization of key-less outer joins
> 
>
> Key: HIVE-18769
> URL: https://issues.apache.org/jira/browse/HIVE-18769
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Matt McCline
>Priority: Major
> Attachments: HIVE-18769.01.patch, HIVE-18769.02.patch
>
>
> Left & Right outer joins without keys are valid in SQL and they have 
> different semantics from cross-products
> {code}
> create temporary table foo(x int) stored as orc;
> insert into foo values(1),(2);
> create temporary table bar(y int) stored as orc;
> select count(*) from bar right outer join foo; -- = 2
> select count(*) from bar, foo; -- = 0 
> {code}
> canSpecializeMapJoin should bail on these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18769) Vectorization: Disable vectorization of key-less outer joins

2018-02-22 Thread Gopal V (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373467#comment-16373467
 ] 

Gopal V commented on HIVE-18769:


+1 tests pending

> Vectorization: Disable vectorization of key-less outer joins
> 
>
> Key: HIVE-18769
> URL: https://issues.apache.org/jira/browse/HIVE-18769
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Matt McCline
>Priority: Major
> Attachments: HIVE-18769.01.patch, HIVE-18769.02.patch
>
>
> Left & Right outer joins without keys are valid in SQL and they have 
> different semantics from cross-products
> {code}
> create temporary table foo(x int) stored as orc;
> insert into foo values(1),(2);
> create temporary table bar(y int) stored as orc;
> select count(*) from bar right outer join foo; -- = 2
> select count(*) from bar, foo; -- = 0 
> {code}
> canSpecializeMapJoin should bail on these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18769) Vectorization: Disable vectorization of key-less outer joins

2018-02-22 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372989#comment-16372989
 ] 

Hive QA commented on HIVE-18769:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12911513/HIVE-18769.01.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 51 failed/errored test(s), 12992 tests 
executed
*Failed tests:*
{noformat}
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=93)

[jira] [Commented] (HIVE-18769) Vectorization: Disable vectorization of key-less outer joins

2018-02-22 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372905#comment-16372905
 ] 

Hive QA commented on HIVE-18769:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
50s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git 
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
15s{color} | {color:red} The patch generated 49 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 55s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-9311/dev-support/hive-personality.sh
 |
| git revision | master / ec2378f |
| Default Java | 1.8.0_111 |
| whitespace | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-9311/yetus/whitespace-eol.txt 
|
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-9311/yetus/patch-asflicense-problems.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-9311/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Vectorization: Disable vectorization of key-less outer joins
> 
>
> Key: HIVE-18769
> URL: https://issues.apache.org/jira/browse/HIVE-18769
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Matt McCline
>Priority: Major
> Attachments: HIVE-18769.01.patch
>
>
> Left & Right outer joins without keys are valid in SQL and they have 
> different semantics from cross-products
> {code}
> create temporary table foo(x int) stored as orc;
> insert into foo values(1),(2);
> create temporary table bar(y int) stored as orc;
> select count(*) from bar right outer join foo; -- = 2
> select count(*) from bar, foo; -- = 0 
> {code}
> canSpecializeMapJoin should bail on these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18769) Vectorization: Disable vectorization of key-less outer joins

2018-02-22 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372873#comment-16372873
 ] 

Hive QA commented on HIVE-18769:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12911513/HIVE-18769.01.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 56 failed/errored test(s), 13407 tests 
executed
*Failed tests:*
{noformat}
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=94)

[jira] [Commented] (HIVE-18769) Vectorization: Disable vectorization of key-less outer joins

2018-02-22 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372815#comment-16372815
 ] 

Hive QA commented on HIVE-18769:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
 5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git 
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
20s{color} | {color:red} The patch generated 49 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m  0s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-9310/dev-support/hive-personality.sh
 |
| git revision | master / ec2378f |
| Default Java | 1.8.0_111 |
| whitespace | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-9310/yetus/whitespace-eol.txt 
|
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-9310/yetus/patch-asflicense-problems.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-9310/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Vectorization: Disable vectorization of key-less outer joins
> 
>
> Key: HIVE-18769
> URL: https://issues.apache.org/jira/browse/HIVE-18769
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Matt McCline
>Priority: Major
> Attachments: HIVE-18769.01.patch
>
>
> Left & Right outer joins without keys are valid in SQL and they have 
> different semantics from cross-products
> {code}
> create temporary table foo(x int) stored as orc;
> insert into foo values(1),(2);
> create temporary table bar(y int) stored as orc;
> select count(*) from bar right outer join foo; -- = 2
> select count(*) from bar, foo; -- = 0 
> {code}
> canSpecializeMapJoin should bail on these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-18769) Vectorization: Disable vectorization of key-less outer joins

2018-02-21 Thread Matt McCline (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372514#comment-16372514
 ] 

Matt McCline commented on HIVE-18769:
-

[~gopalv] thank you for figuring this problem out.

> Vectorization: Disable vectorization of key-less outer joins
> 
>
> Key: HIVE-18769
> URL: https://issues.apache.org/jira/browse/HIVE-18769
> Project: Hive
>  Issue Type: Bug
>  Components: Vectorization
>Affects Versions: 3.0.0
>Reporter: Gopal V
>Assignee: Gopal V
>Priority: Major
>
> Left & Right outer joins without keys are valid in SQL and they have 
> different semantics from cross-products
> {code}
> create temporary table foo(x int) stored as orc;
> insert into foo values(1),(2);
> create temporary table bar(y int) stored as orc;
> select count(*) from bar right outer join foo; -- = 2
> select count(*) from bar, foo; -- = 0 
> {code}
> canSpecializeMapJoin should bail on these cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)