[jira] [Commented] (HIVE-18832) Support change management for trashing data files from ACID tables.
[ https://issues.apache.org/jira/browse/HIVE-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394922#comment-16394922 ] anishek commented on HIVE-18832: Thanks for review [~sankarh] > Support change management for trashing data files from ACID tables. > --- > > Key: HIVE-18832 > URL: https://issues.apache.org/jira/browse/HIVE-18832 > Project: Hive > Issue Type: Sub-task > Components: HiveServer2 >Reporter: anishek >Assignee: anishek >Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-18832.0.patch, HIVE-18832.1.patch, > HIVE-18832.2.patch > > > Currently, cleaner process and DDL drop operations deletes the data files. > So, scope to support change management in source warehouse for ACID table > operations is given below. > 1. Cleaner process deletes older files after compaction, aborted files etc. > Need to be archived to cmroot path. > 2. DDL operations such as Drop table, partition already archive the deleted > files. Need to extend it for ACID tables too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18832) Support change management for trashing data files from ACID tables.
[ https://issues.apache.org/jira/browse/HIVE-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394849#comment-16394849 ] anishek commented on HIVE-18832: added the patch with a file name change and adding license header. > Support change management for trashing data files from ACID tables. > --- > > Key: HIVE-18832 > URL: https://issues.apache.org/jira/browse/HIVE-18832 > Project: Hive > Issue Type: Sub-task > Components: HiveServer2 >Reporter: anishek >Assignee: anishek >Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-18832.0.patch, HIVE-18832.1.patch, > HIVE-18832.2.patch > > > Currently, cleaner process and DDL drop operations deletes the data files. > So, scope to support change management in source warehouse for ACID table > operations is given below. > 1. Cleaner process deletes older files after compaction, aborted files etc. > Need to be archived to cmroot path. > 2. DDL operations such as Drop table, partition already archive the deleted > files. Need to extend it for ACID tables too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18832) Support change management for trashing data files from ACID tables.
[ https://issues.apache.org/jira/browse/HIVE-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394847#comment-16394847 ] anishek commented on HIVE-18832: * org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_sortmerge_join_2] : runs fine on local machine * org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_varchar1] : runs fine on local machine * org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[bucketizedhiveinputformat]: runs fine on local machine other failures are from older builds. > Support change management for trashing data files from ACID tables. > --- > > Key: HIVE-18832 > URL: https://issues.apache.org/jira/browse/HIVE-18832 > Project: Hive > Issue Type: Sub-task > Components: HiveServer2 >Reporter: anishek >Assignee: anishek >Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-18832.0.patch, HIVE-18832.1.patch > > > Currently, cleaner process and DDL drop operations deletes the data files. > So, scope to support change management in source warehouse for ACID table > operations is given below. > 1. Cleaner process deletes older files after compaction, aborted files etc. > Need to be archived to cmroot path. > 2. DDL operations such as Drop table, partition already archive the deleted > files. Need to extend it for ACID tables too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18832) Support change management for trashing data files from ACID tables.
[ https://issues.apache.org/jira/browse/HIVE-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394810#comment-16394810 ] Sankar Hariappan commented on HIVE-18832: - +1 > Support change management for trashing data files from ACID tables. > --- > > Key: HIVE-18832 > URL: https://issues.apache.org/jira/browse/HIVE-18832 > Project: Hive > Issue Type: Sub-task > Components: HiveServer2 >Reporter: anishek >Assignee: anishek >Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-18832.0.patch, HIVE-18832.1.patch > > > Currently, cleaner process and DDL drop operations deletes the data files. > So, scope to support change management in source warehouse for ACID table > operations is given below. > 1. Cleaner process deletes older files after compaction, aborted files etc. > Need to be archived to cmroot path. > 2. DDL operations such as Drop table, partition already archive the deleted > files. Need to extend it for ACID tables too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18832) Support change management for trashing data files from ACID tables.
[ https://issues.apache.org/jira/browse/HIVE-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393872#comment-16393872 ] Hive QA commented on HIVE-18832: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12913725/HIVE-18832.1.patch {color:green}SUCCESS:{color} +1 due to 7 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 23 failed/errored test(s), 12958 tests executed *Failed tests:* {noformat} TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=94)
[jira] [Commented] (HIVE-18832) Support change management for trashing data files from ACID tables.
[ https://issues.apache.org/jira/browse/HIVE-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393810#comment-16393810 ] Hive QA commented on HIVE-18832: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 34s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 9s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 50s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 36s{color} | {color:red} hive-unit in the patch failed. {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 49s{color} | {color:red} ql in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 32s{color} | {color:red} hive-unit in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 32s{color} | {color:red} hive-unit in the patch failed. {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 15s{color} | {color:red} itests/hive-unit: The patch generated 4 new + 2 unchanged - 0 fixed = 6 total (was 2) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} ql: The patch generated 0 new + 85 unchanged - 4 fixed = 85 total (was 89) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 16s{color} | {color:red} standalone-metastore: The patch generated 3 new + 32 unchanged - 18 fixed = 35 total (was 50) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 55s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 13s{color} | {color:red} The patch generated 49 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 19m 37s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-9579/dev-support/hive-personality.sh | | git revision | master / b362de3 | | Default Java | 1.8.0_111 | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-9579/yetus/patch-mvninstall-itests_hive-unit.txt | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-9579/yetus/patch-mvninstall-ql.txt | | compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-9579/yetus/patch-compile-itests_hive-unit.txt | | javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-9579/yetus/patch-compile-itests_hive-unit.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-9579/yetus/diff-checkstyle-itests_hive-unit.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-9579/yetus/diff-checkstyle-standalone-metastore.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-9579/yetus/patch-asflicense-problems.txt | | modules | C: itests/hive-unit ql standalone-metastore U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-9579/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Support change management for trashing data files from ACID tables. > --- > > Key:
[jira] [Commented] (HIVE-18832) Support change management for trashing data files from ACID tables.
[ https://issues.apache.org/jira/browse/HIVE-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392492#comment-16392492 ] anishek commented on HIVE-18832: not sure why PR is not getting logged here https://github.com/apache/hive/pull/318 > Support change management for trashing data files from ACID tables. > --- > > Key: HIVE-18832 > URL: https://issues.apache.org/jira/browse/HIVE-18832 > Project: Hive > Issue Type: Sub-task > Components: HiveServer2 >Reporter: anishek >Assignee: anishek >Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-18832.0.patch, HIVE-18832.1.patch > > > Currently, cleaner process and DDL drop operations deletes the data files. > So, scope to support change management in source warehouse for ACID table > operations is given below. > 1. Cleaner process deletes older files after compaction, aborted files etc. > Need to be archived to cmroot path. > 2. DDL operations such as Drop table, partition already archive the deleted > files. Need to extend it for ACID tables too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18832) Support change management for trashing data files from ACID tables.
[ https://issues.apache.org/jira/browse/HIVE-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387407#comment-16387407 ] Hive QA commented on HIVE-18832: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12913147/HIVE-18832.0.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 100 failed/errored test(s), 13477 tests executed *Failed tests:* {noformat} TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=93)
[jira] [Commented] (HIVE-18832) Support change management for trashing data files from ACID tables.
[ https://issues.apache.org/jira/browse/HIVE-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387351#comment-16387351 ] Hive QA commented on HIVE-18832: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 37s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 19s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 32s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 35s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 47s{color} | {color:red} ql in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 14s{color} | {color:red} standalone-metastore: The patch generated 3 new + 32 unchanged - 18 fixed = 35 total (was 50) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 38s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 12s{color} | {color:red} The patch generated 49 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 17m 3s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-9503/dev-support/hive-personality.sh | | git revision | master / 8d88cfa | | Default Java | 1.8.0_111 | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-9503/yetus/patch-mvninstall-ql.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-9503/yetus/diff-checkstyle-standalone-metastore.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-9503/yetus/patch-asflicense-problems.txt | | modules | C: ql standalone-metastore U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-9503/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Support change management for trashing data files from ACID tables. > --- > > Key: HIVE-18832 > URL: https://issues.apache.org/jira/browse/HIVE-18832 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: anishek >Assignee: anishek >Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-18832.0.patch > > > Currently, cleaner process and DDL drop operations deletes the data files. > So, scope to support change management in source warehouse for ACID table > operations is given below. > 1. Cleaner process deletes older files after compaction, aborted files etc. > Need to be archived to cmroot path. > 2. DDL operations such as Drop table, partition already archive the deleted > files. Need to extend it for ACID tables too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)