[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[
https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490124#comment-16490124
]
Hive QA commented on HIVE-19588:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12924724/HIVE-19588.4.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14388 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11194/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11194/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11194/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12924724 - PreCommit-HIVE-Build
> Several invocation of file listing when creating
> VectorizedOrcAcidRowBatchReader
>
>
> Key: HIVE-19588
> URL: https://issues.apache.org/jira/browse/HIVE-19588
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Affects Versions: 3.1.0
>Reporter: Nita Dembla
>Assignee: Prasanth Jayachandran
>Priority: Major
> Attachments: HIVE-19588.1.patch, HIVE-19588.2.patch,
> HIVE-19588.3.patch, HIVE-19588.4.patch, Screen Shot 2018-05-16 at 2.23.25
> PM.png
>
>
> Looks like we are doing file listing several times when creating one instance
> of VectorizedOrcAcidRowBatchReader
> AcidUtils.parseBaseOrDeltaBucketFilename() does full file listing (when
> there are files with bucket_* prefix) just to get a single file out of a path
> to figure out if it has ACID schema (as part of HIVE-18190).
> There is full file listing where we populate
> 1) ColumnizedDeleteEventRegistry
> 2) SortMergedDeleteEventRegistry
> 3) Twice in computeOffsetAndBucket()
>
> Attaching profiles which [~gopalv] took while debugging.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[
https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490093#comment-16490093
]
Hive QA commented on HIVE-19588:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
44s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
40s{color} | {color:blue} llap-server in master has 86 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
57s{color} | {color:blue} ql in master has 2322 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
18s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} llap-server: The patch generated 0 new + 28
unchanged - 1 fixed = 28 total (was 29) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
40s{color} | {color:red} ql: The patch generated 18 new + 585 unchanged - 5
fixed = 603 total (was 590) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 18s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11194/dev-support/hive-personality.sh
|
| git revision | master / fc040d5 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11194/yetus/patch-mvninstall-llap-server.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11194/yetus/diff-checkstyle-ql.txt
|
| modules | C: llap-server ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11194/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Several invocation of file listing when creating
> VectorizedOrcAcidRowBatchReader
>
>
> Key: HIVE-19588
> URL: https://issues.apache.org/jira/browse/HIVE-19588
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Affects Versions: 3.1.0
>Reporter: Nita Dembla
>Assignee: Prasanth Jayachandran
>Priority: Major
> Attachments: HIVE-19588.1.patch, HIVE-19588.2.patch,
> HIVE-19588.3.patch, HIVE-19588.4.patch, Screen Shot 2018-05-16 at 2.23.25
> PM.png
>
>
> Looks like we are doing file listing several times when creating one instance
> of
[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[
https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486662#comment-16486662
]
Hive QA commented on HIVE-19588:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12924492/HIVE-19588.3.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14396 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver[parallel_orderby]
(batchId=94)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11147/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11147/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11147/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12924492 - PreCommit-HIVE-Build
> Several invocation of file listing when creating
> VectorizedOrcAcidRowBatchReader
>
>
> Key: HIVE-19588
> URL: https://issues.apache.org/jira/browse/HIVE-19588
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Affects Versions: 3.1.0
>Reporter: Nita Dembla
>Assignee: Prasanth Jayachandran
>Priority: Major
> Attachments: HIVE-19588.1.patch, HIVE-19588.2.patch,
> HIVE-19588.3.patch, Screen Shot 2018-05-16 at 2.23.25 PM.png
>
>
> Looks like we are doing file listing several times when creating one instance
> of VectorizedOrcAcidRowBatchReader
> AcidUtils.parseBaseOrDeltaBucketFilename() does full file listing (when
> there are files with bucket_* prefix) just to get a single file out of a path
> to figure out if it has ACID schema (as part of HIVE-18190).
> There is full file listing where we populate
> 1) ColumnizedDeleteEventRegistry
> 2) SortMergedDeleteEventRegistry
> 3) Twice in computeOffsetAndBucket()
>
> Attaching profiles which [~gopalv] took while debugging.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[
https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486647#comment-16486647
]
Hive QA commented on HIVE-19588:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
39s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
40s{color} | {color:blue} llap-server in master has 86 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
47s{color} | {color:blue} ql in master has 2322 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
19s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} llap-server: The patch generated 0 new + 28
unchanged - 1 fixed = 28 total (was 29) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} ql: The patch generated 18 new + 585 unchanged - 5
fixed = 603 total (was 590) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11147/dev-support/hive-personality.sh
|
| git revision | master / ed95ee9 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11147/yetus/patch-mvninstall-llap-server.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11147/yetus/diff-checkstyle-ql.txt
|
| modules | C: llap-server ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11147/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Several invocation of file listing when creating
> VectorizedOrcAcidRowBatchReader
>
>
> Key: HIVE-19588
> URL: https://issues.apache.org/jira/browse/HIVE-19588
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Affects Versions: 3.1.0
>Reporter: Nita Dembla
>Assignee: Prasanth Jayachandran
>Priority: Major
> Attachments: HIVE-19588.1.patch, HIVE-19588.2.patch,
> HIVE-19588.3.patch, Screen Shot 2018-05-16 at 2.23.25 PM.png
>
>
> Looks like we are doing file listing several times when creating one instance
> of VectorizedOrcAcidRowBatchReader
>
[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[
https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483481#comment-16483481
]
Hive QA commented on HIVE-19588:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12924051/HIVE-19588.2.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11122/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11122/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11122/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL
https://issues.apache.org/jira/secure/attachment/12924051/HIVE-19588.2.patch
was found in seen patch url's cache and a test was probably run already on it.
Aborting...
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12924051 - PreCommit-HIVE-Build
> Several invocation of file listing when creating
> VectorizedOrcAcidRowBatchReader
>
>
> Key: HIVE-19588
> URL: https://issues.apache.org/jira/browse/HIVE-19588
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Affects Versions: 3.1.0
>Reporter: Nita Dembla
>Assignee: Prasanth Jayachandran
>Priority: Major
> Attachments: HIVE-19588.1.patch, HIVE-19588.2.patch, Screen Shot
> 2018-05-16 at 2.23.25 PM.png
>
>
> Looks like we are doing file listing several times when creating one instance
> of VectorizedOrcAcidRowBatchReader
> AcidUtils.parseBaseOrDeltaBucketFilename() does full file listing (when
> there are files with bucket_* prefix) just to get a single file out of a path
> to figure out if it has ACID schema (as part of HIVE-18190).
> There is full file listing where we populate
> 1) ColumnizedDeleteEventRegistry
> 2) SortMergedDeleteEventRegistry
> 3) Twice in computeOffsetAndBucket()
>
> Attaching profiles which [~gopalv] took while debugging.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[ https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482782#comment-16482782 ] Prasanth Jayachandran commented on HIVE-19588: -- Ran into same /tmp cleanup issue. Will retry. > Several invocation of file listing when creating > VectorizedOrcAcidRowBatchReader > > > Key: HIVE-19588 > URL: https://issues.apache.org/jira/browse/HIVE-19588 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.1.0 >Reporter: Nita Dembla >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-19588.1.patch, HIVE-19588.2.patch, Screen Shot > 2018-05-16 at 2.23.25 PM.png > > > Looks like we are doing file listing several times when creating one instance > of VectorizedOrcAcidRowBatchReader > AcidUtils.parseBaseOrDeltaBucketFilename() does full file listing (when > there are files with bucket_* prefix) just to get a single file out of a path > to figure out if it has ACID schema (as part of HIVE-18190). > There is full file listing where we populate > 1) ColumnizedDeleteEventRegistry > 2) SortMergedDeleteEventRegistry > 3) Twice in computeOffsetAndBucket() > > Attaching profiles which [~gopalv] took while debugging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[
https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482321#comment-16482321
]
Hive QA commented on HIVE-19588:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12924051/HIVE-19588.2.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14388 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[localtimezone]
(batchId=55)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11101/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11101/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11101/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12924051 - PreCommit-HIVE-Build
> Several invocation of file listing when creating
> VectorizedOrcAcidRowBatchReader
>
>
> Key: HIVE-19588
> URL: https://issues.apache.org/jira/browse/HIVE-19588
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Affects Versions: 3.1.0
>Reporter: Nita Dembla
>Assignee: Prasanth Jayachandran
>Priority: Major
> Attachments: HIVE-19588.1.patch, HIVE-19588.2.patch, Screen Shot
> 2018-05-16 at 2.23.25 PM.png
>
>
> Looks like we are doing file listing several times when creating one instance
> of VectorizedOrcAcidRowBatchReader
> AcidUtils.parseBaseOrDeltaBucketFilename() does full file listing (when
> there are files with bucket_* prefix) just to get a single file out of a path
> to figure out if it has ACID schema (as part of HIVE-18190).
> There is full file listing where we populate
> 1) ColumnizedDeleteEventRegistry
> 2) SortMergedDeleteEventRegistry
> 3) Twice in computeOffsetAndBucket()
>
> Attaching profiles which [~gopalv] took while debugging.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[
https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482301#comment-16482301
]
Hive QA commented on HIVE-19588:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
39s{color} | {color:blue} llap-server in master has 86 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
56s{color} | {color:blue} ql in master has 2320 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
18s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} llap-server: The patch generated 0 new + 28
unchanged - 1 fixed = 28 total (was 29) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
41s{color} | {color:red} ql: The patch generated 18 new + 584 unchanged - 5
fixed = 602 total (was 589) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11101/dev-support/hive-personality.sh
|
| git revision | master / cb2d710 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11101/yetus/patch-mvninstall-llap-server.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11101/yetus/diff-checkstyle-ql.txt
|
| modules | C: llap-server ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11101/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Several invocation of file listing when creating
> VectorizedOrcAcidRowBatchReader
>
>
> Key: HIVE-19588
> URL: https://issues.apache.org/jira/browse/HIVE-19588
> Project: Hive
> Issue Type: Bug
> Components: Transactions
>Affects Versions: 3.1.0
>Reporter: Nita Dembla
>Assignee: Prasanth Jayachandran
>Priority: Major
> Attachments: HIVE-19588.1.patch, HIVE-19588.2.patch, Screen Shot
> 2018-05-16 at 2.23.25 PM.png
>
>
> Looks like we are doing file listing several times when creating one instance
> of VectorizedOrcAcidRowBatchReader
>
[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[ https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481017#comment-16481017 ] Eugene Koifman commented on HIVE-19588: --- +1 > Several invocation of file listing when creating > VectorizedOrcAcidRowBatchReader > > > Key: HIVE-19588 > URL: https://issues.apache.org/jira/browse/HIVE-19588 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.1.0 >Reporter: Nita Dembla >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-19588.1.patch, HIVE-19588.2.patch, Screen Shot > 2018-05-16 at 2.23.25 PM.png > > > Looks like we are doing file listing several times when creating one instance > of VectorizedOrcAcidRowBatchReader > AcidUtils.parseBaseOrDeltaBucketFilename() does full file listing (when > there are files with bucket_* prefix) just to get a single file out of a path > to figure out if it has ACID schema (as part of HIVE-18190). > There is full file listing where we populate > 1) ColumnizedDeleteEventRegistry > 2) SortMergedDeleteEventRegistry > 3) Twice in computeOffsetAndBucket() > > Attaching profiles which [~gopalv] took while debugging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[ https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480196#comment-16480196 ] Prasanth Jayachandran commented on HIVE-19588: -- Per [~gopalv] the perf slowness comes from inner loop creation of VectorizedOrcAcidRowBatchReader for LLAP. Removed it in .2 patch. [~ekoifman] can you review this diff [https://reviews.apache.org/r/67197/diff/1-2/] ? > Several invocation of file listing when creating > VectorizedOrcAcidRowBatchReader > > > Key: HIVE-19588 > URL: https://issues.apache.org/jira/browse/HIVE-19588 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.1.0 >Reporter: Nita Dembla >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-19588.1.patch, HIVE-19588.2.patch, Screen Shot > 2018-05-16 at 2.23.25 PM.png > > > Looks like we are doing file listing several times when creating one instance > of VectorizedOrcAcidRowBatchReader > AcidUtils.parseBaseOrDeltaBucketFilename() does full file listing (when > there are files with bucket_* prefix) just to get a single file out of a path > to figure out if it has ACID schema (as part of HIVE-18190). > There is full file listing where we populate > 1) ColumnizedDeleteEventRegistry > 2) SortMergedDeleteEventRegistry > 3) Twice in computeOffsetAndBucket() > > Attaching profiles which [~gopalv] took while debugging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[ https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479818#comment-16479818 ] Eugene Koifman commented on HIVE-19588: --- +1 pending tests > Several invocation of file listing when creating > VectorizedOrcAcidRowBatchReader > > > Key: HIVE-19588 > URL: https://issues.apache.org/jira/browse/HIVE-19588 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.1.0 >Reporter: Nita Dembla >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-19588.1.patch, Screen Shot 2018-05-16 at 2.23.25 > PM.png > > > Looks like we are doing file listing several times when creating one instance > of VectorizedOrcAcidRowBatchReader > AcidUtils.parseBaseOrDeltaBucketFilename() does full file listing (when > there are files with bucket_* prefix) just to get a single file out of a path > to figure out if it has ACID schema (as part of HIVE-18190). > There is full file listing where we populate > 1) ColumnizedDeleteEventRegistry > 2) SortMergedDeleteEventRegistry > 3) Twice in computeOffsetAndBucket() > > Attaching profiles which [~gopalv] took while debugging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19588) Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader
[ https://issues.apache.org/jira/browse/HIVE-19588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479793#comment-16479793 ] Prasanth Jayachandran commented on HIVE-19588: -- [~ekoifman] can you please review the patch? > Several invocation of file listing when creating > VectorizedOrcAcidRowBatchReader > > > Key: HIVE-19588 > URL: https://issues.apache.org/jira/browse/HIVE-19588 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.1.0 >Reporter: Nita Dembla >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-19588.1.patch, Screen Shot 2018-05-16 at 2.23.25 > PM.png > > > Looks like we are doing file listing several times when creating one instance > of VectorizedOrcAcidRowBatchReader > AcidUtils.parseBaseOrDeltaBucketFilename() does full file listing (when > there are files with bucket_* prefix) just to get a single file out of a path > to figure out if it has ACID schema (as part of HIVE-18190). > There is full file listing where we populate > 1) ColumnizedDeleteEventRegistry > 2) SortMergedDeleteEventRegistry > 3) Twice in computeOffsetAndBucket() > > Attaching profiles which [~gopalv] took while debugging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
