[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707458#comment-16707458
]
Sahil Takiar commented on HIVE-20440:
-
+1 LGTM
> Create better cache eviction policy for
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700472#comment-16700472
]
Antal Sinkovits commented on HIVE-20440:
Finally a green one.
[~stakiar] I've added the e2e test.
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700398#comment-16700398
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700364#comment-16700364
]
Hive QA commented on HIVE-20440:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699791#comment-16699791
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699755#comment-16699755
]
Hive QA commented on HIVE-20440:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699448#comment-16699448
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699399#comment-16699399
]
Hive QA commented on HIVE-20440:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699154#comment-16699154
]
Antal Sinkovits commented on HIVE-20440:
Test failiure not related. Uploading again.
> Create
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699140#comment-16699140
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699043#comment-16699043
]
Hive QA commented on HIVE-20440:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698914#comment-16698914
]
Antal Sinkovits commented on HIVE-20440:
Rebase
> Create better cache eviction policy for
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682409#comment-16682409
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682389#comment-16682389
]
Hive QA commented on HIVE-20440:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679108#comment-16679108
]
Hive QA commented on HIVE-20440:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679129#comment-16679129
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677586#comment-16677586
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677548#comment-16677548
]
Hive QA commented on HIVE-20440:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647797#comment-16647797
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645237#comment-16645237
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645175#comment-16645175
]
Hive QA commented on HIVE-20440:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644900#comment-16644900
]
Antal Sinkovits commented on HIVE-20440:
Test failures are not related. I will re-upload the
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644844#comment-16644844
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622695#comment-16622695
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622694#comment-16622694
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622644#comment-16622644
]
Hive QA commented on HIVE-20440:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613811#comment-16613811
]
Sahil Takiar commented on HIVE-20440:
-
Makes sense to me.
> Create better cache eviction policy for
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613731#comment-16613731
]
Antal Sinkovits commented on HIVE-20440:
Yes, this is a good idea.
But I would not bother with
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609496#comment-16609496
]
Sahil Takiar commented on HIVE-20440:
-
Then it might be better to have a two level cache. The first
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609444#comment-16609444
]
Antal Sinkovits commented on HIVE-20440:
(1) I think because of the soft values, the GC decides
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606353#comment-16606353
]
Sahil Takiar commented on HIVE-20440:
-
Few high level comments:
(1) The Guava cache only performs
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589745#comment-16589745
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589365#comment-16589365
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589329#comment-16589329
]
Hive QA commented on HIVE-20440:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589267#comment-16589267
]
Hive QA commented on HIVE-20440:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589233#comment-16589233
]
Hive QA commented on HIVE-20440:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
36 matches
Mail list logo
