[jira] [Commented] (HIVE-20952) Cleaning VectorizationContext.java
[ https://issues.apache.org/jira/browse/HIVE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694753#comment-16694753 ] ASF GitHub Bot commented on HIVE-20952: --- Github user b-slim closed the pull request at: https://github.com/apache/hive/pull/490 > Cleaning VectorizationContext.java > -- > > Key: HIVE-20952 > URL: https://issues.apache.org/jira/browse/HIVE-20952 > Project: Hive > Issue Type: Improvement >Reporter: slim bouguerra >Assignee: slim bouguerra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-20952.patch, HIVE-20952.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20952) Cleaning VectorizationContext.java
[
https://issues.apache.org/jira/browse/HIVE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694274#comment-16694274
]
Hive QA commented on HIVE-20952:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12948969/HIVE-20952.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15544 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/15021/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15021/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15021/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12948969 - PreCommit-HIVE-Build
> Cleaning VectorizationContext.java
> --
>
> Key: HIVE-20952
> URL: https://issues.apache.org/jira/browse/HIVE-20952
> Project: Hive
> Issue Type: Improvement
>Reporter: slim bouguerra
>Assignee: slim bouguerra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-20952.patch, HIVE-20952.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20952) Cleaning VectorizationContext.java
[
https://issues.apache.org/jira/browse/HIVE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694236#comment-16694236
]
Hive QA commented on HIVE-20952:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
41s{color} | {color:blue} ql in master has 2317 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
38s{color} | {color:red} ql: The patch generated 7 new + 367 unchanged - 11
fixed = 374 total (was 378) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
45s{color} | {color:green} ql generated 0 new + 2311 unchanged - 6 fixed = 2311
total (was 2317) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 7s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-15021/dev-support/hive-personality.sh
|
| git revision | master / c392bcc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-15021/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-15021/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Cleaning VectorizationContext.java
> --
>
> Key: HIVE-20952
> URL: https://issues.apache.org/jira/browse/HIVE-20952
> Project: Hive
> Issue Type: Improvement
>Reporter: slim bouguerra
>Assignee: slim bouguerra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-20952.patch, HIVE-20952.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20952) Cleaning VectorizationContext.java
[ https://issues.apache.org/jira/browse/HIVE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694147#comment-16694147 ] Ashutosh Chauhan commented on HIVE-20952: - +1 pending tests > Cleaning VectorizationContext.java > -- > > Key: HIVE-20952 > URL: https://issues.apache.org/jira/browse/HIVE-20952 > Project: Hive > Issue Type: Improvement >Reporter: slim bouguerra >Assignee: slim bouguerra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-20952.patch, HIVE-20952.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20952) Cleaning VectorizationContext.java
[
https://issues.apache.org/jira/browse/HIVE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694109#comment-16694109
]
Hive QA commented on HIVE-20952:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12948930/HIVE-20952.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15544 tests
executed
*Failed tests:*
{noformat}
TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=197)
[druidmini_masking.q,druidmini_joins.q,druid_timestamptz.q]
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/15018/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15018/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15018/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12948930 - PreCommit-HIVE-Build
> Cleaning VectorizationContext.java
> --
>
> Key: HIVE-20952
> URL: https://issues.apache.org/jira/browse/HIVE-20952
> Project: Hive
> Issue Type: Improvement
>Reporter: slim bouguerra
>Assignee: slim bouguerra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-20952.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20952) Cleaning VectorizationContext.java
[
https://issues.apache.org/jira/browse/HIVE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693978#comment-16693978
]
Hive QA commented on HIVE-20952:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
47s{color} | {color:blue} ql in master has 2317 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
38s{color} | {color:red} ql: The patch generated 7 new + 367 unchanged - 11
fixed = 374 total (was 378) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
56s{color} | {color:green} ql generated 0 new + 2311 unchanged - 6 fixed = 2311
total (was 2317) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-15018/dev-support/hive-personality.sh
|
| git revision | master / c392bcc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-15018/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-15018/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Cleaning VectorizationContext.java
> --
>
> Key: HIVE-20952
> URL: https://issues.apache.org/jira/browse/HIVE-20952
> Project: Hive
> Issue Type: Improvement
>Reporter: slim bouguerra
>Assignee: slim bouguerra
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-20952.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20952) Cleaning VectorizationContext.java
[ https://issues.apache.org/jira/browse/HIVE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693918#comment-16693918 ] slim bouguerra commented on HIVE-20952: --- [~t3rmin4t0r] [~ashutoshc] [~teddy.choi] am going through some of the vectorize code, will take advantage of the holiday season and clean the code base. I promise no logic change :DÂ Will try to break as much i can the patches like that make review simple and easy to revert. > Cleaning VectorizationContext.java > -- > > Key: HIVE-20952 > URL: https://issues.apache.org/jira/browse/HIVE-20952 > Project: Hive > Issue Type: Improvement >Reporter: slim bouguerra >Assignee: slim bouguerra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-20952.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20952) Cleaning VectorizationContext.java
[ https://issues.apache.org/jira/browse/HIVE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693917#comment-16693917 ] ASF GitHub Bot commented on HIVE-20952: --- GitHub user b-slim opened a pull request: https://github.com/apache/hive/pull/490 [HIVE-20952] Cleaning VectorizationContext.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/b-slim/hive HIVE-20952 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hive/pull/490.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #490 commit cdd533dead7cdb6603ae9c8dff0b64aa23db6dab Author: Slim Bouguerra Date: 2018-11-20T23:52:27Z Cleaning VectorizationContext.java Change-Id: Icdcb407ed5c7f5175f54ed023fc2565338d9032c > Cleaning VectorizationContext.java > -- > > Key: HIVE-20952 > URL: https://issues.apache.org/jira/browse/HIVE-20952 > Project: Hive > Issue Type: Improvement >Reporter: slim bouguerra >Assignee: slim bouguerra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-20952.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
