[jira] [Commented] (HIVE-21126) Allow session level queries in LlapBaseInputFormat#getSplits() before actual get_splits() call
[ https://issues.apache.org/jira/browse/HIVE-21126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748402#comment-16748402 ] Teddy Choi commented on HIVE-21126: --- +1. Looks good to me. > Allow session level queries in LlapBaseInputFormat#getSplits() before actual > get_splits() call > -- > > Key: HIVE-21126 > URL: https://issues.apache.org/jira/browse/HIVE-21126 > Project: Hive > Issue Type: Improvement > Components: llap >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Shubham Chaurasia >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21126.1.patch, HIVE-21126.2.patch, > HIVE-21126.3.patch > > > Facilitate execution of session level queries before \{{select get_splits()}} > call. This will allow us to set params like \{{tez.grouping.split-count}} > which can be taken into consideration while splits calculation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21126) Allow session level queries in LlapBaseInputFormat#getSplits() before actual get_splits() call
[ https://issues.apache.org/jira/browse/HIVE-21126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743995#comment-16743995 ] Hive QA commented on HIVE-21126: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12955072/HIVE-21126.3.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15694 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15641/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15641/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15641/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12955072 - PreCommit-HIVE-Build > Allow session level queries in LlapBaseInputFormat#getSplits() before actual > get_splits() call > -- > > Key: HIVE-21126 > URL: https://issues.apache.org/jira/browse/HIVE-21126 > Project: Hive > Issue Type: Improvement > Components: llap >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Shubham Chaurasia >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21126.1.patch, HIVE-21126.2.patch, > HIVE-21126.3.patch > > > Facilitate execution of session level queries before \{{select get_splits()}} > call. This will allow us to set params like \{{tez.grouping.split-count}} > which can be taken into consideration while splits calculation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21126) Allow session level queries in LlapBaseInputFormat#getSplits() before actual get_splits() call
[ https://issues.apache.org/jira/browse/HIVE-21126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743940#comment-16743940 ] Hive QA commented on HIVE-21126: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 32s{color} | {color:red} llap-ext-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 10m 52s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:llap-ext-client | | | org.apache.hadoop.hive.llap.LlapBaseInputFormat.getSplits(JobConf, int) passes a nonconstant String to an execute or addBatch method on an SQL statement At LlapBaseInputFormat.java:String to an execute or addBatch method on an SQL statement At LlapBaseInputFormat.java:[line 279] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15641/dev-support/hive-personality.sh | | git revision | master / 1fff171 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15641/yetus/new-findbugs-llap-ext-client.html | | modules | C: llap-ext-client U: llap-ext-client | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15641/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Allow session level queries in LlapBaseInputFormat#getSplits() before actual > get_splits() call > -- > > Key: HIVE-21126 > URL: https://issues.apache.org/jira/browse/HIVE-21126 > Project: Hive > Issue Type: Improvement > Components: llap >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Shubham Chaurasia >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21126.1.patch, HIVE-21126.2.patch, > HIVE-21126.3.patch > > > Facilitate execution of session level queries before \{{select get_splits()}} > call. This will allow us to set params like \{{tez.grouping.split-count}} > which can be taken into consideration while splits calculation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21126) Allow session level queries in LlapBaseInputFormat#getSplits() before actual get_splits() call
[ https://issues.apache.org/jira/browse/HIVE-21126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743823#comment-16743823 ] Hive QA commented on HIVE-21126: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12955053/HIVE-21126.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15694 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_memcheck] (batchId=45) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15638/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15638/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15638/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12955053 - PreCommit-HIVE-Build > Allow session level queries in LlapBaseInputFormat#getSplits() before actual > get_splits() call > -- > > Key: HIVE-21126 > URL: https://issues.apache.org/jira/browse/HIVE-21126 > Project: Hive > Issue Type: Improvement > Components: llap >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Shubham Chaurasia >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21126.1.patch, HIVE-21126.2.patch > > > Facilitate execution of session level queries before \{{select get_splits()}} > call. This will allow us to set params like \{{tez.grouping.split-count}} > which can be taken into consideration while splits calculation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21126) Allow session level queries in LlapBaseInputFormat#getSplits() before actual get_splits() call
[ https://issues.apache.org/jira/browse/HIVE-21126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743779#comment-16743779 ] Hive QA commented on HIVE-21126: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 26s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 30s{color} | {color:red} llap-ext-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 11m 30s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:llap-ext-client | | | org.apache.hadoop.hive.llap.LlapBaseInputFormat.getSplits(JobConf, int) passes a nonconstant String to an execute or addBatch method on an SQL statement At LlapBaseInputFormat.java:String to an execute or addBatch method on an SQL statement At LlapBaseInputFormat.java:[line 279] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15638/dev-support/hive-personality.sh | | git revision | master / a3aa074 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15638/yetus/new-findbugs-llap-ext-client.html | | modules | C: llap-ext-client U: llap-ext-client | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15638/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Allow session level queries in LlapBaseInputFormat#getSplits() before actual > get_splits() call > -- > > Key: HIVE-21126 > URL: https://issues.apache.org/jira/browse/HIVE-21126 > Project: Hive > Issue Type: Improvement > Components: llap >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Shubham Chaurasia >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21126.1.patch, HIVE-21126.2.patch > > > Facilitate execution of session level queries before \{{select get_splits()}} > call. This will allow us to set params like \{{tez.grouping.split-count}} > which can be taken into consideration while splits calculation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21126) Allow session level queries in LlapBaseInputFormat#getSplits() before actual get_splits() call
[ https://issues.apache.org/jira/browse/HIVE-21126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743716#comment-16743716 ] Hive QA commented on HIVE-21126: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12955042/HIVE-21126.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15694 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_vectorized_dynamic_partition_pruning] (batchId=190) org.apache.hadoop.hive.metastore.TestPartitionManagement.testPartitionDiscoveryTransactionalTable (batchId=220) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15636/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15636/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15636/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12955042 - PreCommit-HIVE-Build > Allow session level queries in LlapBaseInputFormat#getSplits() before actual > get_splits() call > -- > > Key: HIVE-21126 > URL: https://issues.apache.org/jira/browse/HIVE-21126 > Project: Hive > Issue Type: Improvement > Components: llap >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Shubham Chaurasia >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21126.1.patch > > > Facilitate execution of session level queries before \{{select get_splits()}} > call. This will allow us to set params like \{{tez.grouping.split-count}} > which can be taken into consideration while splits calculation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21126) Allow session level queries in LlapBaseInputFormat#getSplits() before actual get_splits() call
[ https://issues.apache.org/jira/browse/HIVE-21126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743683#comment-16743683 ] Hive QA commented on HIVE-21126: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 22s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 32s{color} | {color:red} llap-ext-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 11m 0s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:llap-ext-client | | | org.apache.hadoop.hive.llap.LlapBaseInputFormat.getSplits(JobConf, int) passes a nonconstant String to an execute or addBatch method on an SQL statement At LlapBaseInputFormat.java:String to an execute or addBatch method on an SQL statement At LlapBaseInputFormat.java:[line 272] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15636/dev-support/hive-personality.sh | | git revision | master / a3aa074 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15636/yetus/new-findbugs-llap-ext-client.html | | modules | C: llap-ext-client U: llap-ext-client | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15636/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Allow session level queries in LlapBaseInputFormat#getSplits() before actual > get_splits() call > -- > > Key: HIVE-21126 > URL: https://issues.apache.org/jira/browse/HIVE-21126 > Project: Hive > Issue Type: Improvement > Components: llap >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Shubham Chaurasia >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21126.1.patch > > > Facilitate execution of session level queries before \{{select get_splits()}} > call. This will allow us to set params like \{{tez.grouping.split-count}} > which can be taken into consideration while splits calculation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21126) Allow session level queries in LlapBaseInputFormat#getSplits() before actual get_splits() call
[ https://issues.apache.org/jira/browse/HIVE-21126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743644#comment-16743644 ] ASF GitHub Bot commented on HIVE-21126: --- GitHub user ShubhamChaurasia opened a pull request: https://github.com/apache/hive/pull/515 HIVE-21126: Allow session level queries in LlapBaseInputFormat#getSplits Provides a way to pass queries to execute before get_splits() is executed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ShubhamChaurasia/hive HIVE-21126 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hive/pull/515.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #515 commit 4cf1bf4d95d6eec534c5ae4f56073faad3d12bd2 Author: ShubhamChaurasia Date: 2019-01-16T05:45:16Z HIVE-21126: Allow session level queries in LlapBaseInputFormat#getSplits() before actual get_splits() call > Allow session level queries in LlapBaseInputFormat#getSplits() before actual > get_splits() call > -- > > Key: HIVE-21126 > URL: https://issues.apache.org/jira/browse/HIVE-21126 > Project: Hive > Issue Type: Improvement > Components: llap >Affects Versions: 3.1.1 >Reporter: Shubham Chaurasia >Assignee: Shubham Chaurasia >Priority: Major > Labels: pull-request-available > > Facilitate execution of session level queries before \{{select get_splits()}} > call. This will allow us to set params like \{{tez.grouping.split-count}} > which can be taken into consideration while splits calculation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)