[jira] [Commented] (HIVE-21222) ACID: When there are no delete deltas skip finding min max keys
[ https://issues.apache.org/jira/browse/HIVE-21222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762394#comment-16762394 ] Eugene Koifman commented on HIVE-21222: --- failure not related > ACID: When there are no delete deltas skip finding min max keys > --- > > Key: HIVE-21222 > URL: https://issues.apache.org/jira/browse/HIVE-21222 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 4.0.0, 3.2.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-21222.1.patch, HIVE-21222.2.patch > > > We create an orc reader in VectorizedOrcAcidRowBatchReader.findMinMaxKeys > (which will read 16K footer) even for cases where delete deltas does not > exist. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21222) ACID: When there are no delete deltas skip finding min max keys
[ https://issues.apache.org/jira/browse/HIVE-21222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762386#comment-16762386 ] Hive QA commented on HIVE-21222: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12957841/HIVE-21222.2.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15777 tests executed *Failed tests:* {noformat} org.apache.hive.service.auth.TestLdapAuthenticationProviderImpl.testAuthenticateWithBindInCredentialFilePasses (batchId=232) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15980/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15980/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15980/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12957841 - PreCommit-HIVE-Build > ACID: When there are no delete deltas skip finding min max keys > --- > > Key: HIVE-21222 > URL: https://issues.apache.org/jira/browse/HIVE-21222 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 4.0.0, 3.2.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-21222.1.patch, HIVE-21222.2.patch > > > We create an orc reader in VectorizedOrcAcidRowBatchReader.findMinMaxKeys > (which will read 16K footer) even for cases where delete deltas does not > exist. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21222) ACID: When there are no delete deltas skip finding min max keys
[ https://issues.apache.org/jira/browse/HIVE-21222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762368#comment-16762368 ] Hive QA commented on HIVE-21222: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 55s{color} | {color:blue} ql in master has 2298 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 41s{color} | {color:red} ql: The patch generated 1 new + 278 unchanged - 0 fixed = 279 total (was 278) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 13s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 9s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15980/dev-support/hive-personality.sh | | git revision | master / 0e4d16b | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15980/yetus/diff-checkstyle-ql.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-15980/yetus/patch-asflicense-problems.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15980/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > ACID: When there are no delete deltas skip finding min max keys > --- > > Key: HIVE-21222 > URL: https://issues.apache.org/jira/browse/HIVE-21222 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 4.0.0, 3.2.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-21222.1.patch, HIVE-21222.2.patch > > > We create an orc reader in VectorizedOrcAcidRowBatchReader.findMinMaxKeys > (which will read 16K footer) even for cases where delete deltas does not > exist. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21222) ACID: When there are no delete deltas skip finding min max keys
[ https://issues.apache.org/jira/browse/HIVE-21222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762238#comment-16762238 ] Prasanth Jayachandran commented on HIVE-21222: -- fixes test failures. > ACID: When there are no delete deltas skip finding min max keys > --- > > Key: HIVE-21222 > URL: https://issues.apache.org/jira/browse/HIVE-21222 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 4.0.0, 3.2.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-21222.1.patch, HIVE-21222.2.patch > > > We create an orc reader in VectorizedOrcAcidRowBatchReader.findMinMaxKeys > (which will read 16K footer) even for cases where delete deltas does not > exist. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21222) ACID: When there are no delete deltas skip finding min max keys
[ https://issues.apache.org/jira/browse/HIVE-21222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761552#comment-16761552 ] Hive QA commented on HIVE-21222: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12957710/HIVE-21222.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 15729 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testFSCallsVectorizedOrcAcidRowBatchReader (batchId=300) org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventFilteringOn3 (batchId=300) org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testDeleteEventOriginalFilteringOn2 (batchId=300) org.apache.hadoop.hive.ql.io.orc.TestVectorizedOrcAcidRowBatchReader.testWithoutStatsDeleteEventFilteringOn3 (batchId=300) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15959/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15959/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15959/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12957710 - PreCommit-HIVE-Build > ACID: When there are no delete deltas skip finding min max keys > --- > > Key: HIVE-21222 > URL: https://issues.apache.org/jira/browse/HIVE-21222 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 4.0.0, 3.2.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-21222.1.patch > > > We create an orc reader in VectorizedOrcAcidRowBatchReader.findMinMaxKeys > (which will read 16K footer) even for cases where delete deltas does not > exist. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21222) ACID: When there are no delete deltas skip finding min max keys
[ https://issues.apache.org/jira/browse/HIVE-21222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761537#comment-16761537 ] Hive QA commented on HIVE-21222: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 35s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 33s{color} | {color:blue} ql in master has 2307 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 13s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 21m 53s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15959/dev-support/hive-personality.sh | | git revision | master / 313e49f | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-15959/yetus/patch-asflicense-problems.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15959/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > ACID: When there are no delete deltas skip finding min max keys > --- > > Key: HIVE-21222 > URL: https://issues.apache.org/jira/browse/HIVE-21222 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 4.0.0, 3.2.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-21222.1.patch > > > We create an orc reader in VectorizedOrcAcidRowBatchReader.findMinMaxKeys > (which will read 16K footer) even for cases where delete deltas does not > exist. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21222) ACID: When there are no delete deltas skip finding min max keys
[ https://issues.apache.org/jira/browse/HIVE-21222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761374#comment-16761374 ] Eugene Koifman commented on HIVE-21222: --- +1 > ACID: When there are no delete deltas skip finding min max keys > --- > > Key: HIVE-21222 > URL: https://issues.apache.org/jira/browse/HIVE-21222 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0, 3.2.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-21222.1.patch > > > We create an orc reader in VectorizedOrcAcidRowBatchReader.findMinMaxKeys > (which will read 16K footer) even for cases where delete deltas does not > exist. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21222) ACID: When there are no delete deltas skip finding min max keys
[ https://issues.apache.org/jira/browse/HIVE-21222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761322#comment-16761322 ] Prasanth Jayachandran commented on HIVE-21222: -- [~ekoifman] could you please review this small patch? > ACID: When there are no delete deltas skip finding min max keys > --- > > Key: HIVE-21222 > URL: https://issues.apache.org/jira/browse/HIVE-21222 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0, 3.2.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-21222.1.patch > > > We create an orc reader in VectorizedOrcAcidRowBatchReader.findMinMaxKeys > (which will read 16K footer) even for cases where delete deltas does not > exist. -- This message was sent by Atlassian JIRA (v7.6.3#76005)