[jira] [Commented] (HIVE-21460) ACID: Load data followed by a select * query results in incorrect results

2019-03-19 Thread Gopal V (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796350#comment-16796350
 ] 

Gopal V commented on HIVE-21460:


LGTM - +1 

(backport to 3.x branch too)

> ACID: Load data followed by a select * query results in incorrect results
> -
>
> Key: HIVE-21460
> URL: https://issues.apache.org/jira/browse/HIVE-21460
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 4.0.0, 3.1.1
>Reporter: Vaibhav Gumashta
>Assignee: Vaibhav Gumashta
>Priority: Blocker
> Attachments: HIVE-21460.1.patch
>
>
> This affects current master as well. Created an orc file such that it spans 
> multiple stripes and ran a simple select *, and got incorrect row counts 
> (when comparing with select count(*). The problem seems to be that after 
> split generation and creating min/max rowId for each row (note that since the 
> loaded file is not written by Hive ACID, it does not have ROW__ID in the 
> file; but the ROW__ID is applied on read by discovering min/max bounds which 
> are used for calculating ROW__ID.rowId for each row of a split), Hive is only 
> reading the last split.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21460) ACID: Load data followed by a select * query results in incorrect results

2019-03-19 Thread Victor Corral (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796113#comment-16796113
 ] 

Victor Corral commented on HIVE-21460:
--

http://mail-archives.apache.org/mod_mbox/infra-issues/201903.mbox/raw/.com]

> ACID: Load data followed by a select * query results in incorrect results
> -
>
> Key: HIVE-21460
> URL: https://issues.apache.org/jira/browse/HIVE-21460
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 4.0.0, 3.1.1
>Reporter: Vaibhav Gumashta
>Assignee: Vaibhav Gumashta
>Priority: Blocker
> Attachments: HIVE-21460.1.patch
>
>
> This affects current master as well. Created an orc file such that it spans 
> multiple stripes and ran a simple select *, and got incorrect row counts 
> (when comparing with select count(*). The problem seems to be that after 
> split generation and creating min/max rowId for each row (note that since the 
> loaded file is not written by Hive ACID, it does not have ROW__ID in the 
> file; but the ROW__ID is applied on read by discovering min/max bounds which 
> are used for calculating ROW__ID.rowId for each row of a split), Hive is only 
> reading the last split.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21460) ACID: Load data followed by a select * query results in incorrect results

2019-03-19 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796112#comment-16796112
 ] 

Hive QA commented on HIVE-21460:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12962943/HIVE-21460.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15833 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_groupby_reduce] 
(batchId=61)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[udaf_invalid_place]
 (batchId=99)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/16571/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16571/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16571/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12962943 - PreCommit-HIVE-Build

> ACID: Load data followed by a select * query results in incorrect results
> -
>
> Key: HIVE-21460
> URL: https://issues.apache.org/jira/browse/HIVE-21460
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 4.0.0, 3.1.1
>Reporter: Vaibhav Gumashta
>Assignee: Vaibhav Gumashta
>Priority: Blocker
> Attachments: HIVE-21460.1.patch
>
>
> This affects current master as well. Created an orc file such that it spans 
> multiple stripes and ran a simple select *, and got incorrect row counts 
> (when comparing with select count(*). The problem seems to be that after 
> split generation and creating min/max rowId for each row (note that since the 
> loaded file is not written by Hive ACID, it does not have ROW__ID in the 
> file; but the ROW__ID is applied on read by discovering min/max bounds which 
> are used for calculating ROW__ID.rowId for each row of a split), Hive is only 
> reading the last split.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21460) ACID: Load data followed by a select * query results in incorrect results

2019-03-19 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796069#comment-16796069
 ] 

Hive QA commented on HIVE-21460:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
15s{color} | {color:blue} ql in master has 2255 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 22s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16571/dev-support/hive-personality.sh
 |
| git revision | master / 36bd89d |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-16571/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> ACID: Load data followed by a select * query results in incorrect results
> -
>
> Key: HIVE-21460
> URL: https://issues.apache.org/jira/browse/HIVE-21460
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 4.0.0, 3.1.1
>Reporter: Vaibhav Gumashta
>Assignee: Vaibhav Gumashta
>Priority: Blocker
> Attachments: HIVE-21460.1.patch
>
>
> This affects current master as well. Created an orc file such that it spans 
> multiple stripes and ran a simple select *, and got incorrect row counts 
> (when comparing with select count(*). The problem seems to be that after 
> split generation and creating min/max rowId for each row (note that since the 
> loaded file is not written by Hive ACID, it does not have ROW__ID in the 
> file; but the ROW__ID is applied on read by discovering min/max bounds which 
> are used for calculating ROW__ID.rowId for each row of a split), Hive is only 
> reading the last split.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21460) ACID: Load data followed by a select * query results in incorrect results

2019-03-19 Thread Vaibhav Gumashta (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795827#comment-16795827
 ] 

Vaibhav Gumashta commented on HIVE-21460:
-

cc [~gopalv]

> ACID: Load data followed by a select * query results in incorrect results
> -
>
> Key: HIVE-21460
> URL: https://issues.apache.org/jira/browse/HIVE-21460
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 4.0.0, 3.1.1
>Reporter: Vaibhav Gumashta
>Assignee: Vaibhav Gumashta
>Priority: Blocker
> Attachments: HIVE-21460.1.patch
>
>
> This affects current master as well. Created an orc file such that it spans 
> multiple stripes and ran a simple select *, and got incorrect row counts 
> (when comparing with select count(*). The problem seems to be that after 
> split generation and creating min/max rowId for each row (note that since the 
> loaded file is not written by Hive ACID, it does not have ROW__ID in the 
> file; but the ROW__ID is applied on read by discovering min/max bounds which 
> are used for calculating ROW__ID.rowId for each row of a split), Hive is only 
> reading the last split.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)