[jira] [Commented] (HIVE-21976) Offset should be null instead of zero in Calcite HiveSortLimit
[
https://issues.apache.org/jira/browse/HIVE-21976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882630#comment-16882630
]
Vineet Garg commented on HIVE-21976:
+1
> Offset should be null instead of zero in Calcite HiveSortLimit
> --
>
> Key: HIVE-21976
> URL: https://issues.apache.org/jira/browse/HIVE-21976
> Project: Hive
> Issue Type: Bug
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Attachments: HIVE-21976.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Calcite expects a value equal or greater than 1. Otherwise, it may generate
> SQL from a plan incorrectly ({{offset 0}}).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21976) Offset should be null instead of zero in Calcite HiveSortLimit
[
https://issues.apache.org/jira/browse/HIVE-21976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882515#comment-16882515
]
Jesus Camacho Rodriguez commented on HIVE-21976:
[~vgarg], can you review this one? It is a small patch. Thanks
> Offset should be null instead of zero in Calcite HiveSortLimit
> --
>
> Key: HIVE-21976
> URL: https://issues.apache.org/jira/browse/HIVE-21976
> Project: Hive
> Issue Type: Bug
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Attachments: HIVE-21976.patch
>
>
> Calcite expects a value equal or greater than 1. Otherwise, it may generate
> SQL from a plan incorrectly ({{offset 0}}).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21976) Offset should be null instead of zero in Calcite HiveSortLimit
[
https://issues.apache.org/jira/browse/HIVE-21976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882513#comment-16882513
]
Hive QA commented on HIVE-21976:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12974110/HIVE-21976.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 16647 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/17949/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17949/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17949/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12974110 - PreCommit-HIVE-Build
> Offset should be null instead of zero in Calcite HiveSortLimit
> --
>
> Key: HIVE-21976
> URL: https://issues.apache.org/jira/browse/HIVE-21976
> Project: Hive
> Issue Type: Bug
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Attachments: HIVE-21976.patch
>
>
> Calcite expects a value equal or greater than 1. Otherwise, it may generate
> SQL from a plan incorrectly ({{offset 0}}).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21976) Offset should be null instead of zero in Calcite HiveSortLimit
[
https://issues.apache.org/jira/browse/HIVE-21976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882503#comment-16882503
]
Hive QA commented on HIVE-21976:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
3s{color} | {color:blue} ql in master has 2255 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17949/dev-support/hive-personality.sh
|
| git revision | master / 505a733 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17949/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Offset should be null instead of zero in Calcite HiveSortLimit
> --
>
> Key: HIVE-21976
> URL: https://issues.apache.org/jira/browse/HIVE-21976
> Project: Hive
> Issue Type: Bug
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Attachments: HIVE-21976.patch
>
>
> Calcite expects a value equal or greater than 1. Otherwise, it may generate
> SQL from a plan incorrectly ({{offset 0}}).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
