[jira] [Commented] (HIVE-22174) Clean up Drop Partition
[ https://issues.apache.org/jira/browse/HIVE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927119#comment-16927119 ] Jesus Camacho Rodriguez commented on HIVE-22174: +1 > Clean up Drop Partition > --- > > Key: HIVE-22174 > URL: https://issues.apache.org/jira/browse/HIVE-22174 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-ddl > Fix For: 4.0.0 > > Attachments: HIVE-22174.01.patch, HIVE-22174.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > There are many complex drop partition and drop partitions operations in > Hive.java, most of them are not used by anyone inside or outside of Hive. The > unused codes should be removed, and the remaining code should be as simple as > possible, calling dropPartition(s) operation at the metastore client. Also > the AlterTableDropPartitionDesc class should not be exposed here. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22174) Clean up Drop Partition
[
https://issues.apache.org/jira/browse/HIVE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924707#comment-16924707
]
Hive QA commented on HIVE-22174:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12979720/HIVE-22174.02.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 16746 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18487/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18487/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18487/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12979720 - PreCommit-HIVE-Build
> Clean up Drop Partition
> ---
>
> Key: HIVE-22174
> URL: https://issues.apache.org/jira/browse/HIVE-22174
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available, refactor-ddl
> Fix For: 4.0.0
>
> Attachments: HIVE-22174.01.patch, HIVE-22174.02.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are many complex drop partition and drop partitions operations in
> Hive.java, most of them are not used by anyone inside or outside of Hive. The
> unused codes should be removed, and the remaining code should be as simple as
> possible, calling dropPartition(s) operation at the metastore client. Also
> the AlterTableDropPartitionDesc class should not be exposed here.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HIVE-22174) Clean up Drop Partition
[
https://issues.apache.org/jira/browse/HIVE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924700#comment-16924700
]
Hive QA commented on HIVE-22174:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
36s{color} | {color:blue} ql in master has 2246 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} ql: The patch generated 0 new + 192 unchanged - 5
fixed = 192 total (was 197) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
49s{color} | {color:green} ql generated 0 new + 2244 unchanged - 2 fixed = 2244
total (was 2246) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 17s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18487/dev-support/hive-personality.sh
|
| git revision | master / 0213afb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18487/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Clean up Drop Partition
> ---
>
> Key: HIVE-22174
> URL: https://issues.apache.org/jira/browse/HIVE-22174
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available, refactor-ddl
> Fix For: 4.0.0
>
> Attachments: HIVE-22174.01.patch, HIVE-22174.02.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are many complex drop partition and drop partitions operations in
> Hive.java, most of them are not used by anyone inside or outside of Hive. The
> unused codes should be removed, and the remaining code should be as simple as
> possible, calling dropPartition(s) operation at the metastore client. Also
> the AlterTableDropPartitionDesc class should not be exposed here.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HIVE-22174) Clean up Drop Partition
[
https://issues.apache.org/jira/browse/HIVE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924525#comment-16924525
]
Hive QA commented on HIVE-22174:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12979652/HIVE-22174.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 16746 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.security.TestAuthorizationPreEventListener.testListener
(batchId=276)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18478/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18478/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18478/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12979652 - PreCommit-HIVE-Build
> Clean up Drop Partition
> ---
>
> Key: HIVE-22174
> URL: https://issues.apache.org/jira/browse/HIVE-22174
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available, refactor-ddl
> Fix For: 4.0.0
>
> Attachments: HIVE-22174.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are many complex drop partition and drop partitions operations in
> Hive.java, most of them are not used by anyone inside or outside of Hive. The
> unused codes should be removed, and the remaining code should be as simple as
> possible, calling dropPartition(s) operation at the metastore client. Also
> the AlterTableDropPartitionDesc class should not be exposed here.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HIVE-22174) Clean up Drop Partition
[
https://issues.apache.org/jira/browse/HIVE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924488#comment-16924488
]
Hive QA commented on HIVE-22174:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
46s{color} | {color:blue} ql in master has 2246 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} ql: The patch generated 0 new + 192 unchanged - 5
fixed = 192 total (was 197) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
53s{color} | {color:green} ql generated 0 new + 2244 unchanged - 2 fixed = 2244
total (was 2246) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18478/dev-support/hive-personality.sh
|
| git revision | master / 0213afb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18478/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Clean up Drop Partition
> ---
>
> Key: HIVE-22174
> URL: https://issues.apache.org/jira/browse/HIVE-22174
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available, refactor-ddl
> Fix For: 4.0.0
>
> Attachments: HIVE-22174.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are many complex drop partition and drop partitions operations in
> Hive.java, most of them are not used by anyone inside or outside of Hive. The
> unused codes should be removed, and the remaining code should be as simple as
> possible, calling dropPartition(s) operation at the metastore client. Also
> the AlterTableDropPartitionDesc class should not be exposed here.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
