[jira] [Commented] (HIVE-22183) Prepare for ZooKeeper 3.5 upgrade
[
https://issues.apache.org/jira/browse/HIVE-22183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927397#comment-16927397
]
Peter Vary commented on HIVE-22183:
---
[~belugabehr]: Sorry, I have pushed to master before seeing your comment. Feel
free to raise any questions anyway.
[~szita]: Thanks, for the review!
> Prepare for ZooKeeper 3.5 upgrade
> -
>
> Key: HIVE-22183
> URL: https://issues.apache.org/jira/browse/HIVE-22183
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-22183.patch
>
>
> Tried to run some tests with 3.5 ZooKeeper, and got the following exception:
> {code:java}
> java.io.IOException: Waiting for startup of standalone server
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:253)
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:184)
> at
> org.apache.hive.testutils.HiveTestEnvSetup$SetupZookeeper.beforeClass(HiveTestEnvSetup.java:187)
> at
> org.apache.hive.testutils.HiveTestEnvSetup.before(HiveTestEnvSetup.java:269)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:379)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:340)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:413)
> Options {code}
> We uses "stat" 4 letter command to check if the ZooKeeper cluster is running.
> In ZooKeeper 3.5 we need to whitelist the commands we use.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HIVE-22183) Prepare for ZooKeeper 3.5 upgrade
[
https://issues.apache.org/jira/browse/HIVE-22183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927396#comment-16927396
]
Peter Vary commented on HIVE-22183:
---
[~belugabehr]: I have seen these specific tests failing:
*
org.apache.hadoop.hive.ql.plan.mapping.TestReOptimization.org.apache.hadoop.hive.ql.plan.mapping.TestReOptimization
*
org.apache.hadoop.hive.ql.plan.mapping.TestStatEstimations.org.apache.hadoop.hive.ql.plan.mapping.TestStatEstimations
*
org.apache.hadoop.hive.ql.plan.mapping.TestCounterMapping.org.apache.hadoop.hive.ql.plan.mapping.TestCounterMapping
*
org.apache.hadoop.hive.ql.plan.mapping.TestOperatorCmp.org.apache.hadoop.hive.ql.plan.mapping.TestOperatorCmp
> Prepare for ZooKeeper 3.5 upgrade
> -
>
> Key: HIVE-22183
> URL: https://issues.apache.org/jira/browse/HIVE-22183
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-22183.patch
>
>
> Tried to run some tests with 3.5 ZooKeeper, and got the following exception:
> {code:java}
> java.io.IOException: Waiting for startup of standalone server
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:253)
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:184)
> at
> org.apache.hive.testutils.HiveTestEnvSetup$SetupZookeeper.beforeClass(HiveTestEnvSetup.java:187)
> at
> org.apache.hive.testutils.HiveTestEnvSetup.before(HiveTestEnvSetup.java:269)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:379)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:340)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:413)
> Options {code}
> We uses "stat" 4 letter command to check if the ZooKeeper cluster is running.
> In ZooKeeper 3.5 we need to whitelist the commands we use.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HIVE-22183) Prepare for ZooKeeper 3.5 upgrade
[
https://issues.apache.org/jira/browse/HIVE-22183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926871#comment-16926871
]
David Mollitor commented on HIVE-22183:
---
Hello [~pvary] What components in Hive are using ZK? I thought ZK-Hive
integration was going away in favor of a RDBMS system.
> Prepare for ZooKeeper 3.5 upgrade
> -
>
> Key: HIVE-22183
> URL: https://issues.apache.org/jira/browse/HIVE-22183
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-22183.patch
>
>
> Tried to run some tests with 3.5 ZooKeeper, and got the following exception:
> {code:java}
> java.io.IOException: Waiting for startup of standalone server
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:253)
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:184)
> at
> org.apache.hive.testutils.HiveTestEnvSetup$SetupZookeeper.beforeClass(HiveTestEnvSetup.java:187)
> at
> org.apache.hive.testutils.HiveTestEnvSetup.before(HiveTestEnvSetup.java:269)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:379)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:340)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:413)
> Options {code}
> We uses "stat" 4 letter command to check if the ZooKeeper cluster is running.
> In ZooKeeper 3.5 we need to whitelist the commands we use.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HIVE-22183) Prepare for ZooKeeper 3.5 upgrade
[
https://issues.apache.org/jira/browse/HIVE-22183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926740#comment-16926740
]
Hive QA commented on HIVE-22183:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12979962/HIVE-22183.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 16751 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18524/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18524/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18524/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12979962 - PreCommit-HIVE-Build
> Prepare for ZooKeeper 3.5 upgrade
> -
>
> Key: HIVE-22183
> URL: https://issues.apache.org/jira/browse/HIVE-22183
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-22183.patch
>
>
> Tried to run some tests with 3.5 ZooKeeper, and got the following exception:
> {code:java}
> java.io.IOException: Waiting for startup of standalone server
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:253)
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:184)
> at
> org.apache.hive.testutils.HiveTestEnvSetup$SetupZookeeper.beforeClass(HiveTestEnvSetup.java:187)
> at
> org.apache.hive.testutils.HiveTestEnvSetup.before(HiveTestEnvSetup.java:269)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:379)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:340)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:413)
> Options {code}
> We uses "stat" 4 letter command to check if the ZooKeeper cluster is running.
> In ZooKeeper 3.5 we need to whitelist the commands we use.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HIVE-22183) Prepare for ZooKeeper 3.5 upgrade
[
https://issues.apache.org/jira/browse/HIVE-22183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926718#comment-16926718
]
Hive QA commented on HIVE-22183:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
52s{color} | {color:blue} ql in master has 2246 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 17s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18524/dev-support/hive-personality.sh
|
| git revision | master / 1dfa2d8 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18524/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Prepare for ZooKeeper 3.5 upgrade
> -
>
> Key: HIVE-22183
> URL: https://issues.apache.org/jira/browse/HIVE-22183
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-22183.patch
>
>
> Tried to run some tests with 3.5 ZooKeeper, and got the following exception:
> {code:java}
> java.io.IOException: Waiting for startup of standalone server
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:253)
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:184)
> at
> org.apache.hive.testutils.HiveTestEnvSetup$SetupZookeeper.beforeClass(HiveTestEnvSetup.java:187)
> at
> org.apache.hive.testutils.HiveTestEnvSetup.before(HiveTestEnvSetup.java:269)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:379)
> at
> org.apache.maven.surefire.booter.Fo
[jira] [Commented] (HIVE-22183) Prepare for ZooKeeper 3.5 upgrade
[
https://issues.apache.org/jira/browse/HIVE-22183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926628#comment-16926628
]
Adam Szita commented on HIVE-22183:
---
+1 pending tests
> Prepare for ZooKeeper 3.5 upgrade
> -
>
> Key: HIVE-22183
> URL: https://issues.apache.org/jira/browse/HIVE-22183
> Project: Hive
> Issue Type: Task
>Reporter: Peter Vary
>Assignee: Peter Vary
>Priority: Major
> Attachments: HIVE-22183.patch
>
>
> Tried to run some tests with 3.5 ZooKeeper, and got the following exception:
> {code:java}
> java.io.IOException: Waiting for startup of standalone server
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:253)
> at
> org.apache.hive.testutils.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:184)
> at
> org.apache.hive.testutils.HiveTestEnvSetup$SetupZookeeper.beforeClass(HiveTestEnvSetup.java:187)
> at
> org.apache.hive.testutils.HiveTestEnvSetup.before(HiveTestEnvSetup.java:269)
> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:379)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:340)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:413)
> Options {code}
> We uses "stat" 4 letter command to check if the ZooKeeper cluster is running.
> In ZooKeeper 3.5 we need to whitelist the commands we use.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
