[jira] [Commented] (HIVE-22322) Remove Netty3 dependency of llap-server

2019-10-11 Thread Ivan Suller (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949290#comment-16949290
 ] 

Ivan Suller commented on HIVE-22322:


[~dlavati] true - it doesn't seem to be simple at all. Hive got Netty3 as a 
transitive dependency that's why it still builds without the explicit 
dependency in the pom.xml. I'm afraid this will be a big task involving other 
projects around Hadoop.

> Remove Netty3 dependency of llap-server
> ---
>
> Key: HIVE-22322
> URL: https://issues.apache.org/jira/browse/HIVE-22322
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Ivan Suller
>Assignee: Ivan Suller
>Priority: Major
> Attachments: HIVE-22322.1.patch
>
>
> Llap-server depends on both Netty3 and Netty4. As Netty3 has known security 
> issues fixed only in Netty4 we should eliminate any dependency on Netty3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22322) Remove Netty3 dependency of llap-server

2019-10-11 Thread David Lavati (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949228#comment-16949228
 ] 

David Lavati commented on HIVE-22322:
-

It might not be so simple, see HIVE-18574

> Remove Netty3 dependency of llap-server
> ---
>
> Key: HIVE-22322
> URL: https://issues.apache.org/jira/browse/HIVE-22322
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Ivan Suller
>Assignee: Ivan Suller
>Priority: Major
> Attachments: HIVE-22322.1.patch
>
>
> Llap-server depends on both Netty3 and Netty4. As Netty3 has known security 
> issues fixed only in Netty4 we should eliminate any dependency on Netty3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22322) Remove Netty3 dependency of llap-server

2019-10-10 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948688#comment-16948688
 ] 

Hive QA commented on HIVE-22322:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12982673/HIVE-22322.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17518 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18939/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18939/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18939/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12982673 - PreCommit-HIVE-Build

> Remove Netty3 dependency of llap-server
> ---
>
> Key: HIVE-22322
> URL: https://issues.apache.org/jira/browse/HIVE-22322
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Ivan Suller
>Assignee: Ivan Suller
>Priority: Major
> Attachments: HIVE-22322.1.patch
>
>
> Llap-server depends on both Netty3 and Netty4. As Netty3 has known security 
> issues fixed only in Netty4 we should eliminate any dependency on Netty3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22322) Remove Netty3 dependency of llap-server

2019-10-10 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948671#comment-16948671
 ] 

Hive QA commented on HIVE-22322:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
57s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  7m  
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
25s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  6m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  6m 
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
13s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 46m  6s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  xml  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18939/dev-support/hive-personality.sh
 |
| git revision | master / cb83da9 |
| Default Java | 1.8.0_111 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18939/yetus/patch-asflicense-problems.txt
 |
| modules | C: llap-server . U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18939/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Remove Netty3 dependency of llap-server
> ---
>
> Key: HIVE-22322
> URL: https://issues.apache.org/jira/browse/HIVE-22322
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Ivan Suller
>Assignee: Ivan Suller
>Priority: Major
> Attachments: HIVE-22322.1.patch
>
>
> Llap-server depends on both Netty3 and Netty4. As Netty3 has known security 
> issues fixed only in Netty4 we should eliminate any dependency on Netty3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)