[jira] [Commented] (HIVE-23446) LLAP: Reduce IPC connection misses to AM for short queries
[ https://issues.apache.org/jira/browse/HIVE-23446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109263#comment-17109263 ] Hive QA commented on HIVE-23446: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13003148/HIVE-23446.5.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17271 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22401/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22401/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22401/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 13003148 - PreCommit-HIVE-Build > LLAP: Reduce IPC connection misses to AM for short queries > -- > > Key: HIVE-23446 > URL: https://issues.apache.org/jira/browse/HIVE-23446 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Major > Attachments: HIVE-23446.1.patch, HIVE-23446.2.patch, > HIVE-23446.3.patch, HIVE-23446.4.patch, HIVE-23446.5.patch > > > [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java#L343] > > Umbilical UGI pool for is maintained at QueryInfo level. When there are lots > of short queries, this ends up missing IPC cache and ends up recreating > threads/connections to the same AM. > It would be good to maintain this pool in {{ContainerRunnerImpl}} instead and > recycle as needed. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23446) LLAP: Reduce IPC connection misses to AM for short queries
[ https://issues.apache.org/jira/browse/HIVE-23446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109249#comment-17109249 ] Hive QA commented on HIVE-23446: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 13s{color} | {color:red} /data/hiveptest/logs/PreCommit-HIVE-Build-22401/patches/PreCommit-HIVE-Build-22401.patch does not apply to master. Rebase required? Wrong Branch? See http://cwiki.apache.org/confluence/display/Hive/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-22401/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > LLAP: Reduce IPC connection misses to AM for short queries > -- > > Key: HIVE-23446 > URL: https://issues.apache.org/jira/browse/HIVE-23446 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Major > Attachments: HIVE-23446.1.patch, HIVE-23446.2.patch, > HIVE-23446.3.patch, HIVE-23446.4.patch, HIVE-23446.5.patch > > > [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java#L343] > > Umbilical UGI pool for is maintained at QueryInfo level. When there are lots > of short queries, this ends up missing IPC cache and ends up recreating > threads/connections to the same AM. > It would be good to maintain this pool in {{ContainerRunnerImpl}} instead and > recycle as needed. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23446) LLAP: Reduce IPC connection misses to AM for short queries
[ https://issues.apache.org/jira/browse/HIVE-23446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108984#comment-17108984 ] Hive QA commented on HIVE-23446: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13003126/HIVE-23446.4.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17271 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniDruidKafkaCliDriver.testCliDriver[druidkafkamini_basic] (batchId=225) org.apache.hive.hcatalog.streaming.TestStreaming.testConcurrentTransactionBatchCommits (batchId=149) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22388/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22388/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22388/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13003126 - PreCommit-HIVE-Build > LLAP: Reduce IPC connection misses to AM for short queries > -- > > Key: HIVE-23446 > URL: https://issues.apache.org/jira/browse/HIVE-23446 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Major > Attachments: HIVE-23446.1.patch, HIVE-23446.2.patch, > HIVE-23446.3.patch, HIVE-23446.4.patch > > > [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java#L343] > > Umbilical UGI pool for is maintained at QueryInfo level. When there are lots > of short queries, this ends up missing IPC cache and ends up recreating > threads/connections to the same AM. > It would be good to maintain this pool in {{ContainerRunnerImpl}} instead and > recycle as needed. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23446) LLAP: Reduce IPC connection misses to AM for short queries
[ https://issues.apache.org/jira/browse/HIVE-23446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108963#comment-17108963 ] Hive QA commented on HIVE-23446: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 55s{color} | {color:blue} llap-server in master has 87 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 16s{color} | {color:red} llap-server: The patch generated 8 new + 54 unchanged - 3 fixed = 62 total (was 57) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 2s{color} | {color:red} llap-server generated 3 new + 85 unchanged - 2 fixed = 88 total (was 87) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 16m 56s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:llap-server | | | Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.getUmbilicalUgi(String, Token) At ContainerRunnerImpl.java:ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.getUmbilicalUgi(String, Token) At ContainerRunnerImpl.java:[line 656] | | | Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.returnUmbilicalUgi(String, UserGroupInformation) At ContainerRunnerImpl.java:ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.returnUmbilicalUgi(String, UserGroupInformation) At ContainerRunnerImpl.java:[line 672] | | | new org.apache.hadoop.hive.llap.daemon.impl.QueryInfo(QueryIdentifier, String, String, String, String, int, String, ConcurrentMap, String[], FileSystem, String, String, LlapNodeId, String, Token, boolean, ContainerRunnerImpl$UgiPool) may expose internal representation by storing an externally mutable object into QueryInfo.localDirsBase At QueryInfo.java:String, int, String, ConcurrentMap, String[], FileSystem, String, String, LlapNodeId, String, Token, boolean, ContainerRunnerImpl$UgiPool) may expose internal representation by storing an externally mutable object into QueryInfo.localDirsBase At QueryInfo.java:[line 91] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-22388/dev-support/hive-personality.sh | | git revision | master / 31f20c8 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-22388/yetus/diff-checkstyle-llap-server.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-22388/yetus/new-findbugs-llap-server.html | | modules | C: llap-server U: llap-server | | Console output |
[jira] [Commented] (HIVE-23446) LLAP: Reduce IPC connection misses to AM for short queries
[ https://issues.apache.org/jira/browse/HIVE-23446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107425#comment-17107425 ] Hive QA commented on HIVE-23446: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13002893/HIVE-23446.3.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17269 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniDruidKafkaCliDriver.testCliDriver[druidkafkamini_delimited] (batchId=225) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22336/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22336/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22336/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 13002893 - PreCommit-HIVE-Build > LLAP: Reduce IPC connection misses to AM for short queries > -- > > Key: HIVE-23446 > URL: https://issues.apache.org/jira/browse/HIVE-23446 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Major > Attachments: HIVE-23446.1.patch, HIVE-23446.2.patch, > HIVE-23446.3.patch > > > [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java#L343] > > Umbilical UGI pool for is maintained at QueryInfo level. When there are lots > of short queries, this ends up missing IPC cache and ends up recreating > threads/connections to the same AM. > It would be good to maintain this pool in {{ContainerRunnerImpl}} instead and > recycle as needed. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23446) LLAP: Reduce IPC connection misses to AM for short queries
[ https://issues.apache.org/jira/browse/HIVE-23446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107395#comment-17107395 ] Hive QA commented on HIVE-23446: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m 22s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 16s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 52s{color} | {color:blue} llap-server in master has 87 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s{color} | {color:red} llap-server: The patch generated 8 new + 54 unchanged - 3 fixed = 62 total (was 57) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 2s{color} | {color:red} llap-server generated 3 new + 85 unchanged - 2 fixed = 88 total (was 87) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 16m 42s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:llap-server | | | Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.getUmbilicalUgi(String, Token) At ContainerRunnerImpl.java:ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.getUmbilicalUgi(String, Token) At ContainerRunnerImpl.java:[line 656] | | | Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.returnUmbilicalUgi(String, UserGroupInformation) At ContainerRunnerImpl.java:ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.returnUmbilicalUgi(String, UserGroupInformation) At ContainerRunnerImpl.java:[line 672] | | | new org.apache.hadoop.hive.llap.daemon.impl.QueryInfo(QueryIdentifier, String, String, String, String, int, String, ConcurrentMap, String[], FileSystem, String, String, LlapNodeId, String, Token, boolean, ContainerRunnerImpl$UgiPool) may expose internal representation by storing an externally mutable object into QueryInfo.localDirsBase At QueryInfo.java:String, int, String, ConcurrentMap, String[], FileSystem, String, String, LlapNodeId, String, Token, boolean, ContainerRunnerImpl$UgiPool) may expose internal representation by storing an externally mutable object into QueryInfo.localDirsBase At QueryInfo.java:[line 91] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-22336/dev-support/hive-personality.sh | | git revision | master / 390ad7d | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-22336/yetus/diff-checkstyle-llap-server.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-22336/yetus/new-findbugs-llap-server.html | | modules | C: llap-server U: llap-server | | Console output |
[jira] [Commented] (HIVE-23446) LLAP: Reduce IPC connection misses to AM for short queries
[ https://issues.apache.org/jira/browse/HIVE-23446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106925#comment-17106925 ] Ashutosh Chauhan commented on HIVE-23446: - +1 pending tests. > LLAP: Reduce IPC connection misses to AM for short queries > -- > > Key: HIVE-23446 > URL: https://issues.apache.org/jira/browse/HIVE-23446 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Major > Attachments: HIVE-23446.1.patch, HIVE-23446.2.patch > > > [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java#L343] > > Umbilical UGI pool for is maintained at QueryInfo level. When there are lots > of short queries, this ends up missing IPC cache and ends up recreating > threads/connections to the same AM. > It would be good to maintain this pool in {{ContainerRunnerImpl}} instead and > recycle as needed. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23446) LLAP: Reduce IPC connection misses to AM for short queries
[ https://issues.apache.org/jira/browse/HIVE-23446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105568#comment-17105568 ] Hive QA commented on HIVE-23446: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/13002711/HIVE-23446.1.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17266 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22287/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22287/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22287/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 13002711 - PreCommit-HIVE-Build > LLAP: Reduce IPC connection misses to AM for short queries > -- > > Key: HIVE-23446 > URL: https://issues.apache.org/jira/browse/HIVE-23446 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Major > Attachments: HIVE-23446.1.patch > > > [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java#L343] > > Umbilical UGI pool for is maintained at QueryInfo level. When there are lots > of short queries, this ends up missing IPC cache and ends up recreating > threads/connections to the same AM. > It would be good to maintain this pool in {{ContainerRunnerImpl}} instead and > recycle as needed. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23446) LLAP: Reduce IPC connection misses to AM for short queries
[ https://issues.apache.org/jira/browse/HIVE-23446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105532#comment-17105532 ] Hive QA commented on HIVE-23446: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 42s{color} | {color:blue} llap-server in master has 87 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 14s{color} | {color:red} llap-server: The patch generated 7 new + 54 unchanged - 3 fixed = 61 total (was 57) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 51s{color} | {color:red} llap-server generated 3 new + 85 unchanged - 2 fixed = 88 total (was 87) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 27s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:llap-server | | | Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.getUmbilicalUgi(String, Token) At ContainerRunnerImpl.java:ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.getUmbilicalUgi(String, Token) At ContainerRunnerImpl.java:[line 649] | | | Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.returnUmbilicalUgi(String, UserGroupInformation) At ContainerRunnerImpl.java:ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.returnUmbilicalUgi(String, UserGroupInformation) At ContainerRunnerImpl.java:[line 664] | | | new org.apache.hadoop.hive.llap.daemon.impl.QueryInfo(QueryIdentifier, String, String, String, String, int, String, ConcurrentMap, String[], FileSystem, String, String, LlapNodeId, String, Token, boolean, ContainerRunnerImpl$UgiPool) may expose internal representation by storing an externally mutable object into QueryInfo.localDirsBase At QueryInfo.java:String, int, String, ConcurrentMap, String[], FileSystem, String, String, LlapNodeId, String, Token, boolean, ContainerRunnerImpl$UgiPool) may expose internal representation by storing an externally mutable object into QueryInfo.localDirsBase At QueryInfo.java:[line 91] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-22287/dev-support/hive-personality.sh | | git revision | master / 57c1593 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-22287/yetus/diff-checkstyle-llap-server.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-22287/yetus/new-findbugs-llap-server.html | | modules | C: llap-server U: llap-server | | Console output |
[jira] [Commented] (HIVE-23446) LLAP: Reduce IPC connection misses to AM for short queries
[ https://issues.apache.org/jira/browse/HIVE-23446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105362#comment-17105362 ] Rajesh Balamohan commented on HIVE-23446: - RB link: https://reviews.apache.org/r/72499/diff/1#index_header > LLAP: Reduce IPC connection misses to AM for short queries > -- > > Key: HIVE-23446 > URL: https://issues.apache.org/jira/browse/HIVE-23446 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Major > Attachments: HIVE-23446.1.patch > > > [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java#L343] > > Umbilical UGI pool for is maintained at QueryInfo level. When there are lots > of short queries, this ends up missing IPC cache and ends up recreating > threads/connections to the same AM. > It would be good to maintain this pool in {{ContainerRunnerImpl}} instead and > recycle as needed. > -- This message was sent by Atlassian Jira (v8.3.4#803005)