[jira] [Commented] (HIVE-9086) Add language support to PURGE data while dropping partitions.
[ https://issues.apache.org/jira/browse/HIVE-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14352746#comment-14352746 ] Lefty Leverenz commented on HIVE-9086: -- Doc note: The documentation has been revised (please review). * [LanguageManual DDL -- Drop Partitions | https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-DropPartitions] Add language support to PURGE data while dropping partitions. - Key: HIVE-9086 URL: https://issues.apache.org/jira/browse/HIVE-9086 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.15.0 Reporter: Mithun Radhakrishnan Assignee: Mithun Radhakrishnan Fix For: 1.2.0 Attachments: HIVE-9086.1.patch HIVE-9083 adds metastore-support to skip-trash while dropping partitions. This patch includes language support to do the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9086) Add language support to PURGE data while dropping partitions.
[ https://issues.apache.org/jira/browse/HIVE-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346074#comment-14346074 ] Lefty Leverenz commented on HIVE-9086: -- Doc note: When documenting this, remember the new table property auto.purge introduced in HIVE-9118. Add language support to PURGE data while dropping partitions. - Key: HIVE-9086 URL: https://issues.apache.org/jira/browse/HIVE-9086 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.15.0 Reporter: Mithun Radhakrishnan Assignee: Mithun Radhakrishnan Attachments: HIVE-9086.1.patch HIVE-9083 adds metastore-support to skip-trash while dropping partitions. This patch includes language support to do the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9086) Add language support to PURGE data while dropping partitions.
[ https://issues.apache.org/jira/browse/HIVE-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14336585#comment-14336585 ] Timothy Driscoll commented on HIVE-9086: The way it is documented seems to be more in line with how the DROP TABLE syntax is formatted, which is why I brought it up. We've applied the patch (along with HIVE-9083) and it seems to be working as expected. I just wanted to validate (to whatever extent possible) that the patch syntax is going to be the syntax going forward before we update our scripts. Add language support to PURGE data while dropping partitions. - Key: HIVE-9086 URL: https://issues.apache.org/jira/browse/HIVE-9086 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.15.0 Reporter: Mithun Radhakrishnan Assignee: Mithun Radhakrishnan Attachments: HIVE-9086.1.patch HIVE-9083 adds metastore-support to skip-trash while dropping partitions. This patch includes language support to do the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9086) Add language support to PURGE data while dropping partitions.
[ https://issues.apache.org/jira/browse/HIVE-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14336980#comment-14336980 ] Eugene Koifman commented on HIVE-9086: -- [~mithun], do you want me to check in the patch as is or are you planning to make changes based on above comments? Add language support to PURGE data while dropping partitions. - Key: HIVE-9086 URL: https://issues.apache.org/jira/browse/HIVE-9086 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.15.0 Reporter: Mithun Radhakrishnan Assignee: Mithun Radhakrishnan Attachments: HIVE-9086.1.patch HIVE-9083 adds metastore-support to skip-trash while dropping partitions. This patch includes language support to do the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9086) Add language support to PURGE data while dropping partitions.
[ https://issues.apache.org/jira/browse/HIVE-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337437#comment-14337437 ] Xuefu Zhang commented on HIVE-9086: --- Could we get a summary on the disagreement here? If the syntax for table is adding PURGE after table name, we should be adding PURGE after partition spec just to be consistent. Add language support to PURGE data while dropping partitions. - Key: HIVE-9086 URL: https://issues.apache.org/jira/browse/HIVE-9086 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.15.0 Reporter: Mithun Radhakrishnan Assignee: Mithun Radhakrishnan Attachments: HIVE-9086.1.patch HIVE-9083 adds metastore-support to skip-trash while dropping partitions. This patch includes language support to do the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9086) Add language support to PURGE data while dropping partitions.
[ https://issues.apache.org/jira/browse/HIVE-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337374#comment-14337374 ] Lefty Leverenz commented on HIVE-9086: -- bq. FWIW, I prefer the syntax from the patch. I think it reads more cleanly. Agreed, DROP PURGE PARTITION is harder to understand than DROP PARTITION PURGE. The IF EXISTS option doesn't have the same natural language problem. But it's confusing to put PURGE after PARTITION in the ALTER statement (separate from IF EXISTS) while the DROP TABLE statement puts it next to IF EXISTS. * Would the DROP TABLE syntax be better if it were DROP TABLE IF EXISTS table_name PURGE? But that breaks backward compatibility (PURGE was added in 0.14.0). * Should the syntax of both statements be changed to tolerate either placement of PURGE? Add language support to PURGE data while dropping partitions. - Key: HIVE-9086 URL: https://issues.apache.org/jira/browse/HIVE-9086 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.15.0 Reporter: Mithun Radhakrishnan Assignee: Mithun Radhakrishnan Attachments: HIVE-9086.1.patch HIVE-9083 adds metastore-support to skip-trash while dropping partitions. This patch includes language support to do the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9086) Add language support to PURGE data while dropping partitions.
[ https://issues.apache.org/jira/browse/HIVE-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337520#comment-14337520 ] Mithun Radhakrishnan commented on HIVE-9086: Judging from [the patch|https://issues.apache.org/jira/secure/attachment/12670435/HIVE-7100.11.patch#file-12], HIVE-7100 added the drop-table-purge functionality to read thus: {code:sql} DROP TABLE IF EXISTS my_doomed_table PURGE; {code} The current alter table drop partitions reads as follows: {code:sql} ALTER TABLE my_doomed_table DROP IF EXISTS PARTITION (part_key = sayonara) IGNORE PROTECTION; {code} HIVE-9086 extends HIVE-7100's purge-functionality to partitions, and suggests that the {{PURGE}} keyword go at the end, thus: {code:sql} ALTER TABLE my_doomed_table DROP IF EXISTS PARTITION (part_key = sayonara) IGNORE PROTECTION PURGE; {code} Should {{PURGE}} sit before/after {{IF EXISTS}} or after {{IGNORE PROTECTION}}? We can't break backward compatibility, so we shouldn't be changing what we released in 0.14. Add language support to PURGE data while dropping partitions. - Key: HIVE-9086 URL: https://issues.apache.org/jira/browse/HIVE-9086 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.15.0 Reporter: Mithun Radhakrishnan Assignee: Mithun Radhakrishnan Attachments: HIVE-9086.1.patch HIVE-9083 adds metastore-support to skip-trash while dropping partitions. This patch includes language support to do the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)