[jira] [Updated] (HIVE-18084) Upgrade checkstyle version to support lambdas

2017-11-17 Thread Alan Gates (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Gates updated HIVE-18084:
--
   Resolution: Fixed
Fix Version/s: 3.0.0
   Status: Resolved  (was: Patch Available)

+1, I've committed the patch.  I think the changes in warnings are fine and it 
makes it so the checkstyle build passes.

A general question, are you planning to address the warnings and eventually 
fail on warnings as well?  Or are there a subset of the warnings that are 
important that we should fix and promote to errors?

> Upgrade checkstyle version to support lambdas
> -
>
> Key: HIVE-18084
> URL: https://issues.apache.org/jira/browse/HIVE-18084
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Adam Szita
>Assignee: Adam Szita
> Fix For: 3.0.0
>
> Attachments: HIVE-18084.0.patch, diff.txt
>
>
> Current version does not support lambdas in source files so it skips them. We 
> need to upgrade checkstyle version to fix this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HIVE-18084) Upgrade checkstyle version to support lambdas

2017-11-16 Thread Adam Szita (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Szita updated HIVE-18084:
--
Attachment: diff.txt

> Upgrade checkstyle version to support lambdas
> -
>
> Key: HIVE-18084
> URL: https://issues.apache.org/jira/browse/HIVE-18084
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Adam Szita
>Assignee: Adam Szita
> Attachments: HIVE-18084.0.patch, diff.txt
>
>
> Current version does not support lambdas in source files so it skips them. We 
> need to upgrade checkstyle version to fix this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HIVE-18084) Upgrade checkstyle version to support lambdas

2017-11-16 Thread Adam Szita (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Szita updated HIVE-18084:
--
Status: Patch Available  (was: In Progress)

> Upgrade checkstyle version to support lambdas
> -
>
> Key: HIVE-18084
> URL: https://issues.apache.org/jira/browse/HIVE-18084
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Adam Szita
>Assignee: Adam Szita
> Attachments: HIVE-18084.0.patch
>
>
> Current version does not support lambdas in source files so it skips them. We 
> need to upgrade checkstyle version to fix this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HIVE-18084) Upgrade checkstyle version to support lambdas

2017-11-16 Thread Adam Szita (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Szita updated HIVE-18084:
--
Attachment: HIVE-18084.0.patch

> Upgrade checkstyle version to support lambdas
> -
>
> Key: HIVE-18084
> URL: https://issues.apache.org/jira/browse/HIVE-18084
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Adam Szita
>Assignee: Adam Szita
> Attachments: HIVE-18084.0.patch
>
>
> Current version does not support lambdas in source files so it skips them. We 
> need to upgrade checkstyle version to fix this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (HIVE-18084) Upgrade checkstyle version to support lambdas

2017-11-16 Thread Adam Szita (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Szita updated HIVE-18084:
--
Description: Current version does not support lambdas in source files so it 
skips them. We need to upgrade checkstyle version to fix this.

> Upgrade checkstyle version to support lambdas
> -
>
> Key: HIVE-18084
> URL: https://issues.apache.org/jira/browse/HIVE-18084
> Project: Hive
>  Issue Type: Sub-task
>Reporter: Adam Szita
>Assignee: Adam Szita
>
> Current version does not support lambdas in source files so it skips them. We 
> need to upgrade checkstyle version to fix this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)