[jira] [Work logged] (HIVE-22184) Extract LockedDriverState from Driver
[ https://issues.apache.org/jira/browse/HIVE-22184?focusedWorklogId=311893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311893 ] ASF GitHub Bot logged work on HIVE-22184: - Author: ASF GitHub Bot Created on: 13/Sep/19 06:54 Start Date: 13/Sep/19 06:54 Worklog Time Spent: 10m Work Description: miklosgergely commented on pull request #767: HIVE-22184 Extract LockedDriverState from Driver URL: https://github.com/apache/hive/pull/767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311893) Time Spent: 0.5h (was: 20m) > Extract LockedDriverState from Driver > - > > Key: HIVE-22184 > URL: https://issues.apache.org/jira/browse/HIVE-22184 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Minor > Labels: pull-request-available, refactor-driver > Attachments: HIVE-22184.01.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > LockedDriverState is a nested class within Driver, while it is used outside > of it as well, and it is complex enough to be a class on it's own. > DriverState should be it's nested class, and transitions / locking should be > facilitated by functions within it. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (HIVE-22184) Extract LockedDriverState from Driver
[
https://issues.apache.org/jira/browse/HIVE-22184?focusedWorklogId=311781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311781
]
ASF GitHub Bot logged work on HIVE-22184:
-
Author: ASF GitHub Bot
Created on: 12/Sep/19 22:22
Start Date: 12/Sep/19 22:22
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #767: HIVE-22184
Extract LockedDriverState from Driver
URL: https://github.com/apache/hive/pull/767#discussion_r323973362
##
File path: ql/src/java/org/apache/hadoop/hive/ql/LockedDriverState.java
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql;
+
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.locks.ReentrantLock;
+
+/**
+ * Represents the driver's state. Also has mechanism for locking for the time
of state transitions.
+ */
+public class LockedDriverState {
Review comment:
Let's rename it from `LockedDriverState` to `DriverState`? The private enum
may be just `State`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 311781)
Time Spent: 20m (was: 10m)
> Extract LockedDriverState from Driver
> -
>
> Key: HIVE-22184
> URL: https://issues.apache.org/jira/browse/HIVE-22184
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Minor
> Labels: pull-request-available, refactor-driver
> Attachments: HIVE-22184.01.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> LockedDriverState is a nested class within Driver, while it is used outside
> of it as well, and it is complex enough to be a class on it's own.
> DriverState should be it's nested class, and transitions / locking should be
> facilitated by functions within it.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (HIVE-22184) Extract LockedDriverState from Driver
[ https://issues.apache.org/jira/browse/HIVE-22184?focusedWorklogId=310533&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310533 ] ASF GitHub Bot logged work on HIVE-22184: - Author: ASF GitHub Bot Created on: 11/Sep/19 12:31 Start Date: 11/Sep/19 12:31 Worklog Time Spent: 10m Work Description: miklosgergely commented on pull request #767: HIVE-22184 Extract LockedDriverState from Driver URL: https://github.com/apache/hive/pull/767 LockedDriverState is a nested class within Driver, while it is used outside of it as well, and it is complex enough to be a class on it's own. DriverState should be it's nested class, and transitions / locking should be facilitated by functions within it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 310533) Remaining Estimate: 0h Time Spent: 10m > Extract LockedDriverState from Driver > - > > Key: HIVE-22184 > URL: https://issues.apache.org/jira/browse/HIVE-22184 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Minor > Labels: pull-request-available, refactor-driver > Attachments: HIVE-22184.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > LockedDriverState is a nested class within Driver, while it is used outside > of it as well, and it is complex enough to be a class on it's own. > DriverState should be it's nested class, and transitions / locking should be > facilitated by functions within it. -- This message was sent by Atlassian Jira (v8.3.2#803003)
