[jira] [Work logged] (HIVE-22188) Clean up the SemanticAnalyzerFactory
[ https://issues.apache.org/jira/browse/HIVE-22188?focusedWorklogId=311882=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311882 ] ASF GitHub Bot logged work on HIVE-22188: - Author: ASF GitHub Bot Created on: 13/Sep/19 05:57 Start Date: 13/Sep/19 05:57 Worklog Time Spent: 10m Work Description: miklosgergely commented on pull request #768: HIVE-22188 Clean up the SemanticAnalyzerFactory URL: https://github.com/apache/hive/pull/768 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311882) Time Spent: 40m (was: 0.5h) > Clean up the SemanticAnalyzerFactory > > > Key: HIVE-22188 > URL: https://issues.apache.org/jira/browse/HIVE-22188 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-semanticanalyzer > Fix For: 4.0.0 > > Attachments: HIVE-22188.01.patch > > Time Spent: 40m > Remaining Estimate: 0h > > SemanticAnalyzerFactory contains some huge maps that assign tokentypes to > hive operations. Some operations share a token type for doing them on a > table, or on a partition, which leads to some more overcomplication. > Two things need to be done: > # Each operation must have it's own token. > # The HiveOperation enum constants themselves must declare which token they > are related to, and not some external source should declare information about > them. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (HIVE-22188) Clean up the SemanticAnalyzerFactory
[
https://issues.apache.org/jira/browse/HIVE-22188?focusedWorklogId=311881=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311881
]
ASF GitHub Bot logged work on HIVE-22188:
-
Author: ASF GitHub Bot
Created on: 13/Sep/19 05:55
Start Date: 13/Sep/19 05:55
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #768:
HIVE-22188 Clean up the SemanticAnalyzerFactory
URL: https://github.com/apache/hive/pull/768#discussion_r324044354
##
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
##
@@ -342,33 +342,41 @@ public void analyzeInternal(ASTNode input) throws
SemanticException {
analyzeAlterTableProps(qualified, null, ast, false, false);
} else if (ast.getType() == HiveParser.TOK_ALTERTABLE_DROPPROPERTIES) {
analyzeAlterTableProps(qualified, null, ast, false, true);
- } else if (ast.getType() == HiveParser.TOK_ALTERTABLE_UPDATESTATS) {
+ } else if (ast.getType() == HiveParser.TOK_ALTERTABLE_UPDATESTATS ||
Review comment:
In the long term the whole DDLSemanticAnalyzer will be removed by extracting
each DDL analyzer to it's own class.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 311881)
Time Spent: 0.5h (was: 20m)
> Clean up the SemanticAnalyzerFactory
>
>
> Key: HIVE-22188
> URL: https://issues.apache.org/jira/browse/HIVE-22188
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available, refactor-semanticanalyzer
> Fix For: 4.0.0
>
> Attachments: HIVE-22188.01.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> SemanticAnalyzerFactory contains some huge maps that assign tokentypes to
> hive operations. Some operations share a token type for doing them on a
> table, or on a partition, which leads to some more overcomplication.
> Two things need to be done:
> # Each operation must have it's own token.
> # The HiveOperation enum constants themselves must declare which token they
> are related to, and not some external source should declare information about
> them.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (HIVE-22188) Clean up the SemanticAnalyzerFactory
[
https://issues.apache.org/jira/browse/HIVE-22188?focusedWorklogId=311780=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311780
]
ASF GitHub Bot logged work on HIVE-22188:
-
Author: ASF GitHub Bot
Created on: 12/Sep/19 22:09
Start Date: 12/Sep/19 22:09
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #768: HIVE-22188
Clean up the SemanticAnalyzerFactory
URL: https://github.com/apache/hive/pull/768#discussion_r323967929
##
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
##
@@ -342,33 +342,41 @@ public void analyzeInternal(ASTNode input) throws
SemanticException {
analyzeAlterTableProps(qualified, null, ast, false, false);
} else if (ast.getType() == HiveParser.TOK_ALTERTABLE_DROPPROPERTIES) {
analyzeAlterTableProps(qualified, null, ast, false, true);
- } else if (ast.getType() == HiveParser.TOK_ALTERTABLE_UPDATESTATS) {
+ } else if (ast.getType() == HiveParser.TOK_ALTERTABLE_UPDATESTATS ||
Review comment:
We could make this a _switch_ statement too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 311780)
Time Spent: 20m (was: 10m)
> Clean up the SemanticAnalyzerFactory
>
>
> Key: HIVE-22188
> URL: https://issues.apache.org/jira/browse/HIVE-22188
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Miklos Gergely
>Assignee: Miklos Gergely
>Priority: Major
> Labels: pull-request-available, refactor-semanticanalyzer
> Fix For: 4.0.0
>
> Attachments: HIVE-22188.01.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> SemanticAnalyzerFactory contains some huge maps that assign tokentypes to
> hive operations. Some operations share a token type for doing them on a
> table, or on a partition, which leads to some more overcomplication.
> Two things need to be done:
> # Each operation must have it's own token.
> # The HiveOperation enum constants themselves must declare which token they
> are related to, and not some external source should declare information about
> them.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (HIVE-22188) Clean up the SemanticAnalyzerFactory
[ https://issues.apache.org/jira/browse/HIVE-22188?focusedWorklogId=310767=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310767 ] ASF GitHub Bot logged work on HIVE-22188: - Author: ASF GitHub Bot Created on: 11/Sep/19 15:59 Start Date: 11/Sep/19 15:59 Worklog Time Spent: 10m Work Description: miklosgergely commented on pull request #768: HIVE-22188 Clean up the SemanticAnalyzerFactory URL: https://github.com/apache/hive/pull/768 SemanticAnalyzerFactory contains some huge maps that assign tokentypes to hive operations. Some operations share a token type for doing them on a table, or on a partition, which leads to some more overcomplication. Two things need to be done: 1. Each operation must have it's own token. 2. The HiveOperation enum constants themselves must declare which token they are related to, and not some external source should declare information about them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 310767) Remaining Estimate: 0h Time Spent: 10m > Clean up the SemanticAnalyzerFactory > > > Key: HIVE-22188 > URL: https://issues.apache.org/jira/browse/HIVE-22188 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available, refactor-semanticanalyzer > Fix For: 4.0.0 > > Attachments: HIVE-22188.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > SemanticAnalyzerFactory contains some huge maps that assign tokentypes to > hive operations. Some operations share a token type for doing them on a > table, or on a partition, which leads to some more overcomplication. > Two things need to be done: > # Each operation must have it's own token. > # The HiveOperation enum constants themselves must declare which token they > are related to, and not some external source should declare information about > them. -- This message was sent by Atlassian Jira (v8.3.2#803003)
