[jira] [Work logged] (HIVE-22366) Multiple metastore calls for same table and constraints during planning

2020-06-06 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22366?focusedWorklogId=442142=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442142
 ]

ASF GitHub Bot logged work on HIVE-22366:
-

Author: ASF GitHub Bot
Created on: 06/Jun/20 00:26
Start Date: 06/Jun/20 00:26
Worklog Time Spent: 10m 
  Work Description: github-actions[bot] commented on pull request #888:
URL: https://github.com/apache/hive/pull/888#issuecomment-639914331


   This pull request has been automatically marked as stale because it has not 
had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the d...@hive.apache.org list if the patch is in 
need of reviews.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 442142)
Time Spent: 50m  (was: 40m)

> Multiple metastore calls for same table and constraints during planning
> ---
>
> Key: HIVE-22366
> URL: https://issues.apache.org/jira/browse/HIVE-22366
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22366.1.patch, HIVE-22366.2.patch, 
> HIVE-22366.3.patch, HIVE-22366.4.patch, HIVE-22366.5.patch, 
> HIVE-22366.6.patch, HIVE-22366.7.patch, HIVE-22366.8.patch
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> e.g. for a simple query like
> {code:sql}
> explain select count(i) from test2 group by j limit 3;
> {code}
> planner makes the following calls:
> {code}
> 2019-10-17T22:44:49,892  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  cmd=get_table : 
> tbl=hive.default.test2
> 2019-10-17T22:44:49,908  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_primary_keys : tbl=hive.default.test2
> 2019-10-17T22:44:49,910  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_foreign_keys : parentdb=null parenttbl=null foreigndb=default 
> foreigntbl=test2
> 2019-10-17T22:44:49,911  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_unique_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,913  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_not_null_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,979  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_partitions : tbl=hive.default.test2
> 2019-10-17T22:44:49,997  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_aggr_stats_for: table=hive.default.test2
> 2019-10-17T22:44:50,014  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  cmd=get_table : 
> tbl=hive.default.test2
> 2019-10-17T22:44:50,023  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_primary_keys : tbl=hive.default.test2
> 2019-10-17T22:44:50,024  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_foreign_keys : parentdb=null parenttbl=null foreigndb=default 
> foreigntbl=test2
> 2019-10-17T22:44:50,025  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_unique_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:50,026  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_not_null_constraints : tbl=hive.default.test2
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-22366) Multiple metastore calls for same table and constraints during planning

2020-06-06 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22366?focusedWorklogId=442135=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442135
 ]

ASF GitHub Bot logged work on HIVE-22366:
-

Author: ASF GitHub Bot
Created on: 06/Jun/20 00:25
Start Date: 06/Jun/20 00:25
Worklog Time Spent: 10m 
  Work Description: github-actions[bot] closed pull request #888:
URL: https://github.com/apache/hive/pull/888


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 442135)
Time Spent: 40m  (was: 0.5h)

> Multiple metastore calls for same table and constraints during planning
> ---
>
> Key: HIVE-22366
> URL: https://issues.apache.org/jira/browse/HIVE-22366
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22366.1.patch, HIVE-22366.2.patch, 
> HIVE-22366.3.patch, HIVE-22366.4.patch, HIVE-22366.5.patch, 
> HIVE-22366.6.patch, HIVE-22366.7.patch, HIVE-22366.8.patch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> e.g. for a simple query like
> {code:sql}
> explain select count(i) from test2 group by j limit 3;
> {code}
> planner makes the following calls:
> {code}
> 2019-10-17T22:44:49,892  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  cmd=get_table : 
> tbl=hive.default.test2
> 2019-10-17T22:44:49,908  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_primary_keys : tbl=hive.default.test2
> 2019-10-17T22:44:49,910  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_foreign_keys : parentdb=null parenttbl=null foreigndb=default 
> foreigntbl=test2
> 2019-10-17T22:44:49,911  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_unique_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,913  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_not_null_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,979  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_partitions : tbl=hive.default.test2
> 2019-10-17T22:44:49,997  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_aggr_stats_for: table=hive.default.test2
> 2019-10-17T22:44:50,014  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  cmd=get_table : 
> tbl=hive.default.test2
> 2019-10-17T22:44:50,023  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_primary_keys : tbl=hive.default.test2
> 2019-10-17T22:44:50,024  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_foreign_keys : parentdb=null parenttbl=null foreigndb=default 
> foreigntbl=test2
> 2019-10-17T22:44:50,025  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_unique_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:50,026  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_not_null_constraints : tbl=hive.default.test2
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-22366) Multiple metastore calls for same table and constraints during planning

2020-01-27 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22366?focusedWorklogId=377798=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377798
 ]

ASF GitHub Bot logged work on HIVE-22366:
-

Author: ASF GitHub Bot
Created on: 27/Jan/20 18:38
Start Date: 27/Jan/20 18:38
Worklog Time Spent: 10m 
  Work Description: vineetgarg02 commented on pull request #888: 
HIVE-22366: Multiple metastore calls for same table and constraints d…
URL: https://github.com/apache/hive/pull/888#discussion_r371412106
 
 

 ##
 File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java
 ##
 @@ -1126,71 +1149,167 @@ public Boolean isOutdatedForRewriting() {
 return outdatedForRewritingMaterializedView;
   }
 
-  /* These are only populated during optimization and describing */
+  public ColumnStatistics getColStats() {
+return tTable.isSetColStats() ? tTable.getColStats() : null;
+  }
+
+  /**
+   * Setup the table level stats as if the table is new. Used when setting up 
Table for a new
+   * table or during replication.
+   */
+  public void setStatsStateLikeNewTable() {
+if (isPartitioned()) {
+  StatsSetupConst.setStatsStateForCreateTable(getParameters(), null,
+  StatsSetupConst.FALSE);
+} else {
+  StatsSetupConst.setStatsStateForCreateTable(getParameters(),
+  MetaStoreUtils.getColumnNames(getCols()), StatsSetupConst.TRUE);
+}
+  }
+
+  /** Constraints related methods
+   *  Note that set apis are used by DESCRIBE only, although get apis return 
RELY or ENABLE
+   *  constraints DESCRIBE could set all type of constraints
+   * */
+
+  /* This only return PK with RELY */
   public PrimaryKeyInfo getPrimaryKeyInfo() {
+if(!this.isPKFetched) {
+  try {
+pki = Hive.get().getReliablePrimaryKeys(this.getDbName(), 
this.getTableName());
+this.isPKFetched = true;
+  } catch (HiveException e) {
+LOG.warn("Cannot retrieve PK info for table : " + this.getTableName()
++ " ignoring exception: " + e);
+  }
+}
 return pki;
   }
 
   public void setPrimaryKeyInfo(PrimaryKeyInfo pki) {
 this.pki = pki;
+this.isPKFetched = true;
   }
 
+  /* This only return FK with RELY */
   public ForeignKeyInfo getForeignKeyInfo() {
 
 Review comment:
   Created https://issues.apache.org/jira/browse/HIVE-22782 for follow-up
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 377798)
Time Spent: 0.5h  (was: 20m)

> Multiple metastore calls for same table and constraints during planning
> ---
>
> Key: HIVE-22366
> URL: https://issues.apache.org/jira/browse/HIVE-22366
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22366.1.patch, HIVE-22366.2.patch, 
> HIVE-22366.3.patch, HIVE-22366.4.patch, HIVE-22366.5.patch, 
> HIVE-22366.6.patch, HIVE-22366.7.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> e.g. for a simple query like
> {code:sql}
> explain select count(i) from test2 group by j limit 3;
> {code}
> planner makes the following calls:
> {code}
> 2019-10-17T22:44:49,892  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  cmd=get_table : 
> tbl=hive.default.test2
> 2019-10-17T22:44:49,908  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_primary_keys : tbl=hive.default.test2
> 2019-10-17T22:44:49,910  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_foreign_keys : parentdb=null parenttbl=null foreigndb=default 
> foreigntbl=test2
> 2019-10-17T22:44:49,911  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_unique_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,913  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_not_null_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,979  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_partitions : tbl=hive.default.test2
> 2019-10-17T22:44:49,997  INFO 

[jira] [Work logged] (HIVE-22366) Multiple metastore calls for same table and constraints during planning

2020-01-26 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22366?focusedWorklogId=377479=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377479
 ]

ASF GitHub Bot logged work on HIVE-22366:
-

Author: ASF GitHub Bot
Created on: 27/Jan/20 05:41
Start Date: 27/Jan/20 05:41
Worklog Time Spent: 10m 
  Work Description: jcamachor commented on pull request #888: HIVE-22366: 
Multiple metastore calls for same table and constraints d…
URL: https://github.com/apache/hive/pull/888#discussion_r371064490
 
 

 ##
 File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java
 ##
 @@ -121,6 +121,16 @@
   private transient DefaultConstraint dc;
   private transient CheckConstraint cc;
 
+  /** Constraint related flags
+   *  This is to track if constraints are retrieved from metastore or not
+   */
+  private boolean isPKFetched=false;
 
 Review comment:
   These can be transient.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 377479)
Time Spent: 20m  (was: 10m)

> Multiple metastore calls for same table and constraints during planning
> ---
>
> Key: HIVE-22366
> URL: https://issues.apache.org/jira/browse/HIVE-22366
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22366.1.patch, HIVE-22366.2.patch, 
> HIVE-22366.3.patch, HIVE-22366.4.patch, HIVE-22366.5.patch, 
> HIVE-22366.6.patch, HIVE-22366.7.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> e.g. for a simple query like
> {code:sql}
> explain select count(i) from test2 group by j limit 3;
> {code}
> planner makes the following calls:
> {code}
> 2019-10-17T22:44:49,892  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  cmd=get_table : 
> tbl=hive.default.test2
> 2019-10-17T22:44:49,908  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_primary_keys : tbl=hive.default.test2
> 2019-10-17T22:44:49,910  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_foreign_keys : parentdb=null parenttbl=null foreigndb=default 
> foreigntbl=test2
> 2019-10-17T22:44:49,911  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_unique_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,913  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_not_null_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,979  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_partitions : tbl=hive.default.test2
> 2019-10-17T22:44:49,997  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_aggr_stats_for: table=hive.default.test2
> 2019-10-17T22:44:50,014  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  cmd=get_table : 
> tbl=hive.default.test2
> 2019-10-17T22:44:50,023  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_primary_keys : tbl=hive.default.test2
> 2019-10-17T22:44:50,024  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_foreign_keys : parentdb=null parenttbl=null foreigndb=default 
> foreigntbl=test2
> 2019-10-17T22:44:50,025  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_unique_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:50,026  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_not_null_constraints : tbl=hive.default.test2
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (HIVE-22366) Multiple metastore calls for same table and constraints during planning

2020-01-26 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22366?focusedWorklogId=377480=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377480
 ]

ASF GitHub Bot logged work on HIVE-22366:
-

Author: ASF GitHub Bot
Created on: 27/Jan/20 05:41
Start Date: 27/Jan/20 05:41
Worklog Time Spent: 10m 
  Work Description: jcamachor commented on pull request #888: HIVE-22366: 
Multiple metastore calls for same table and constraints d…
URL: https://github.com/apache/hive/pull/888#discussion_r371065177
 
 

 ##
 File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java
 ##
 @@ -1126,71 +1149,167 @@ public Boolean isOutdatedForRewriting() {
 return outdatedForRewritingMaterializedView;
   }
 
-  /* These are only populated during optimization and describing */
+  public ColumnStatistics getColStats() {
+return tTable.isSetColStats() ? tTable.getColStats() : null;
+  }
+
+  /**
+   * Setup the table level stats as if the table is new. Used when setting up 
Table for a new
+   * table or during replication.
+   */
+  public void setStatsStateLikeNewTable() {
+if (isPartitioned()) {
+  StatsSetupConst.setStatsStateForCreateTable(getParameters(), null,
+  StatsSetupConst.FALSE);
+} else {
+  StatsSetupConst.setStatsStateForCreateTable(getParameters(),
+  MetaStoreUtils.getColumnNames(getCols()), StatsSetupConst.TRUE);
+}
+  }
+
+  /** Constraints related methods
+   *  Note that set apis are used by DESCRIBE only, although get apis return 
RELY or ENABLE
+   *  constraints DESCRIBE could set all type of constraints
+   * */
+
+  /* This only return PK with RELY */
   public PrimaryKeyInfo getPrimaryKeyInfo() {
+if(!this.isPKFetched) {
+  try {
+pki = Hive.get().getReliablePrimaryKeys(this.getDbName(), 
this.getTableName());
+this.isPKFetched = true;
+  } catch (HiveException e) {
+LOG.warn("Cannot retrieve PK info for table : " + this.getTableName()
++ " ignoring exception: " + e);
+  }
+}
 return pki;
   }
 
   public void setPrimaryKeyInfo(PrimaryKeyInfo pki) {
 this.pki = pki;
+this.isPKFetched = true;
   }
 
+  /* This only return FK with RELY */
   public ForeignKeyInfo getForeignKeyInfo() {
 
 Review comment:
   This solution will still make different calls to retrieve each type of 
constraints. Should we create a follow-up for that?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 377480)
Time Spent: 20m  (was: 10m)

> Multiple metastore calls for same table and constraints during planning
> ---
>
> Key: HIVE-22366
> URL: https://issues.apache.org/jira/browse/HIVE-22366
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22366.1.patch, HIVE-22366.2.patch, 
> HIVE-22366.3.patch, HIVE-22366.4.patch, HIVE-22366.5.patch, 
> HIVE-22366.6.patch, HIVE-22366.7.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> e.g. for a simple query like
> {code:sql}
> explain select count(i) from test2 group by j limit 3;
> {code}
> planner makes the following calls:
> {code}
> 2019-10-17T22:44:49,892  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  cmd=get_table : 
> tbl=hive.default.test2
> 2019-10-17T22:44:49,908  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_primary_keys : tbl=hive.default.test2
> 2019-10-17T22:44:49,910  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_foreign_keys : parentdb=null parenttbl=null foreigndb=default 
> foreigntbl=test2
> 2019-10-17T22:44:49,911  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_unique_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,913  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_not_null_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,979  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_partitions : 

[jira] [Work logged] (HIVE-22366) Multiple metastore calls for same table and constraints during planning

2020-01-23 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HIVE-22366?focusedWorklogId=376411=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376411
 ]

ASF GitHub Bot logged work on HIVE-22366:
-

Author: ASF GitHub Bot
Created on: 23/Jan/20 18:22
Start Date: 23/Jan/20 18:22
Worklog Time Spent: 10m 
  Work Description: vineetgarg02 commented on pull request #888: 
HIVE-22366: Multiple metastore calls for same table and constraints d…
URL: https://github.com/apache/hive/pull/888
 
 
   …uring planning
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 376411)
Remaining Estimate: 0h
Time Spent: 10m

> Multiple metastore calls for same table and constraints during planning
> ---
>
> Key: HIVE-22366
> URL: https://issues.apache.org/jira/browse/HIVE-22366
> Project: Hive
>  Issue Type: Improvement
>  Components: Query Planning
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
>  Labels: pull-request-available
> Attachments: HIVE-22366.1.patch, HIVE-22366.2.patch, 
> HIVE-22366.3.patch, HIVE-22366.4.patch, HIVE-22366.5.patch, 
> HIVE-22366.6.patch, HIVE-22366.7.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> e.g. for a simple query like
> {code:sql}
> explain select count(i) from test2 group by j limit 3;
> {code}
> planner makes the following calls:
> {code}
> 2019-10-17T22:44:49,892  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  cmd=get_table : 
> tbl=hive.default.test2
> 2019-10-17T22:44:49,908  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_primary_keys : tbl=hive.default.test2
> 2019-10-17T22:44:49,910  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_foreign_keys : parentdb=null parenttbl=null foreigndb=default 
> foreigntbl=test2
> 2019-10-17T22:44:49,911  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_unique_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,913  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_not_null_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:49,979  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_partitions : tbl=hive.default.test2
> 2019-10-17T22:44:49,997  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_aggr_stats_for: table=hive.default.test2
> 2019-10-17T22:44:50,014  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  cmd=get_table : 
> tbl=hive.default.test2
> 2019-10-17T22:44:50,023  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_primary_keys : tbl=hive.default.test2
> 2019-10-17T22:44:50,024  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_foreign_keys : parentdb=null parenttbl=null foreigndb=default 
> foreigntbl=test2
> 2019-10-17T22:44:50,025  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_unique_constraints : tbl=hive.default.test2
> 2019-10-17T22:44:50,026  INFO [812910d4-bc6a-450c-aa8b-3487b4edceab main] 
> HiveMetaStore.audit: ugi=vgarg  ip=unknown-ip-addr  
> cmd=get_not_null_constraints : tbl=hive.default.test2
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)