[jira] [Work logged] (HIVE-22824) JoinProjectTranspose rule should skip Projects containing windowing expression
[ https://issues.apache.org/jira/browse/HIVE-22824?focusedWorklogId=442153=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442153 ] ASF GitHub Bot logged work on HIVE-22824: - Author: ASF GitHub Bot Created on: 06/Jun/20 00:26 Start Date: 06/Jun/20 00:26 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #897: URL: https://github.com/apache/hive/pull/897#issuecomment-639914267 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442153) Time Spent: 1h (was: 50m) > JoinProjectTranspose rule should skip Projects containing windowing expression > -- > > Key: HIVE-22824 > URL: https://issues.apache.org/jira/browse/HIVE-22824 > Project: Hive > Issue Type: Bug > Components: Query Planning >Affects Versions: 4.0.0 >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22824.1.patch, HIVE-22824.2.patch, > HIVE-22824.3.patch, HIVE-22824.4.patch, HIVE-22824.5.patch, HIVE-22824.6.patch > > Time Spent: 1h > Remaining Estimate: 0h > > Otherwise this rule could end up creating plan with windowing expression > within join condition which hive doesn't know how to process. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22824) JoinProjectTranspose rule should skip Projects containing windowing expression
[ https://issues.apache.org/jira/browse/HIVE-22824?focusedWorklogId=442129=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442129 ] ASF GitHub Bot logged work on HIVE-22824: - Author: ASF GitHub Bot Created on: 06/Jun/20 00:25 Start Date: 06/Jun/20 00:25 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #897: URL: https://github.com/apache/hive/pull/897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442129) Time Spent: 50m (was: 40m) > JoinProjectTranspose rule should skip Projects containing windowing expression > -- > > Key: HIVE-22824 > URL: https://issues.apache.org/jira/browse/HIVE-22824 > Project: Hive > Issue Type: Bug > Components: Query Planning >Affects Versions: 4.0.0 >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22824.1.patch, HIVE-22824.2.patch, > HIVE-22824.3.patch, HIVE-22824.4.patch, HIVE-22824.5.patch, HIVE-22824.6.patch > > Time Spent: 50m > Remaining Estimate: 0h > > Otherwise this rule could end up creating plan with windowing expression > within join condition which hive doesn't know how to process. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22824) JoinProjectTranspose rule should skip Projects containing windowing expression
[
https://issues.apache.org/jira/browse/HIVE-22824?focusedWorklogId=393210=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-393210
]
ASF GitHub Bot logged work on HIVE-22824:
-
Author: ASF GitHub Bot
Created on: 26/Feb/20 07:14
Start Date: 26/Feb/20 07:14
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #897: HIVE-22824:
JoinProjectTranspose rule should skip Projects containing…
URL: https://github.com/apache/hive/pull/897#discussion_r384308354
##
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##
@@ -487,7 +483,7 @@ Operator genOPTree(PlannerContext plannerCtx) throws
SemanticException {
ASTNode newAST = getOptimizedAST(newPlan);
// 1.1. Fix up the query for insert/ctas/materialized views
-newAST = fixUpAfterCbo(this.getAST(), newAST, cboCtx);
Review comment:
ok; after all we want to have cbo on more often than off
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 393210)
Time Spent: 40m (was: 0.5h)
> JoinProjectTranspose rule should skip Projects containing windowing expression
> --
>
> Key: HIVE-22824
> URL: https://issues.apache.org/jira/browse/HIVE-22824
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Affects Versions: 4.0.0
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22824.1.patch, HIVE-22824.2.patch,
> HIVE-22824.3.patch, HIVE-22824.4.patch, HIVE-22824.5.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Otherwise this rule could end up creating plan with windowing expression
> within join condition which hive doesn't know how to process.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22824) JoinProjectTranspose rule should skip Projects containing windowing expression
[
https://issues.apache.org/jira/browse/HIVE-22824?focusedWorklogId=392747=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392747
]
ASF GitHub Bot logged work on HIVE-22824:
-
Author: ASF GitHub Bot
Created on: 25/Feb/20 18:08
Start Date: 25/Feb/20 18:08
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on pull request #897:
HIVE-22824: JoinProjectTranspose rule should skip Projects containing…
URL: https://github.com/apache/hive/pull/897#discussion_r384034467
##
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##
@@ -487,7 +483,7 @@ Operator genOPTree(PlannerContext plannerCtx) throws
SemanticException {
ASTNode newAST = getOptimizedAST(newPlan);
// 1.1. Fix up the query for insert/ctas/materialized views
-newAST = fixUpAfterCbo(this.getAST(), newAST, cboCtx);
Review comment:
@kgyrtkirk The original issue for which HIVE-22578 was opened is being fixed
by HIVE-22824 (this pull request's change). CBO path was failing because
JoinProjectTranspose rule was removing project containing windowing (creating
wrong AST).
Fall to non-cbo path should happen only for queries for which CBO isn't
supported (and that will happed before fixUpAfterCbo). So I believe it is okay
to change AST at this point.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 392747)
Time Spent: 0.5h (was: 20m)
> JoinProjectTranspose rule should skip Projects containing windowing expression
> --
>
> Key: HIVE-22824
> URL: https://issues.apache.org/jira/browse/HIVE-22824
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Affects Versions: 4.0.0
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22824.1.patch, HIVE-22824.2.patch,
> HIVE-22824.3.patch, HIVE-22824.4.patch, HIVE-22824.5.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Otherwise this rule could end up creating plan with windowing expression
> within join condition which hive doesn't know how to process.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22824) JoinProjectTranspose rule should skip Projects containing windowing expression
[
https://issues.apache.org/jira/browse/HIVE-22824?focusedWorklogId=392505=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392505
]
ASF GitHub Bot logged work on HIVE-22824:
-
Author: ASF GitHub Bot
Created on: 25/Feb/20 11:47
Start Date: 25/Feb/20 11:47
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #897: HIVE-22824:
JoinProjectTranspose rule should skip Projects containing…
URL: https://github.com/apache/hive/pull/897#discussion_r383830139
##
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##
@@ -487,7 +483,7 @@ Operator genOPTree(PlannerContext plannerCtx) throws
SemanticException {
ASTNode newAST = getOptimizedAST(newPlan);
// 1.1. Fix up the query for insert/ctas/materialized views
-newAST = fixUpAfterCbo(this.getAST(), newAST, cboCtx);
Review comment:
I don't see how this change will not reintroduce the issue fixed in
HIVE-22578
because the "fixUpAfterCbo" makes calls to a function named replaceASTChild
which changes the actual ast - and it may make it impossible to fallback to the
non-cbo path
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 392505)
Time Spent: 20m (was: 10m)
> JoinProjectTranspose rule should skip Projects containing windowing expression
> --
>
> Key: HIVE-22824
> URL: https://issues.apache.org/jira/browse/HIVE-22824
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Affects Versions: 4.0.0
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22824.1.patch, HIVE-22824.2.patch,
> HIVE-22824.3.patch, HIVE-22824.4.patch, HIVE-22824.5.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Otherwise this rule could end up creating plan with windowing expression
> within join condition which hive doesn't know how to process.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22824) JoinProjectTranspose rule should skip Projects containing windowing expression
[ https://issues.apache.org/jira/browse/HIVE-22824?focusedWorklogId=383045=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383045 ] ASF GitHub Bot logged work on HIVE-22824: - Author: ASF GitHub Bot Created on: 06/Feb/20 18:55 Start Date: 06/Feb/20 18:55 Worklog Time Spent: 10m Work Description: vineetgarg02 commented on pull request #897: HIVE-22824: JoinProjectTranspose rule should skip Projects containing… URL: https://github.com/apache/hive/pull/897 … windowing expression Note that this also reverts HIVE-22790 and HIVE-22578 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383045) Remaining Estimate: 0h Time Spent: 10m > JoinProjectTranspose rule should skip Projects containing windowing expression > -- > > Key: HIVE-22824 > URL: https://issues.apache.org/jira/browse/HIVE-22824 > Project: Hive > Issue Type: Bug > Components: Query Planning >Affects Versions: 4.0.0 >Reporter: Vineet Garg >Assignee: Vineet Garg >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22824.1.patch, HIVE-22824.2.patch, > HIVE-22824.3.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Otherwise this rule could end up creating plan with windowing expression > within join condition which hive doesn't know how to process. -- This message was sent by Atlassian Jira (v8.3.4#803005)
