[jira] [Work logged] (HIVE-22890) Repl load fails if table name contains _function
[
https://issues.apache.org/jira/browse/HIVE-22890?focusedWorklogId=442126=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442126
]
ASF GitHub Bot logged work on HIVE-22890:
-
Author: ASF GitHub Bot
Created on: 06/Jun/20 00:25
Start Date: 06/Jun/20 00:25
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on pull request #913:
URL: https://github.com/apache/hive/pull/913#issuecomment-639914163
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the d...@hive.apache.org list if the patch is in
need of reviews.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 442126)
Time Spent: 50m (was: 40m)
> Repl load fails if table name contains _function
>
>
> Key: HIVE-22890
> URL: https://issues.apache.org/jira/browse/HIVE-22890
> Project: Hive
> Issue Type: Bug
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22890.patch, HIVE-22890.patch, HIVE-22890.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Repl load tries to load function if table name contains _function. Similarly
> for the below contants
> {code:java}
> public static final String FUNCTIONS_ROOT_DIR_NAME = "_functions";
> {code}
> The code just checks for contains(FUNCTIONS_ROOT_DIR_NAME). So even if any
> table or db name contains _functions, it takes the Function Load flow and
> fails.
>
> {code:java}
> org.apache.hadoop.hive.ql.parse.SemanticException: Invalid
> pathorg.apache.hadoop.hive.ql.parse.SemanticException: Invalid path at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:94)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.executeBootStrapLoad(ReplLoadTask.java:238)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.execute(ReplLoadTask.java:110)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:212)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:103)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.TaskRunner.run(TaskRunner.java:82)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT]Caused by:
> java.lang.NullPointerException at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.isFunctionAlreadyLoaded(LoadFunction.java:105)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:81)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] ... 5 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22890) Repl load fails if table name contains _function
[
https://issues.apache.org/jira/browse/HIVE-22890?focusedWorklogId=442136=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442136
]
ASF GitHub Bot logged work on HIVE-22890:
-
Author: ASF GitHub Bot
Created on: 06/Jun/20 00:25
Start Date: 06/Jun/20 00:25
Worklog Time Spent: 10m
Work Description: github-actions[bot] closed pull request #913:
URL: https://github.com/apache/hive/pull/913
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 442136)
Time Spent: 1h (was: 50m)
> Repl load fails if table name contains _function
>
>
> Key: HIVE-22890
> URL: https://issues.apache.org/jira/browse/HIVE-22890
> Project: Hive
> Issue Type: Bug
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22890.patch, HIVE-22890.patch, HIVE-22890.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Repl load tries to load function if table name contains _function. Similarly
> for the below contants
> {code:java}
> public static final String FUNCTIONS_ROOT_DIR_NAME = "_functions";
> {code}
> The code just checks for contains(FUNCTIONS_ROOT_DIR_NAME). So even if any
> table or db name contains _functions, it takes the Function Load flow and
> fails.
>
> {code:java}
> org.apache.hadoop.hive.ql.parse.SemanticException: Invalid
> pathorg.apache.hadoop.hive.ql.parse.SemanticException: Invalid path at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:94)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.executeBootStrapLoad(ReplLoadTask.java:238)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.execute(ReplLoadTask.java:110)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:212)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:103)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.TaskRunner.run(TaskRunner.java:82)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT]Caused by:
> java.lang.NullPointerException at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.isFunctionAlreadyLoaded(LoadFunction.java:105)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:81)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] ... 5 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22890) Repl load fails if table name contains _function
[
https://issues.apache.org/jira/browse/HIVE-22890?focusedWorklogId=388087=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-388087
]
ASF GitHub Bot logged work on HIVE-22890:
-
Author: ASF GitHub Bot
Created on: 16/Feb/20 12:42
Start Date: 16/Feb/20 12:42
Worklog Time Spent: 10m
Work Description: aasha commented on pull request #913: HIVE-22890 Fix
replication of tables with _functions in the tablename
URL: https://github.com/apache/hive/pull/913#discussion_r379900416
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/events/filesystem/DatabaseEventsIterator.java
##
@@ -170,7 +170,7 @@ public BootstrapEvent next() {
}
String currentPath = next.toString();
-if (currentPath.contains(FUNCTIONS_ROOT_DIR_NAME)) {
+if (currentPath.contains(Path.SEPARATOR + FUNCTIONS_ROOT_DIR_NAME)) {
Review comment:
I have added it both before and after now. However we are not allowed to
create tables starting with underscrore (like _functions_t1), gives a parse
exception.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 388087)
Time Spent: 40m (was: 0.5h)
> Repl load fails if table name contains _function
>
>
> Key: HIVE-22890
> URL: https://issues.apache.org/jira/browse/HIVE-22890
> Project: Hive
> Issue Type: Bug
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22890.patch, HIVE-22890.patch, HIVE-22890.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Repl load tries to load function if table name contains _function. Similarly
> for the below contants
> {code:java}
> public static final String FUNCTIONS_ROOT_DIR_NAME = "_functions";
> {code}
> The code just checks for contains(FUNCTIONS_ROOT_DIR_NAME). So even if any
> table or db name contains _functions, it takes the Function Load flow and
> fails.
>
> {code:java}
> org.apache.hadoop.hive.ql.parse.SemanticException: Invalid
> pathorg.apache.hadoop.hive.ql.parse.SemanticException: Invalid path at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:94)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.executeBootStrapLoad(ReplLoadTask.java:238)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.execute(ReplLoadTask.java:110)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:212)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:103)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.TaskRunner.run(TaskRunner.java:82)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT]Caused by:
> java.lang.NullPointerException at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.isFunctionAlreadyLoaded(LoadFunction.java:105)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:81)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] ... 5 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22890) Repl load fails if table name contains _function
[
https://issues.apache.org/jira/browse/HIVE-22890?focusedWorklogId=388086=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-388086
]
ASF GitHub Bot logged work on HIVE-22890:
-
Author: ASF GitHub Bot
Created on: 16/Feb/20 12:41
Start Date: 16/Feb/20 12:41
Worklog Time Spent: 10m
Work Description: aasha commented on pull request #913: HIVE-22890 Fix
replication of tables with _functions in the tablename
URL: https://github.com/apache/hive/pull/913#discussion_r379900416
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/events/filesystem/DatabaseEventsIterator.java
##
@@ -170,7 +170,7 @@ public BootstrapEvent next() {
}
String currentPath = next.toString();
-if (currentPath.contains(FUNCTIONS_ROOT_DIR_NAME)) {
+if (currentPath.contains(Path.SEPARATOR + FUNCTIONS_ROOT_DIR_NAME)) {
Review comment:
I have added it both before and after now. However we are not allowed to
create tables starting with _ in hive (like _functions_t1), gives a parse
exception.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 388086)
Time Spent: 0.5h (was: 20m)
> Repl load fails if table name contains _function
>
>
> Key: HIVE-22890
> URL: https://issues.apache.org/jira/browse/HIVE-22890
> Project: Hive
> Issue Type: Bug
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22890.patch, HIVE-22890.patch, HIVE-22890.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Repl load tries to load function if table name contains _function. Similarly
> for the below contants
> {code:java}
> public static final String FUNCTIONS_ROOT_DIR_NAME = "_functions";
> {code}
> The code just checks for contains(FUNCTIONS_ROOT_DIR_NAME). So even if any
> table or db name contains _functions, it takes the Function Load flow and
> fails.
>
> {code:java}
> org.apache.hadoop.hive.ql.parse.SemanticException: Invalid
> pathorg.apache.hadoop.hive.ql.parse.SemanticException: Invalid path at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:94)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.executeBootStrapLoad(ReplLoadTask.java:238)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.execute(ReplLoadTask.java:110)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:212)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:103)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.TaskRunner.run(TaskRunner.java:82)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT]Caused by:
> java.lang.NullPointerException at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.isFunctionAlreadyLoaded(LoadFunction.java:105)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:81)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] ... 5 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22890) Repl load fails if table name contains _function
[
https://issues.apache.org/jira/browse/HIVE-22890?focusedWorklogId=388080=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-388080
]
ASF GitHub Bot logged work on HIVE-22890:
-
Author: ASF GitHub Bot
Created on: 16/Feb/20 11:39
Start Date: 16/Feb/20 11:39
Worklog Time Spent: 10m
Work Description: maheshk114 commented on pull request #913: HIVE-22890
Fix replication of tables with _functions in the tablename
URL: https://github.com/apache/hive/pull/913#discussion_r379896300
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/events/filesystem/DatabaseEventsIterator.java
##
@@ -170,7 +170,7 @@ public BootstrapEvent next() {
}
String currentPath = next.toString();
-if (currentPath.contains(FUNCTIONS_ROOT_DIR_NAME)) {
+if (currentPath.contains(Path.SEPARATOR + FUNCTIONS_ROOT_DIR_NAME)) {
Review comment:
better to append Path.SEPARATOR after _functions for check
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 388080)
Time Spent: 20m (was: 10m)
> Repl load fails if table name contains _function
>
>
> Key: HIVE-22890
> URL: https://issues.apache.org/jira/browse/HIVE-22890
> Project: Hive
> Issue Type: Bug
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22890.patch, HIVE-22890.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Repl load tries to load function if table name contains _function. Similarly
> for the below contants
> {code:java}
> public static final String FUNCTIONS_ROOT_DIR_NAME = "_functions";
> {code}
> The code just checks for contains(FUNCTIONS_ROOT_DIR_NAME). So even if any
> table or db name contains _functions, it takes the Function Load flow and
> fails.
>
> {code:java}
> org.apache.hadoop.hive.ql.parse.SemanticException: Invalid
> pathorg.apache.hadoop.hive.ql.parse.SemanticException: Invalid path at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:94)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.executeBootStrapLoad(ReplLoadTask.java:238)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.ReplLoadTask.execute(ReplLoadTask.java:110)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:212)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:103)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.TaskRunner.run(TaskRunner.java:82)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT]Caused by:
> java.lang.NullPointerException at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.isFunctionAlreadyLoaded(LoadFunction.java:105)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] at
> org.apache.hadoop.hive.ql.exec.repl.bootstrap.load.LoadFunction.tasks(LoadFunction.java:81)
> ~[hive-exec-3.1.0.3.1.5.1-2.jar:3.1.1000-SNAPSHOT] ... 5 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
