[jira] [Work logged] (HIVE-23722) Show the operation's drilldown link to client
[ https://issues.apache.org/jira/browse/HIVE-23722?focusedWorklogId=453518=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453518 ] ASF GitHub Bot logged work on HIVE-23722: - Author: ASF GitHub Bot Created on: 01/Jul/20 16:42 Start Date: 01/Jul/20 16:42 Worklog Time Spent: 10m Work Description: kgyrtkirk merged pull request #1145: URL: https://github.com/apache/hive/pull/1145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 453518) Time Spent: 1h 40m (was: 1.5h) > Show the operation's drilldown link to client > - > > Key: HIVE-23722 > URL: https://issues.apache.org/jira/browse/HIVE-23722 > Project: Hive > Issue Type: Improvement >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > Now the HiveServer2 webui provides a drilldown link for many collected > metrics or messages about a operation, but it's not easy for a end user to > find the target url of his submitted query. Less knowledge on the deployment, > HA based environment, and the multiple running queries can make things more > difficult. The jira provides a way to show the link to the interested end > user when enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23722) Show the operation's drilldown link to client
[ https://issues.apache.org/jira/browse/HIVE-23722?focusedWorklogId=453376=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453376 ] ASF GitHub Bot logged work on HIVE-23722: - Author: ASF GitHub Bot Created on: 01/Jul/20 11:53 Start Date: 01/Jul/20 11:53 Worklog Time Spent: 10m Work Description: dengzhhu653 edited a comment on pull request #1145: URL: https://github.com/apache/hive/pull/1145#issuecomment-652294571 @kgyrtkirk could you please take another look at the changes? thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 453376) Time Spent: 1.5h (was: 1h 20m) > Show the operation's drilldown link to client > - > > Key: HIVE-23722 > URL: https://issues.apache.org/jira/browse/HIVE-23722 > Project: Hive > Issue Type: Improvement >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > Now the HiveServer2 webui provides a drilldown link for many collected > metrics or messages about a operation, but it's not easy for a end user to > find the target url of his submitted query. Less knowledge on the deployment, > HA based environment, and the multiple running queries can make things more > difficult. The jira provides a way to show the link to the interested end > user when enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23722) Show the operation's drilldown link to client
[ https://issues.apache.org/jira/browse/HIVE-23722?focusedWorklogId=453313=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453313 ] ASF GitHub Bot logged work on HIVE-23722: - Author: ASF GitHub Bot Created on: 01/Jul/20 09:07 Start Date: 01/Jul/20 09:07 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on pull request #1145: URL: https://github.com/apache/hive/pull/1145#issuecomment-652294571 @kgyrtkirk could you take a look at the changes? thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 453313) Time Spent: 1h 20m (was: 1h 10m) > Show the operation's drilldown link to client > - > > Key: HIVE-23722 > URL: https://issues.apache.org/jira/browse/HIVE-23722 > Project: Hive > Issue Type: Improvement >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > Now the HiveServer2 webui provides a drilldown link for many collected > metrics or messages about a operation, but it's not easy for a end user to > find the target url of his submitted query. Less knowledge on the deployment, > HA based environment, and the multiple running queries can make things more > difficult. The jira provides a way to show the link to the interested end > user when enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23722) Show the operation's drilldown link to client
[ https://issues.apache.org/jira/browse/HIVE-23722?focusedWorklogId=448742=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448742 ] ASF GitHub Bot logged work on HIVE-23722: - Author: ASF GitHub Bot Created on: 20/Jun/20 03:39 Start Date: 20/Jun/20 03:39 Worklog Time Spent: 10m Work Description: dengzhhu653 opened a new pull request #1145: URL: https://github.com/apache/hive/pull/1145 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. HIVE-X: Fix a typo in YYY) For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 448742) Time Spent: 1h 10m (was: 1h) > Show the operation's drilldown link to client > - > > Key: HIVE-23722 > URL: https://issues.apache.org/jira/browse/HIVE-23722 > Project: Hive > Issue Type: Improvement >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > Now the HiveServer2 webui provides a drilldown link for many collected > metrics or messages about a operation, but it's not easy for a end user to > find the target url of his submitted query. Less knowledge on the deployment, > HA based environment, and the multiple running queries can make things more > difficult. The jira provides a way to show the link to the interested end > user when enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23722) Show the operation's drilldown link to client
[ https://issues.apache.org/jira/browse/HIVE-23722?focusedWorklogId=448740=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448740 ] ASF GitHub Bot logged work on HIVE-23722: - Author: ASF GitHub Bot Created on: 20/Jun/20 03:32 Start Date: 20/Jun/20 03:32 Worklog Time Spent: 10m Work Description: dengzhhu653 closed pull request #1145: URL: https://github.com/apache/hive/pull/1145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 448740) Time Spent: 1h (was: 50m) > Show the operation's drilldown link to client > - > > Key: HIVE-23722 > URL: https://issues.apache.org/jira/browse/HIVE-23722 > Project: Hive > Issue Type: Improvement >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Now the HiveServer2 webui provides a drilldown link for many collected > metrics or messages about a operation, but it's not easy for a end user to > find the target url of his submitted query. Less knowledge on the deployment, > HA based environment, and the multiple running queries can make things more > difficult. The jira provides a way to show the link to the interested end > user when enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23722) Show the operation's drilldown link to client
[
https://issues.apache.org/jira/browse/HIVE-23722?focusedWorklogId=448524=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448524
]
ASF GitHub Bot logged work on HIVE-23722:
-
Author: ASF GitHub Bot
Created on: 19/Jun/20 14:55
Start Date: 19/Jun/20 14:55
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1145:
URL: https://github.com/apache/hive/pull/1145#discussion_r442887474
##
File path:
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##
@@ -569,7 +569,19 @@ public TExecuteStatementResp
ExecuteStatement(TExecuteStatementReq req) throws T
queryTimeout) : cliService.executeStatement(sessionHandle,
statement, confOverlay,
queryTimeout);
resp.setOperationHandle(operationHandle.toTOperationHandle());
- resp.setStatus(OK_STATUS);
+ Operation operation =
cliService.getSessionManager().getOperationManager()
+ .getOperation(operationHandle);
+ if (operation.showOperationDrilldownLink() &&
cliService.getHiveServer2().getWebServerUrl() != null) {
Review comment:
CliService defines the executeStatement returning OperationHandle, which
has little relationship with thrift interface/definition. It's may not nice to
wrap the thrift message here. Thanks for the review, @kgyrtkirk!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 448524)
Time Spent: 50m (was: 40m)
> Show the operation's drilldown link to client
> -
>
> Key: HIVE-23722
> URL: https://issues.apache.org/jira/browse/HIVE-23722
> Project: Hive
> Issue Type: Improvement
>Reporter: Zhihua Deng
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Now the HiveServer2 webui provides a drilldown link for many collected
> metrics or messages about a operation, but it's not easy for a end user to
> find the target url of his submitted query. Less knowledge on the deployment,
> HA based environment, and the multiple running queries can make things more
> difficult. The jira provides a way to show the link to the interested end
> user when enabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23722) Show the operation's drilldown link to client
[
https://issues.apache.org/jira/browse/HIVE-23722?focusedWorklogId=448521=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448521
]
ASF GitHub Bot logged work on HIVE-23722:
-
Author: ASF GitHub Bot
Created on: 19/Jun/20 14:46
Start Date: 19/Jun/20 14:46
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1145:
URL: https://github.com/apache/hive/pull/1145#discussion_r442882603
##
File path: service/src/java/org/apache/hive/service/cli/CLIService.java
##
@@ -149,6 +149,10 @@ public UserGroupInformation getHttpUGI() {
return this.httpUGI;
}
+ public HiveServer2 getHiveServer2() {
Review comment:
yes, thank you for your good advice, @kgyrtkirk!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 448521)
Time Spent: 40m (was: 0.5h)
> Show the operation's drilldown link to client
> -
>
> Key: HIVE-23722
> URL: https://issues.apache.org/jira/browse/HIVE-23722
> Project: Hive
> Issue Type: Improvement
>Reporter: Zhihua Deng
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Now the HiveServer2 webui provides a drilldown link for many collected
> metrics or messages about a operation, but it's not easy for a end user to
> find the target url of his submitted query. Less knowledge on the deployment,
> HA based environment, and the multiple running queries can make things more
> difficult. The jira provides a way to show the link to the interested end
> user when enabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23722) Show the operation's drilldown link to client
[
https://issues.apache.org/jira/browse/HIVE-23722?focusedWorklogId=448520=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448520
]
ASF GitHub Bot logged work on HIVE-23722:
-
Author: ASF GitHub Bot
Created on: 19/Jun/20 14:43
Start Date: 19/Jun/20 14:43
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1145:
URL: https://github.com/apache/hive/pull/1145#discussion_r442881152
##
File path: service/src/java/org/apache/hive/service/cli/operation/Operation.java
##
@@ -452,4 +452,8 @@ public String getQueryTag() {
public String getQueryId() {
return queryState.getQueryId();
}
+
+ public boolean showOperationDrilldownLink() {
Review comment:
Nice find, perhaps I can move the check to the OperationManager.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 448520)
Time Spent: 0.5h (was: 20m)
> Show the operation's drilldown link to client
> -
>
> Key: HIVE-23722
> URL: https://issues.apache.org/jira/browse/HIVE-23722
> Project: Hive
> Issue Type: Improvement
>Reporter: Zhihua Deng
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Now the HiveServer2 webui provides a drilldown link for many collected
> metrics or messages about a operation, but it's not easy for a end user to
> find the target url of his submitted query. Less knowledge on the deployment,
> HA based environment, and the multiple running queries can make things more
> difficult. The jira provides a way to show the link to the interested end
> user when enabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23722) Show the operation's drilldown link to client
[
https://issues.apache.org/jira/browse/HIVE-23722?focusedWorklogId=448481=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448481
]
ASF GitHub Bot logged work on HIVE-23722:
-
Author: ASF GitHub Bot
Created on: 19/Jun/20 13:43
Start Date: 19/Jun/20 13:43
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #1145:
URL: https://github.com/apache/hive/pull/1145#discussion_r442838789
##
File path: service/src/java/org/apache/hive/service/cli/operation/Operation.java
##
@@ -452,4 +452,8 @@ public String getQueryTag() {
public String getQueryId() {
return queryState.getQueryId();
}
+
+ public boolean showOperationDrilldownLink() {
Review comment:
I don't feel that this method should be closely connected to this
interface
##
File path: service/src/java/org/apache/hive/service/cli/CLIService.java
##
@@ -149,6 +149,10 @@ public UserGroupInformation getHttpUGI() {
return this.httpUGI;
}
+ public HiveServer2 getHiveServer2() {
Review comment:
instead of giving access to the HiveServer2 object: how about a method
like `getWebServerUrl()` ?
##
File path:
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
##
@@ -569,7 +569,19 @@ public TExecuteStatementResp
ExecuteStatement(TExecuteStatementReq req) throws T
queryTimeout) : cliService.executeStatement(sessionHandle,
statement, confOverlay,
queryTimeout);
resp.setOperationHandle(operationHandle.toTOperationHandle());
- resp.setStatus(OK_STATUS);
+ Operation operation =
cliService.getSessionManager().getOperationManager()
+ .getOperation(operationHandle);
+ if (operation.showOperationDrilldownLink() &&
cliService.getHiveServer2().getWebServerUrl() != null) {
Review comment:
I think this should be moved to somewhere around
`CliService#executeStatement`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 448481)
Time Spent: 20m (was: 10m)
> Show the operation's drilldown link to client
> -
>
> Key: HIVE-23722
> URL: https://issues.apache.org/jira/browse/HIVE-23722
> Project: Hive
> Issue Type: Improvement
>Reporter: Zhihua Deng
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Now the HiveServer2 webui provides a drilldown link for many collected
> metrics or messages about a operation, but it's not easy for a end user to
> find the target url of his submitted query. Less knowledge on the deployment,
> HA based environment, and the multiple running queries can make things more
> difficult. The jira provides a way to show the link to the interested end
> user when enabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
