[jira] [Work logged] (HIVE-24091) Replace multiple constraints call with getAllTableConstraints api call in query planner

2020-09-02 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24091?focusedWorklogId=477859=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-477859
 ]

ASF GitHub Bot logged work on HIVE-24091:
-

Author: ASF GitHub Bot
Created on: 02/Sep/20 13:30
Start Date: 02/Sep/20 13:30
Worklog Time Spent: 10m 
  Work Description: ashish-kumar-sharma closed pull request #1444:
URL: https://github.com/apache/hive/pull/1444


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 477859)
Time Spent: 50m  (was: 40m)

> Replace multiple constraints call with getAllTableConstraints api call in 
> query planner
> ---
>
> Key: HIVE-24091
> URL: https://issues.apache.org/jira/browse/HIVE-24091
> Project: Hive
>  Issue Type: Improvement
>Reporter: Ashish Sharma
>Assignee: Ashish Sharma
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Inorder get all the constraints of table i.e. PrimaryKey, ForeignKey, 
> UniqueConstraint ,NotNullConstraint ,DefaultConstraint ,CheckConstraint. We 
> have to do 6 different metastore call. Replace these call with one  
> getAllTableConstraints  api which provide all the constraints at once



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-24091) Replace multiple constraints call with getAllTableConstraints api call in query planner

2020-09-02 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24091?focusedWorklogId=477858=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-477858
 ]

ASF GitHub Bot logged work on HIVE-24091:
-

Author: ASF GitHub Bot
Created on: 02/Sep/20 13:30
Start Date: 02/Sep/20 13:30
Worklog Time Spent: 10m 
  Work Description: ashish-kumar-sharma commented on pull request #1444:
URL: https://github.com/apache/hive/pull/1444#issuecomment-685738116


   Merged in PR-1419



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 477858)
Time Spent: 40m  (was: 0.5h)

> Replace multiple constraints call with getAllTableConstraints api call in 
> query planner
> ---
>
> Key: HIVE-24091
> URL: https://issues.apache.org/jira/browse/HIVE-24091
> Project: Hive
>  Issue Type: Improvement
>Reporter: Ashish Sharma
>Assignee: Ashish Sharma
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Inorder get all the constraints of table i.e. PrimaryKey, ForeignKey, 
> UniqueConstraint ,NotNullConstraint ,DefaultConstraint ,CheckConstraint. We 
> have to do 6 different metastore call. Replace these call with one  
> getAllTableConstraints  api which provide all the constraints at once



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-24091) Replace multiple constraints call with getAllTableConstraints api call in query planner

2020-08-31 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24091?focusedWorklogId=476391=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476391
 ]

ASF GitHub Bot logged work on HIVE-24091:
-

Author: ASF GitHub Bot
Created on: 31/Aug/20 07:24
Start Date: 31/Aug/20 07:24
Worklog Time Spent: 10m 
  Work Description: adesh-rao commented on a change in pull request #1444:
URL: https://github.com/apache/hive/pull/1444#discussion_r479944470



##
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##
@@ -5682,163 +5684,65 @@ public void dropConstraint(String dbName, String 
tableName, String constraintNam
 }
   }
 
-  /**
-   * Get all primary key columns associated with the table.
-   *
-   * @param dbName Database Name
-   * @param tblName Table Name
-   * @return Primary Key associated with the table.
-   * @throws HiveException
-   */
-  public PrimaryKeyInfo getPrimaryKeys(String dbName, String tblName) throws 
HiveException {
-return getPrimaryKeys(dbName, tblName, false);
-  }
-
-  /**
-   * Get primary key columns associated with the table that are available for 
optimization.
-   *
-   * @param dbName Database Name
-   * @param tblName Table Name
-   * @return Primary Key associated with the table.
-   * @throws HiveException
-   */
-  public PrimaryKeyInfo getReliablePrimaryKeys(String dbName, String tblName) 
throws HiveException {
-return getPrimaryKeys(dbName, tblName, true);
-  }
-
-  private PrimaryKeyInfo getPrimaryKeys(String dbName, String tblName, boolean 
onlyReliable)
-  throws HiveException {
-PerfLogger perfLogger = SessionState.getPerfLogger();
-perfLogger.perfLogBegin(CLASS_NAME, PerfLogger.HIVE_GET_PK);
-try {
-  List primaryKeys = getMSC().getPrimaryKeys(new 
PrimaryKeysRequest(dbName, tblName));
-  if (onlyReliable && primaryKeys != null && !primaryKeys.isEmpty()) {

Review comment:
   nvm. Got it.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 476391)
Time Spent: 0.5h  (was: 20m)

> Replace multiple constraints call with getAllTableConstraints api call in 
> query planner
> ---
>
> Key: HIVE-24091
> URL: https://issues.apache.org/jira/browse/HIVE-24091
> Project: Hive
>  Issue Type: Improvement
>Reporter: Ashish Sharma
>Assignee: Ashish Sharma
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Inorder get all the constraints of table i.e. PrimaryKey, ForeignKey, 
> UniqueConstraint ,NotNullConstraint ,DefaultConstraint ,CheckConstraint. We 
> have to do 6 different metastore call. Replace these call with one  
> getAllTableConstraints  api which provide all the constraints at once



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-24091) Replace multiple constraints call with getAllTableConstraints api call in query planner

2020-08-31 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24091?focusedWorklogId=476390=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476390
 ]

ASF GitHub Bot logged work on HIVE-24091:
-

Author: ASF GitHub Bot
Created on: 31/Aug/20 07:23
Start Date: 31/Aug/20 07:23
Worklog Time Spent: 10m 
  Work Description: adesh-rao commented on a change in pull request #1444:
URL: https://github.com/apache/hive/pull/1444#discussion_r479944166



##
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##
@@ -5682,163 +5684,65 @@ public void dropConstraint(String dbName, String 
tableName, String constraintNam
 }
   }
 
-  /**
-   * Get all primary key columns associated with the table.
-   *
-   * @param dbName Database Name
-   * @param tblName Table Name
-   * @return Primary Key associated with the table.
-   * @throws HiveException
-   */
-  public PrimaryKeyInfo getPrimaryKeys(String dbName, String tblName) throws 
HiveException {
-return getPrimaryKeys(dbName, tblName, false);
-  }
-
-  /**
-   * Get primary key columns associated with the table that are available for 
optimization.
-   *
-   * @param dbName Database Name
-   * @param tblName Table Name
-   * @return Primary Key associated with the table.
-   * @throws HiveException
-   */
-  public PrimaryKeyInfo getReliablePrimaryKeys(String dbName, String tblName) 
throws HiveException {
-return getPrimaryKeys(dbName, tblName, true);
-  }
-
-  private PrimaryKeyInfo getPrimaryKeys(String dbName, String tblName, boolean 
onlyReliable)
-  throws HiveException {
-PerfLogger perfLogger = SessionState.getPerfLogger();
-perfLogger.perfLogBegin(CLASS_NAME, PerfLogger.HIVE_GET_PK);
-try {
-  List primaryKeys = getMSC().getPrimaryKeys(new 
PrimaryKeysRequest(dbName, tblName));
-  if (onlyReliable && primaryKeys != null && !primaryKeys.isEmpty()) {

Review comment:
   Is this being taken care of in getAllTableConstraints?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 476390)
Time Spent: 20m  (was: 10m)

> Replace multiple constraints call with getAllTableConstraints api call in 
> query planner
> ---
>
> Key: HIVE-24091
> URL: https://issues.apache.org/jira/browse/HIVE-24091
> Project: Hive
>  Issue Type: Improvement
>Reporter: Ashish Sharma
>Assignee: Ashish Sharma
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Inorder get all the constraints of table i.e. PrimaryKey, ForeignKey, 
> UniqueConstraint ,NotNullConstraint ,DefaultConstraint ,CheckConstraint. We 
> have to do 6 different metastore call. Replace these call with one  
> getAllTableConstraints  api which provide all the constraints at once



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-24091) Replace multiple constraints call with getAllTableConstraints api call in query planner

2020-08-30 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24091?focusedWorklogId=476272=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476272
 ]

ASF GitHub Bot logged work on HIVE-24091:
-

Author: ASF GitHub Bot
Created on: 30/Aug/20 18:03
Start Date: 30/Aug/20 18:03
Worklog Time Spent: 10m 
  Work Description: ashish-kumar-sharma opened a new pull request #1444:
URL: https://github.com/apache/hive/pull/1444


   
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 476272)
Remaining Estimate: 0h
Time Spent: 10m

> Replace multiple constraints call with getAllTableConstraints api call in 
> query planner
> ---
>
> Key: HIVE-24091
> URL: https://issues.apache.org/jira/browse/HIVE-24091
> Project: Hive
>  Issue Type: Improvement
>Reporter: Ashish Sharma
>Assignee: Ashish Sharma
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Inorder get all the constraints of table i.e. PrimaryKey, ForeignKey, 
> UniqueConstraint ,NotNullConstraint ,DefaultConstraint ,CheckConstraint. We 
> have to do 6 different metastore call. Replace these call with one  
> getAllTableConstraints  api which provide all the constraints at once



--
This message was sent by Atlassian Jira
(v8.3.4#803005)