[GitHub] incubator-hivemall issue #149: [HIVEMALL-201] Evaluate, fix and document FFM

2018-05-30 Thread takuti
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/149 @myui Documentation and system tests on my laptop/EMR have been conducted, and I'm now ready for review. Could you look more deeply into the updates for merge? ---

[GitHub] incubator-hivemall issue #149: [HIVEMALL-201] Evaluate, fix and document FFM

2018-05-30 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/149 @takuti Sure. ---

[GitHub] incubator-hivemall pull request #149: [WIP][HIVEMALL-201] Evaluate, fix and ...

2018-05-30 Thread takuti
Github user takuti commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/149#discussion_r191694422 --- Diff: core/src/test/java/hivemall/fm/FieldAwareFactorizationMachineUDTFTest.java --- @@ -256,6 +256,19 @@ public void testEarlyStopping()