[GitHub] incubator-hivemall issue #35: [HIVEMALL-31][SPARK] Support Spark-v2.1.0

2017-01-31 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/35 @maropu test is failing for v2.1. ``` Saving to outputFile=/home/travis/build/apache/incubator-hivemall/spark/spark-common/target/scalastyle-output.xml Processed 3 file(s

[GitHub] incubator-hivemall issue #35: [HIVEMALL-31][SPARK] Support Spark-v2.1.0

2017-01-31 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/35 BTW, you can close https://github.com/apache/incubator-hivemall/pull/23 as well. `Close #35, #23: ` --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-hivemall issue #37: [HIVEMALL-47][SPARK] Support codegen for top-K...

2017-02-06 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/37 Benchmark on more large dataset would be helpful (not to be included the unit test though). --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-hivemall issue #36: [Spark] Update gitbook for top_k_join

2017-02-04 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/36 Fixed in https://github.com/apache/incubator-hivemall/commit/fdb4dd86965f8b79f6dc257a783e683c93fadc43 It's required for gitbook menu http://hivemall.incubator.apache.org/userguide

[GitHub] incubator-hivemall issue #41: [HIVEMALL-54][SPARK] Add an easy-to-use script...

2017-02-08 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/41 @amaya382 @Lewuathe Could you confirm that the updated `bin/spark-shell` properly works if your spare time? --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-hivemall issue #42: [HIVEMALL-38][SPARK] Support ChangeFinderUDF i...

2017-02-08 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/42 BTW, documentation about sst/changefinder on dataframe would be helpful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-hivemall issue #42: [HIVEMALL-38][SPARK] Support ChangeFinderUDF i...

2017-02-08 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/42 @maropu LGTM. Could you merge and close this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hivemall issue #41: [HIVEMALL-54][SPARK] Add an easy-to-use script...

2017-02-08 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/41 @maropu BTW, better to update `incubator-hivemall-site` once this PR is merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-hivemall issue #37: [HIVEMALL-47][SPARK] Support codegen for top-K...

2017-02-06 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/37 @maropu LGTM. Please merge this PR and close the ticket as fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-hivemall issue #22: [HIVEMALL-30] Increase -Xmx to 1536 to avoid O...

2017-01-22 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/22 @maropu Could you take a look at? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hivemall issue #22: [HIVEMALL-30] Increase -Xmx to -Xmx1536m to av...

2017-01-22 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/22 @wangyum @maropu Thanks. Merged with some modifications. Configuration for spark-1.6 should also be changed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-hivemall issue #24: [HIVEMALL-32] Print explicit error messages in...

2017-01-23 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/24 LGTM. Could you update ASF master as follows: ``` git checkout master git checkout -b CheckCompiler git pull https://github.com/maropu/incubator-hivemall.git hotfix

[GitHub] incubator-hivemall issue #31: [HIVEMALL-40] Load xgboost-formatted data via ...

2017-01-26 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/31 LGTM. Please merge and close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hivemall issue #30: [HIVEMALL-37] Support a SST-based change-point...

2017-01-26 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/30 @maropu Could you add [SPARK] after [HIVEMALL-37] in the title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-hivemall issue #33: [HIVEMALL-44][SAPRK] Implement a prototype of ...

2017-01-30 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/33 output `top1Df` should be explained in the description. BTW, I personally prefer `top_k_join` instead of `join_top_k`. --- If your project is set up for it, you can reply

[GitHub] incubator-hivemall issue #34: [HIVEMALL-45][SPARK] Upgrade spark v2.0.0 to v...

2017-01-30 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/34 @maropu LGTM. Please merge this PR and close the corresponding JIRA ticket as fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-hivemall issue #25: [HIVEMALL-34] Fix a bug to wrongly use mllib v...

2017-01-25 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/25 @maropu LGTM. Please merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hivemall issue #26: [HIVEMALL-35] Remove unnecessary implicit conv...

2017-01-25 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/26 @maropu LGTM. Please merge this PR and close JIRA issue as fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97715714 --- Diff: core/src/main/java/hivemall/model/NewDenseModel.java --- @@ -0,0 +1,293 @@ +/* + * Hivemall: Hive scalable Machine Learning Library

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97726633 --- Diff: core/src/main/java/hivemall/optimizer/Optimizer.java --- @@ -0,0 +1,246 @@ +/* + * Hivemall: Hive scalable Machine Learning Library

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97936571 --- Diff: core/src/main/java/hivemall/optimizer/Optimizer.java --- @@ -0,0 +1,246 @@ +/* + * Hivemall: Hive scalable Machine Learning Library

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97724411 --- Diff: core/src/main/java/hivemall/classifier/GeneralClassifierUDTF.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97716028 --- Diff: core/src/main/java/hivemall/model/NewDenseModel.java --- @@ -0,0 +1,293 @@ +/* + * Hivemall: Hive scalable Machine Learning Library

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97722648 --- Diff: core/src/main/java/hivemall/optimizer/EtaEstimator.java --- @@ -157,4 +158,34 @@ public static EtaEstimator get(@Nullable CommandLine cl

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97715666 --- Diff: core/src/main/java/hivemall/classifier/GeneralClassifierUDTF.java --- @@ -0,0 +1,122 @@ +/* + * Hivemall: Hive scalable Machine

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97934044 --- Diff: core/src/main/java/hivemall/optimizer/Optimizer.java --- @@ -0,0 +1,246 @@ +/* + * Hivemall: Hive scalable Machine Learning Library

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97716142 --- Diff: core/src/main/java/hivemall/model/NewDenseModel.java --- @@ -0,0 +1,293 @@ +/* + * Hivemall: Hive scalable Machine Learning Library

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97716349 --- Diff: core/src/main/java/hivemall/model/NewSpaceEfficientDenseModel.java --- @@ -0,0 +1,317 @@ +/* + * Hivemall: Hive scalable Machine

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97937226 --- Diff: core/src/main/java/hivemall/optimizer/Regularization.java --- @@ -0,0 +1,99 @@ +/* + * Hivemall: Hive scalable Machine Learning

[GitHub] incubator-hivemall pull request #14: [WIP] Separate optimizer implementation...

2017-01-25 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/14#discussion_r97715621 --- Diff: core/src/main/java/hivemall/model/NewSpaceEfficientDenseModel.java --- @@ -0,0 +1,317 @@ +/* + * Hivemall: Hive scalable Machine

[GitHub] incubator-hivemall issue #14: [WIP] Separate optimizer implementations

2017-01-25 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/14 LossFunction should be selectable, not fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hivemall issue #27: [HIVEMALL-36] Refactor each_top_k

2017-01-25 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/27 @maropu LGTM. Please merge this PR and close the JIRA ticket. BTW, `HiveUdfWithFeatureSuite` causes OOM again. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-hivemall issue #28: [HIVEMALL-30] Temporarily ignore a streaming t...

2017-01-26 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/28 @maropu LGTM. Please merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hivemall issue #29: [HIVEMALL-39][SPARK] Put the use of HiveUDFs i...

2017-01-26 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/29 @maropu LGTM. Please merge and close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hivemall issue #46: [HIVEMALL-72] Fix corner-case rescale UDF beha...

2017-02-15 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/46 Oops.. the latter one is expected. ```sql select rescale(4.2,1.0,3.0),rescale(-0.3, 1.0, 3.0); > 3.0 1.0 select rescale(4.2,1.0,3.0),rescale(-0.3, 1.0,

[GitHub] incubator-hivemall pull request #46: [HIVEMALL-72] Fix rescale UDF behavior ...

2017-02-15 Thread myui
GitHub user myui opened a pull request: https://github.com/apache/incubator-hivemall/pull/46 [HIVEMALL-72] Fix rescale UDF behavior to return range [0.0,1.0] ## What changes were proposed in this pull request? Fix rescale UDF behavior to return range `[0.0,1.0

[GitHub] incubator-hivemall issue #45: [HIVEMALL-71] Handle null values and add a uni...

2017-02-15 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/45 @wangyum Thanks. Merged with some modifications. ```sql select rescale(v,min,max) from ( select cast(1.2 as float) as v, 1.0 as min, 10.0 as max union all

[GitHub] incubator-hivemall issue #46: [HIVEMALL-72] Fix corner-case rescale UDF beha...

2017-02-15 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/46 @wangyum Are you agree with the following new behavior of [rescale(value,min,max)](https://en.wikipedia.org/wiki/Feature_scaling#Rescaling)? ``` -- new select rescale

[GitHub] incubator-hivemall issue #47: [HIVEMALL-73] Reduce memory usages of each_top...

2017-02-16 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/47 @maropu Could you review this PR? This PR resolves OOM in drainQueue where `k` is very large. ``` 2017-02-16 05:56:22,378 FATAL [Thread-4

[GitHub] incubator-hivemall pull request #47: [HIVEMALL-73] Reduce memory usages of e...

2017-02-16 Thread myui
GitHub user myui opened a pull request: https://github.com/apache/incubator-hivemall/pull/47 [HIVEMALL-73] Reduce memory usages of each_top_k ## What changes were proposed in this pull request? Reduce memory usage of each_top_k ## What type of PR

[GitHub] incubator-hivemall issue #50: [HIVEMALL-80] Fix incorrect typeInfo checks in...

2017-02-23 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/50 @takuti LGTM. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-hivemall pull request #51: [WIP][HIVEMALL-75] Support Sparse Vecto...

2017-02-24 Thread myui
GitHub user myui opened a pull request: https://github.com/apache/incubator-hivemall/pull/51 [WIP][HIVEMALL-75] Support Sparse Vector Format as the input of RandomForest ## What changes were proposed in this pull request? Supported sparse vector as the input of RandomForest

[GitHub] incubator-hivemall issue #49: [HIVEMALL-26][SPARK] Make docs for regression ...

2017-02-23 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/49 @maropu Thanks. LGTM. Merged w/ modifications. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hivemall issue #48: [HIVEMALL-77] Support CSRMatrix and DenseMatri...

2017-02-23 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/48 Merged because this PR is a blocker for https://issues.apache.org/jira/browse/HIVEMALL-75 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-hivemall issue #49: [HIVEMALL-26][SPARK] Make docs for regression ...

2017-02-23 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/49 Update the project site http://hivemall.incubator.apache.org/userguide/spark/binaryclass/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-hivemall issue #49: [HIVEMALL-26][SPARK] Make docs for regression ...

2017-02-23 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/49 @maropu you need to update `SUMMARY.md` as well for `bin/build_site.sh`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-hivemall pull request #47: [WIP][HIVEMALL-73] Reduce memory usages...

2017-02-19 Thread myui
Github user myui closed the pull request at: https://github.com/apache/incubator-hivemall/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hivemall pull request #48: [WIP][HIVEMALL-77]

2017-02-22 Thread myui
GitHub user myui opened a pull request: https://github.com/apache/incubator-hivemall/pull/48 [WIP][HIVEMALL-77] ## What changes were proposed in this pull request? Support CSRMatrix and DenseMatrix in hivemall.matrix package. ## What type of PR

[GitHub] incubator-hivemall issue #48: [WIP][HIVEMALL-77] Support CSRMatrix and Dense...

2017-02-23 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/48 @maropu Could you review this PR? It might be [an interesting topic](http://www.cs.colostate.edu/~mcrob/toolbox/c++/sparseMatrix/sparse_matrix_compression.html) for you :-) --- If your

[GitHub] incubator-hivemall issue #45: [HIVEMALL-71] Handle null values and add a uni...

2017-02-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/45 Thanks, I will take this PR on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 @maropu Could you merge this PR? `import-packages.spark` should be another ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-hivemall issue #41: [HIVEMALL-54][SPARK] Add an easy-to-use script...

2017-02-10 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/41 @maropu Could you update `incubator-hivemall-site`? This feature should be documented. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 @maropu You can use Reflections. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hivemall pull request #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/44#discussion_r100726042 --- Diff: resources/ddl/define-all.spark --- @@ -83,15 +101,15 @@ sqlContext.sql("CREATE TEMPORARY FUNCTION distance2similarity AS 'hivemall.

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 LGTM. @maropu merge this one if @amaya382 says fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 @maropu you can revise taskid heneration scheme. http://stackoverflow.com/questions/31631791/how-to-get-id-of-a-map-task-in-spark --- If your project is set up for it, you can reply

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 @amaya382 what kind of imports are missing in `import-packages.spark` ? (cc: @maropu ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-hivemall issue #41: [HIVEMALL-54][SPARK] Add an easy-to-use script...

2017-02-10 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/41 @amaya382 Have you confirmed? @maropu please merge this PR if he say fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark and impo...

2017-02-15 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 @wangyum Merged. Thank you for your contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hivemall issue #47: [WIP][HIVEMALL-73] Reduce memory usages of eac...

2017-02-17 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/47 Oops. This PR contains a bug. Reverse order to `_queue.poll()` is required for the output. ``` for (int i = queueSize - 1; i >= 0; i--) { TupleWithKey tuple = tuple

[GitHub] incubator-hivemall issue #47: [WIP][HIVEMALL-73] Reduce memory usages of eac...

2017-02-17 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/47 hmm... hard to cope w/ this issue. Any good idea? @maropu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-hivemall issue #47: [WIP][HIVEMALL-73] Reduce memory usages of eac...

2017-02-17 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/47 @maropu I found that `each_top_k` behavior on Spark is little bit difference one from Hive for the ranking scheme in https://github.com/apache/incubator-hivemall/blob/master/core/src

[GitHub] incubator-hivemall issue #20: [HIVEMALL-28] Set HIVEMALL_HOME to absolute pa...

2017-01-19 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/20 @wangyum Thank you for the contribution. @maropu Could you review this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-hivemall pull request #52: [HIVEMALL-78] Implement AUC UDAF for bi...

2017-02-27 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/52#discussion_r103388346 --- Diff: core/src/main/java/hivemall/evaluation/AUCUDAF.java --- @@ -49,35 +50,251 @@ @SuppressWarnings("deprecation") @D

[GitHub] incubator-hivemall pull request #52: [HIVEMALL-78] Implement AUC UDAF for bi...

2017-02-27 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/52#discussion_r103387903 --- Diff: core/src/main/java/hivemall/evaluation/AUCUDAF.java --- @@ -49,35 +50,251 @@ @SuppressWarnings("deprecation") @D

[GitHub] incubator-hivemall pull request #52: [HIVEMALL-78] Implement AUC UDAF for bi...

2017-02-27 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/52#discussion_r103386937 --- Diff: core/src/test/java/hivemall/evaluation/AUCUDAFTest.java --- @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] incubator-hivemall pull request #52: [HIVEMALL-78] Implement AUC UDAF for bi...

2017-02-28 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/52#discussion_r103402140 --- Diff: core/src/main/java/hivemall/evaluation/AUCUDAF.java --- @@ -49,35 +51,264 @@ @SuppressWarnings("deprecation") @D

[GitHub] incubator-hivemall pull request #52: [HIVEMALL-78] Implement AUC UDAF for bi...

2017-02-28 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/52#discussion_r103403546 --- Diff: docs/gitbook/eval/auc.md --- @@ -0,0 +1,102 @@ + + + + +# Area Under the ROC Curve + +[ROC curve](https

[GitHub] incubator-hivemall pull request #52: [HIVEMALL-78] Implement AUC UDAF for bi...

2017-02-28 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/52#discussion_r103403903 --- Diff: core/src/main/java/hivemall/evaluation/AUCUDAF.java --- @@ -49,35 +51,264 @@ @SuppressWarnings("deprecation") @D

[GitHub] incubator-hivemall pull request #52: [HIVEMALL-78] Implement AUC UDAF for bi...

2017-02-28 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/52#discussion_r103402767 --- Diff: docs/gitbook/eval/auc.md --- @@ -0,0 +1,102 @@ + + + + +# Area Under the ROC Curve + +[ROC curve](https

[GitHub] incubator-hivemall issue #52: [HIVEMALL-78] Implement AUC UDAF for binary cl...

2017-02-28 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/52 LGTM. Merged. Thank you so much for a big contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hivemall issue #56: [HIVEMALL-83][Bug] Fix wrong getV() arg on ffm...

2017-03-01 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/56 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hivemall issue #53: [HIVEMALL-82] Add ranking measures to ddl

2017-03-01 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/53 LGTM 👍 Thank you for the contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hivemall issue #42: [HIVEMALL-38][SPARK] Support ChangeFinderUDF i...

2017-03-01 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/42 @maropu sure. Merged! Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hivemall issue #54: [HIVEMALL-76][SPARK] Fix worng ranks in top-K ...

2017-03-02 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/54 @maropu Merged. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-hivemall issue #51: [HIVEMALL-75] Support Sparse Vector Format as ...

2017-03-23 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/51 Need to sync with the current Smile's up-to-date prediction scheme for the better accuracy. https://github.com/haifengl/smile/commit/444d8bb916379f4d53d87be9ae1071aebcaab76d

[GitHub] incubator-hivemall issue #65: [HIVEMALL-93] Fix typo which creates an incorr...

2017-03-24 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/65 Thanks. Merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-hivemall issue #64: [HIVEMALL-92] Fix typos in UDAFToOrderedMap

2017-03-24 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/64 LGTM. Merged. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-hivemall issue #62: [HIVEMALL-89][SQL] Support to_from/from_csv in...

2017-03-16 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/62 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hivemall issue #51: [HIVEMALL-75] Support Sparse Vector Format as ...

2017-03-22 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/51 Refactored to use `RoaringBitmap` and `IntReservoirSampler`. ![d520699f0e299405e577936273ac14c3](https://cloud.githubusercontent.com/assets/1163783/24198255/7a527ad2-0f48-11e7-9508

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109558479 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,497 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109558215 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,497 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109558520 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAUDTF.java --- @@ -0,0 +1,112 @@ +package hivemall.lda; + +import

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109558404 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,497 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109578438 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,464 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109577680 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,464 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109580335 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,464 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109580061 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,464 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109578284 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,464 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109578413 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,464 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109577460 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,464 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109577240 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,464 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall pull request #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-03 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/66#discussion_r109558152 --- Diff: core/src/main/java/hivemall/lda/OnlineLDAModel.java --- @@ -0,0 +1,497 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-hivemall issue #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-04 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/66 @takuti If you are going to create predict UDAF, better to rename to `lda` to `train_lda`. Prediction expected to have feature vector as input and a predicted topic (& a poste

[GitHub] incubator-hivemall issue #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-06 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/66 ``` WITH result as ( select t.docid, lda_predict(t.wordid, t.value, m.label, m.lambda, '-alpha 0.01') as probabilities -- list (struct<label,sc

[GitHub] incubator-hivemall issue #66: [WIP][HIVEMALL-91] Implement Online LDA

2017-04-06 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/66 TravisCI is failing.. ``` test(hivemall.lda.OnlineLDAModelTest) Time elapsed: 0.566 sec <<< FAILURE! java.lang.AssertionError: `vegetables` SHOULD be more suitable t

[GitHub] incubator-hivemall pull request #70: [WIP][HIVEMALL-75-2] Update RandomFores...

2017-04-10 Thread myui
GitHub user myui opened a pull request: https://github.com/apache/incubator-hivemall/pull/70 [WIP][HIVEMALL-75-2] Update RandomForest usage ## What changes were proposed in this pull request? Add `tree_export` UDF and update RandomForest tutorial ## What type of PR

[GitHub] incubator-hivemall issue #68: [HIVEMALL-84] Add Docker Support

2017-04-09 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/68 Thanks! I'll look into it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-hivemall issue #63: [HIVEMALL-90] Refine incomplete AUC UDAF imple...

2017-04-09 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/63 @takuti terminatePartial/merge OIs are invalid ones. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hivemall pull request #63: [HIVEMALL-90] Refine incomplete AUC UDA...

2017-04-09 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/63#discussion_r110554001 --- Diff: core/src/main/java/hivemall/evaluation/AUCUDAF.java --- @@ -188,13 +234,19 @@ public void iterate(AggregationBuffer agg, Object

  1   2   3   4   5   6   7   >