Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/145
Merged. Thanks. I'll do some refactoring in the following commit
(TestUtils.java is redundant etc).
```
TestUtils.java
TestBinariseLabelUDTF.java
QuantifiedFeaturesUDTF.j
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/145
Sure.
---
Github user takuti commented on the issue:
https://github.com/apache/incubator-hivemall/pull/145
Added serialization test case to all existing GenericUDF/UDTF tests.
Vanilla UDF and UDAF tests are not changed.
@myui Could you review?
---
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/145
@takuti Ideally, we SHOULD have serialization tests for all UDFs. New UDFs
MUST have a serialization test.
---
Github user takuti commented on the issue:
https://github.com/apache/incubator-hivemall/pull/145
// Fixing scala test failure
---
Github user takuti commented on the issue:
https://github.com/apache/incubator-hivemall/pull/145
I just `grep KryoException` to find target UDFs. @myui Please let me know
if there are other UDFs we have to test/fix. Maybe, should we add
`testSerialization` to all existing UDF tests?