[GitHub] incubator-hivemall issue #145: [HIVEMALL-191] Add Kryo serialization test to...

2018-04-25 Thread myui
Github user myui commented on the issue:

https://github.com/apache/incubator-hivemall/pull/145
  
Merged. Thanks. I'll do some refactoring in the following commit 
(TestUtils.java is redundant etc).

```
TestUtils.java
TestBinariseLabelUDTF.java
QuantifiedFeaturesUDTF.java
KuromojiUDF.java
```


---


[GitHub] incubator-hivemall issue #145: [HIVEMALL-191] Add Kryo serialization test to...

2018-04-17 Thread myui
Github user myui commented on the issue:

https://github.com/apache/incubator-hivemall/pull/145
  
Sure. 


---


[GitHub] incubator-hivemall issue #145: [HIVEMALL-191] Add Kryo serialization test to...

2018-04-17 Thread takuti
Github user takuti commented on the issue:

https://github.com/apache/incubator-hivemall/pull/145
  
Added serialization test case to all existing GenericUDF/UDTF tests. 
Vanilla UDF and UDAF tests are not changed.

@myui Could you review?


---


[GitHub] incubator-hivemall issue #145: [HIVEMALL-191] Add Kryo serialization test to...

2018-04-16 Thread myui
Github user myui commented on the issue:

https://github.com/apache/incubator-hivemall/pull/145
  
@takuti Ideally, we SHOULD have serialization tests for all UDFs. New UDFs 
MUST have a serialization test.


---


[GitHub] incubator-hivemall issue #145: [HIVEMALL-191] Add Kryo serialization test to...

2018-04-16 Thread takuti
Github user takuti commented on the issue:

https://github.com/apache/incubator-hivemall/pull/145
  
// Fixing scala test failure


---


[GitHub] incubator-hivemall issue #145: [HIVEMALL-191] Add Kryo serialization test to...

2018-04-15 Thread takuti
Github user takuti commented on the issue:

https://github.com/apache/incubator-hivemall/pull/145
  
I just `grep KryoException` to find target UDFs. @myui Please let me know 
if there are other UDFs we have to test/fix. Maybe, should we add 
`testSerialization` to all existing UDF tests?


---