[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 LGTM. I'll merge with final checking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 [](https://coveralls.io/builds/12279119) Coverage increased (+0.006%) to 40.273% when pulling **ebb2e25226216f192f3227be70e9755032d8f783 on maropu:HIVEMALL-119** into **e9c66f0a1f3789cabd06e3b9fcaa56d52f05c2a0 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 @maropu Travis CI is failing. ``` [ERROR] /home/travis/build/apache/incubator-hivemall/spark/spark-2.0/src/main/java/hivemall/xgboost/classification/XGBoostBinaryClassifierUDTFWrapper.java:39: error: method does not override or implement a method from a supertype [ERROR] @Override [ERROR] ^ [ERROR] /home/travis/build/apache/incubator-hivemall/spark/spark-2.0/src/main/java/hivemall/xgboost/classification/XGBoostMulticlassClassifierUDTFWrapper.java:39: error: method does not override or implement a method from a supertype [ERROR] @Override [ERROR] ^ [ERROR] /home/travis/build/apache/incubator-hivemall/spark/spark-2.0/src/main/java/hivemall/xgboost/regression/XGBoostRegressionUDTFWrapper.java:39: error: method does not override or implement a method from a supertype [ERROR] @Override [ERROR] ^ ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user amaya382 commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 @maropu @myui sorry, my docker setting was wrong. it works fine :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 @amaya382 code has been modified and line information must be changed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user amaya382 commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 @myui same as [before](https://github.com/apache/incubator-hivemall/pull/95#issuecomment-313272530) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 @amaya382 give me stacktrace? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user amaya382 commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 @maropu umm... I faced the same error on faa5433 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user maropu commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 @amaya382 check again? I checked it worked well in my local env. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user maropu commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 Without `HadoopUtils.getTaskId()` in [here](https://github.com/maropu/incubator-hivemall/blob/e9fc6cfabd295c4c49faf43c4a44fe9eca2c9025/xgboost/src/main/java/hivemall/xgboost/XGBoostUDTF.java#L290), it works fine. But, I don't know this is why. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user maropu commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 ok, I hit the same error. I'll check again. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user amaya382 commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 @maropu Previous problem seems to be solved, but I got another error `MapredContext is not set` in [this workflow](https://github.com/apache/incubator-hivemall/pull/80#issuecomment-308322382) How did you test it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 [](https://coveralls.io/builds/12258581) Coverage decreased (-0.009%) to 40.257% when pulling **e9fc6cfabd295c4c49faf43c4a44fe9eca2c9025 on maropu:HIVEMALL-119** into **e9c66f0a1f3789cabd06e3b9fcaa56d52f05c2a0 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 [](https://coveralls.io/builds/12258479) Coverage decreased (-0.009%) to 40.257% when pulling **e9fc6cfabd295c4c49faf43c4a44fe9eca2c9025 on maropu:HIVEMALL-119** into **e9c66f0a1f3789cabd06e3b9fcaa56d52f05c2a0 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 [](https://coveralls.io/builds/12255834) Coverage increased (+0.3%) to 40.551% when pulling **d193adb3e48b35fb354faa7cc06deec190ac8d26 on maropu:HIVEMALL-119** into **5a1e79d9dce0a05274014e2906b096b1c2aa62d2 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #95: [HIVEMALL-119] Fix type cast issues in XGBoost...
Github user maropu commented on the issue: https://github.com/apache/incubator-hivemall/pull/95 @amaya382 Can you check this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
