[ 
https://issues.apache.org/jira/browse/HTRACE-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444072#comment-15444072
 ] 

Nisala Mendis commented on HTRACE-362:
--------------------------------------

Hi Colin,

In following commit [1] I have addressed the following,

1. Kudu table open happens only one time, we dont open it for each receiving 
span. However I couldn't find a place where I could close separate table. I 
guess session and client close would handle that thing. This is handled 
correctly when we close span receiver.
2. I have added separate table for store parents of all child spans. Added span 
id of child as foreign key so that we can correlate parent spans of a child 
spans. Now we can have all the parents of a child span not just one.

Please let me know if you are happy with the data  model here, so that I could 
apply to span viewer classes as well.

[1] 
https://github.com/apache/incubator-htrace/pull/11/commits/641d05bfe3b65e4df7c9097d7f3a3c8f76179f9b

Regards
Nisala

> Apache KUDU Span receiver implementation for Apache HTrace
> ----------------------------------------------------------
>
>                 Key: HTRACE-362
>                 URL: https://issues.apache.org/jira/browse/HTRACE-362
>             Project: HTrace
>          Issue Type: Bug
>            Reporter: Nisala Mendis
>            Assignee: Nisala Mendis
>         Attachments: HTRACE-362.001.patch, HTRACE-362.002.patch, 
> HTRACE-362.003.patch, HTRACE-362.004.patch, HTRACE-362.005.patch, 
> kudu_receiver.patch, kudu_span_receiver_basic_design.pdf
>
>
> Implementation should be carried two components as span receiver that writes 
> kudu back end and span viewer to view written span/traces.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to