[GitHub] [incubator-iceberg] waterlx commented on issue #457: DataFrame generated by Seq() might have schema conflict with Iceberg

2019-09-24 Thread GitBox
waterlx commented on issue #457: DataFrame generated by Seq() might have schema conflict with Iceberg URL: https://github.com/apache/incubator-iceberg/issues/457#issuecomment-534483177 @sujithjay , thanks for taking care of this! I see your point by changing the Iceberg schema, but

[GitHub] [incubator-iceberg] waterlx removed a comment on issue #492: Should issue an error/warning message when no data file to delete

2019-09-24 Thread GitBox
waterlx removed a comment on issue #492: Should issue an error/warning message when no data file to delete URL: https://github.com/apache/incubator-iceberg/issues/492#issuecomment-534425688 I used the following API, trying to delete a data file ```

[GitHub] [incubator-iceberg] waterlx commented on issue #492: Should issue an error message when no data file to delete

2019-09-24 Thread GitBox
waterlx commented on issue #492: Should issue an error message when no data file to delete URL: https://github.com/apache/incubator-iceberg/issues/492#issuecomment-534425688 I used the following API, trying to delete a data file ``` table.newDelete().deleteFile("file:///path1")

[GitHub] [incubator-iceberg] waterlx opened a new issue #493: concurrent delete

2019-09-24 Thread GitBox
waterlx opened a new issue #493: concurrent delete URL: https://github.com/apache/incubator-iceberg/issues/493 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-iceberg] waterlx commented on issue #493: Concurrently delete a data file

2019-09-24 Thread GitBox
waterlx commented on issue #493: Concurrently delete a data file URL: https://github.com/apache/incubator-iceberg/issues/493#issuecomment-534543516 @rdblue Could you please help to review my findings at your most convenience?

[GitHub] [incubator-iceberg] waterlx commented on issue #492: Should issue an error/warning message when no data file to delete

2019-09-24 Thread GitBox
waterlx commented on issue #492: Should issue an error/warning message when no data file to delete URL: https://github.com/apache/incubator-iceberg/issues/492#issuecomment-534545600 @rdblue make sense to you? This is an

[GitHub] [incubator-iceberg] rdblue commented on issue #493: Concurrently delete a data file

2019-09-24 Thread GitBox
rdblue commented on issue #493: Concurrently delete a data file URL: https://github.com/apache/incubator-iceberg/issues/493#issuecomment-534648500 This doesn't fail because deletes are idempotent. You tell Iceberg to delete with a filter or to delete a specific file, and that data will

[GitHub] [incubator-iceberg] rdblue commented on issue #492: Should issue an error/warning message when no data file to delete

2019-09-24 Thread GitBox
rdblue commented on issue #492: Should issue an error/warning message when no data file to delete URL: https://github.com/apache/incubator-iceberg/issues/492#issuecomment-534652798 We could add an option to StreamingDelete to validate that some data is deleted, if you wanted a failure

[GitHub] [incubator-iceberg] rdblue commented on issue #430: Support bucket table for Iceberg

2019-09-24 Thread GitBox
rdblue commented on issue #430: Support bucket table for Iceberg URL: https://github.com/apache/incubator-iceberg/issues/430#issuecomment-534654396 @jerryshao, yes that's correct. That's why we need to expose the transformation functions to Spark via FunctionCatalog, and add the

[GitHub] [incubator-iceberg] rdblue commented on issue #93: [MINOR] Throw an exception early if there is no dict available instead of handling dictionary-encoded pages for absent dict

2019-09-24 Thread GitBox
rdblue commented on issue #93: [MINOR] Throw an exception early if there is no dict available instead of handling dictionary-encoded pages for absent dict URL: https://github.com/apache/incubator-iceberg/pull/93#issuecomment-534786457 Looks good to me. If `dict` returned null, further uses

[GitHub] [incubator-iceberg] rdblue commented on issue #432: Allow writers to control size of files generated

2019-09-24 Thread GitBox
rdblue commented on issue #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#issuecomment-534785869 Thanks for fixing this, @xabriel! I'll merge it. This is an

[GitHub] [incubator-iceberg] rdblue merged pull request #432: Allow writers to control size of files generated

2019-09-24 Thread GitBox
rdblue merged pull request #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-iceberg] holdenk opened a new issue #494: TestScanSummary appears to be flaky

2019-09-24 Thread GitBox
holdenk opened a new issue #494: TestScanSummary appears to be flaky URL: https://github.com/apache/incubator-iceberg/issues/494 I was building Apache Icerberg for the first time and I ran into a test failure with `TestScanSummary`. Re-running the test with debugging information on, or by

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #430: Support bucket table for Iceberg

2019-09-24 Thread GitBox
aokolnychyi commented on issue #430: Support bucket table for Iceberg URL: https://github.com/apache/incubator-iceberg/issues/430#issuecomment-534852783 @dbtsai, FYI This is an automated message from the Apache Git Service.