[GitHub] aokolnychyi opened a new pull request #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
aokolnychyi opened a new pull request #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79 This PR adds `metastore-site.xml` to propagate Hive config values set in `HiveTableBaseTest`. Right now, Iceberg sets all config options dynamically in

[GitHub] danielcweeks commented on issue #45: Lazily submit tasks in ParallelIterable and add cancellation.

2019-01-16 Thread GitBox
danielcweeks commented on issue #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#issuecomment-454844680 +1 This is an automated message from the

[GitHub] danielcweeks merged pull request #45: Lazily submit tasks in ParallelIterable and add cancellation.

2019-01-16 Thread GitBox
danielcweeks merged pull request #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45 This is an automated message from the Apache Git Service. To

[GitHub] rdblue commented on issue #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
rdblue commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-454869104 @Parth-Brahmbhatt, regarding `datanucleus.schema.autoCreateAll`, can we change how the test is structured so that we don't have to load the DB

[GitHub] rdblue commented on issue #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
rdblue commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-454869301 This looks fine to me, but I'd like to hear what Parth thinks. This is an

[GitHub] Parth-Brahmbhatt edited a comment on issue #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
Parth-Brahmbhatt edited a comment on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-454873987 LGTM. @rdblue iirc When I tried to just use ```datanucleus.schema.autoCreateAll``` the transaction tables were not created.

[GitHub] rdblue commented on issue #45: Lazily submit tasks in ParallelIterable and add cancellation.

2019-01-16 Thread GitBox
rdblue commented on issue #45: Lazily submit tasks in ParallelIterable and add cancellation. URL: https://github.com/apache/incubator-iceberg/pull/45#issuecomment-454859827 Thanks for the reviews, everyone! This is an

[GitHub] aokolnychyi commented on issue #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
aokolnychyi commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-454865665 @Parth-Brahmbhatt @rdblue could you take a look at this change? Please, correct me if I missed something during my analysis.

[GitHub] rdblue commented on issue #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
rdblue commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-454874604 We can follow up with a PR to get rid of script runner if that works. For now, let's get this fix committed. Thanks @aokolnychyi!

[GitHub] rdblue merged pull request #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
rdblue merged pull request #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] Parth-Brahmbhatt commented on issue #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
Parth-Brahmbhatt commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-454873987 LGTM. @rdblue iirc When I tried to just use ```datanucleus.schema.autoCreateAll``` the transaction tables were not created.

[GitHub] aokolnychyi commented on issue #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
aokolnychyi commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-454875861 I'll give it a try and let you know This is an automated message from the

[GitHub] mccheah commented on issue #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-16 Thread GitBox
mccheah commented on issue #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#issuecomment-454947966 @rdblue any further comments on this?

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-16 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248506102 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-16 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248506265 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-16 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248507495 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-16 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r24850 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-16 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248511242 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-16 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248511242 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-16 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248505317 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-16 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248505098 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-16 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248506812 ## File path:

[GitHub] rdblue commented on issue #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-16 Thread GitBox
rdblue commented on issue #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#issuecomment-455002791 @mccheah, thanks for working on this. It's looking close, but I have doubts

[GitHub] mccheah commented on issue #80: Introduce metadata for encrypting table data files

2019-01-17 Thread GitBox
mccheah commented on issue #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#issuecomment-455339278 Ok now this represents the current state of the proposal document in its entirety.

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-17 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r248825239 ## File path: core/src/main/java/com/netflix/iceberg/util/ByteBuffers.java ## @@ -0,0 +1,38

[GitHub] mccheah opened a new issue #81: Encryption KeyManager implementation that is backed by KMS

2019-01-17 Thread GitBox
mccheah opened a new issue #81: Encryption KeyManager implementation that is backed by KMS URL: https://github.com/apache/incubator-iceberg/issues/81 KMS seems to be a reasonable key management service to support out of the box following the introduction of the encryption API from #20.

[GitHub] mccheah opened a new pull request #80: Introduce metadata for encrypting table data files

2019-01-17 Thread GitBox
mccheah opened a new pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80 Introduces the APIs and changes to schemas to support encryption in Iceberg table data files in the near future.

[GitHub] mccheah closed pull request #25: Add the encryption metadata field to the DataFile schema

2019-01-17 Thread GitBox
mccheah closed pull request #25: Add the encryption metadata field to the DataFile schema URL: https://github.com/apache/incubator-iceberg/pull/25 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mccheah commented on issue #25: Add the encryption metadata field to the DataFile schema

2019-01-17 Thread GitBox
mccheah commented on issue #25: Add the encryption metadata field to the DataFile schema URL: https://github.com/apache/incubator-iceberg/pull/25#issuecomment-455312498 Superceded by https://github.com/apache/incubator-iceberg/pull/80

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-17 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r248822654 ## File path: api/src/main/java/com/netflix/iceberg/encryption/FileEncryptionMetadata.java

[GitHub] mccheah commented on issue #80: Introduce metadata for encrypting table data files

2019-01-17 Thread GitBox
mccheah commented on issue #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#issuecomment-455317288 Also @omalley This is an automated message from the Apache

[GitHub] mccheah commented on issue #28: Apply baseline checkstyle for iceberg-api only

2019-01-17 Thread GitBox
mccheah commented on issue #28: Apply baseline checkstyle for iceberg-api only URL: https://github.com/apache/incubator-iceberg/pull/28#issuecomment-455341071 Let's prepare to do this after https://github.com/apache/incubator-iceberg/pull/69

[GitHub] mccheah commented on issue #80: Introduce metadata for encrypting table data files

2019-01-17 Thread GitBox
mccheah commented on issue #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#issuecomment-455313651 @rdblue @yifeih @vinooganesh This version mirrors most of what's in [this design

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-17 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r248823026 ## File path: api/src/main/java/com/netflix/iceberg/encryption/PhysicalEncryptionKey.java

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-17 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r248823663 ## File path: api/src/main/java/com/netflix/iceberg/encryption/PhysicalEncryptionKey.java

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-17 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r248824089 ## File path: api/src/main/java/com/netflix/iceberg/encryption/FileEncryptionMetadata.java

[GitHub] xabriel opened a new pull request #82: Make expression binding case insensitive

2019-01-17 Thread GitBox
xabriel opened a new pull request #82: Make expression binding case insensitive URL: https://github.com/apache/incubator-iceberg/pull/82 Iceberg's current implementation has column case sensitivity, which hinders usability, as most sql users expect case insensitivity by default. While a

[GitHub] xabriel opened a new issue #83: Make expression binding case insensitive

2019-01-17 Thread GitBox
xabriel opened a new issue #83: Make expression binding case insensitive URL: https://github.com/apache/incubator-iceberg/issues/83 Iceberg's current implementation has column case sensitivity, which hinders usability, as most sql users expect case insensitivity by default. While a query

[GitHub] rdblue commented on issue #82: Make expression binding case insensitive

2019-01-18 Thread GitBox
rdblue commented on issue #82: Make expression binding case insensitive URL: https://github.com/apache/incubator-iceberg/pull/82#issuecomment-455652563 Thanks for catching this, @xabriel. Looks like a reasonable set of changes to me. The only problem I have is that this should be

[GitHub] mccheah commented on issue #80: Introduce metadata for encrypting table data files

2019-01-18 Thread GitBox
mccheah commented on issue #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#issuecomment-455673935 After trying to build on top of this work to do the actual encryption/decryption in the Spark data source, I realized that

[GitHub] rdblue commented on issue #82: Make expression binding case insensitive

2019-01-18 Thread GitBox
rdblue commented on issue #82: Make expression binding case insensitive URL: https://github.com/apache/incubator-iceberg/pull/82#issuecomment-455652830 I should also note that we could also update Spark to pass the correct case back to v2 sources. That's probably a good idea either way.

[GitHub] aokolnychyi commented on issue #79: Fix propagation of Hive configs

2019-01-19 Thread GitBox
aokolnychyi commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-455763677 Actually, we need to revert this change. I was too quick with my analysis. I missed the point that the config passed to

[GitHub] mccheah commented on issue #80: Introduce metadata for encrypting table data files

2019-01-18 Thread GitBox
mccheah commented on issue #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#issuecomment-455731450 Mentioned this above, but see

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-18 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249223786 ## File path: api/src/main/java/com/netflix/iceberg/encryption/EncryptionKeyMetadata.java

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-18 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249223786 ## File path: api/src/main/java/com/netflix/iceberg/encryption/EncryptionKeyMetadata.java

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-18 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249223786 ## File path: api/src/main/java/com/netflix/iceberg/encryption/EncryptionKeyMetadata.java

[GitHub] mccheah edited a comment on issue #80: Introduce metadata for encrypting table data files

2019-01-18 Thread GitBox
mccheah edited a comment on issue #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#issuecomment-455731450 Mentioned this above, but see https://github.com/mccheah/incubator-iceberg/pull/1 for a target follow-up commit that

[GitHub] xabriel commented on issue #82: Make expression binding case insensitive

2019-01-18 Thread GitBox
xabriel commented on issue #82: Make expression binding case insensitive URL: https://github.com/apache/incubator-iceberg/pull/82#issuecomment-455725464 Thanks for the feedback, @rdblue. > If Iceberg should not impose case sensitivity on processing engines then it shouldn't impose

[GitHub] aokolnychyi commented on issue #72: Fix filtering manifests in unpartitioned tables.

2019-01-14 Thread GitBox
aokolnychyi commented on issue #72: Fix filtering manifests in unpartitioned tables. URL: https://github.com/apache/incubator-iceberg/pull/72#issuecomment-454017882 This LGTM. Thanks! This is an automated message from the

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248007784 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248007451 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248022851 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248040856 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248008523 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248008523 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248025128 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248024959 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248009701 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248009374 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248023345 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248028056 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248006869 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248007451 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247653060 ## File path:

[GitHub] rdblue merged pull request #71: Allow passing the unpartitioned spec to DataFiles.builder.

2019-01-14 Thread GitBox
rdblue merged pull request #71: Allow passing the unpartitioned spec to DataFiles.builder. URL: https://github.com/apache/incubator-iceberg/pull/71 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@iceberg.apache.org

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247625807 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247652730 ## File path:

[GitHub] rdblue commented on issue #72: Fix filtering manifests in unpartitioned tables.

2019-01-14 Thread GitBox
rdblue commented on issue #72: Fix filtering manifests in unpartitioned tables. URL: https://github.com/apache/incubator-iceberg/pull/72#issuecomment-454118807 Thanks for reviewing @aokolnychyi and @Parth-Brahmbhatt! This is

[GitHub] rdblue merged pull request #72: Fix filtering manifests in unpartitioned tables.

2019-01-14 Thread GitBox
rdblue merged pull request #72: Fix filtering manifests in unpartitioned tables. URL: https://github.com/apache/incubator-iceberg/pull/72 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@iceberg.apache.org

[GitHub] rdblue edited a comment on issue #75: Add startsWith predicate

2019-01-14 Thread GitBox
rdblue edited a comment on issue #75: Add startsWith predicate URL: https://github.com/apache/incubator-iceberg/pull/75#issuecomment-453874634 @renato2099, inclusive projection happens in the `Transform.project` method. You'll need to update any `Transform` that can project a `startsWith`

[GitHub] rdblue merged pull request #70: Allow schema updates in transactions.

2019-01-14 Thread GitBox
rdblue merged pull request #70: Allow schema updates in transactions. URL: https://github.com/apache/incubator-iceberg/pull/70 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@iceberg.apache.org

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247620076 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247645225 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247653794 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247639962 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247659863 ## File path:

[GitHub] rdblue merged pull request #66: Update struct fields for doc-only changes.

2019-01-14 Thread GitBox
rdblue merged pull request #66: Update struct fields for doc-only changes. URL: https://github.com/apache/incubator-iceberg/pull/66 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@iceberg.apache.org

[GitHub] rdblue merged pull request #68: Support customizing table locations

2019-01-14 Thread GitBox
rdblue merged pull request #68: Support customizing table locations URL: https://github.com/apache/incubator-iceberg/pull/68 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@iceberg.apache.org

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247683524 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247682766 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247689124 ## File path:

[GitHub] mccheah commented on issue #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
mccheah commented on issue #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#issuecomment-454562306 Addressed comments.

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-15 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r248072334 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247727549 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247728112 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247745842 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247728506 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247744889 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247737497 ## File path:

[GitHub] rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
rdblue commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r247737758 ## File path:

[GitHub] mccheah commented on issue #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-14 Thread GitBox
mccheah commented on issue #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#issuecomment-454260604 @rdblue addressed most of the comments. Think there's a few things we can

[GitHub] rdblue commented on issue #84: Parquet write should use Hadoop conf from HadoopOutputFile

2019-01-21 Thread GitBox
rdblue commented on issue #84: Parquet write should use Hadoop conf from HadoopOutputFile URL: https://github.com/apache/incubator-iceberg/pull/84#issuecomment-456166796 Looks good to me. Thanks for catching this error, @jzhuge!

[GitHub] rdblue merged pull request #84: Parquet write should use Hadoop conf from HadoopOutputFile

2019-01-21 Thread GitBox
rdblue merged pull request #84: Parquet write should use Hadoop conf from HadoopOutputFile URL: https://github.com/apache/incubator-iceberg/pull/84 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mccheah commented on a change in pull request #63: Use Iceberg writers for Parquet data written from Spark.

2019-01-21 Thread GitBox
mccheah commented on a change in pull request #63: Use Iceberg writers for Parquet data written from Spark. URL: https://github.com/apache/incubator-iceberg/pull/63#discussion_r249619238 ## File path: spark/src/main/java/com/netflix/iceberg/spark/data/SparkParquetWriters.java

[GitHub] mccheah commented on a change in pull request #63: Use Iceberg writers for Parquet data written from Spark.

2019-01-21 Thread GitBox
mccheah commented on a change in pull request #63: Use Iceberg writers for Parquet data written from Spark. URL: https://github.com/apache/incubator-iceberg/pull/63#discussion_r249620090 ## File path: spark/src/main/java/com/netflix/iceberg/spark/data/SparkParquetWriters.java

[GitHub] mccheah commented on a change in pull request #63: Use Iceberg writers for Parquet data written from Spark.

2019-01-21 Thread GitBox
mccheah commented on a change in pull request #63: Use Iceberg writers for Parquet data written from Spark. URL: https://github.com/apache/incubator-iceberg/pull/63#discussion_r249619048 ## File path: spark/src/main/java/com/netflix/iceberg/spark/data/SparkParquetWriters.java

[GitHub] mccheah commented on a change in pull request #63: Use Iceberg writers for Parquet data written from Spark.

2019-01-21 Thread GitBox
mccheah commented on a change in pull request #63: Use Iceberg writers for Parquet data written from Spark. URL: https://github.com/apache/incubator-iceberg/pull/63#discussion_r249618843 ## File path: spark/src/main/java/com/netflix/iceberg/spark/data/SparkParquetWriters.java

[GitHub] mccheah commented on issue #69: Use "org.apache.iceberg" package name

2019-01-21 Thread GitBox
mccheah commented on issue #69: Use "org.apache.iceberg" package name URL: https://github.com/apache/incubator-iceberg/pull/69#issuecomment-456245249 Conflicts in a lot of places. Think it would be great to take a look at this soon - would like this to unblock code linting work for 1.x

[GitHub] mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-22 Thread GitBox
mccheah commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249965552 ## File path: api/src/main/java/com/netflix/iceberg/encryption/EncryptionKeyMetadata.java

[GitHub] rdblue commented on a change in pull request #80: Introduce metadata for encrypting table data files

2019-01-22 Thread GitBox
rdblue commented on a change in pull request #80: Introduce metadata for encrypting table data files URL: https://github.com/apache/incubator-iceberg/pull/80#discussion_r249969490 ## File path: api/src/main/java/com/netflix/iceberg/encryption/PhysicalEncryptionKey.java ##

  1   2   3   4   5   6   7   8   9   10   >