[GitHub] [incubator-iceberg] rdblue commented on issue #751: Add an option to decide whether to delete data files in Catalog.dropTable()

2020-02-12 Thread GitBox
rdblue commented on issue #751: Add an option to decide whether to delete data 
files in Catalog.dropTable()
URL: 
https://github.com/apache/incubator-iceberg/issues/751#issuecomment-585359978
 
 
   I think that keeping both data and metadata is the correct behavior. That 
way, drop removes a reference to the table, but the table itself is still 
readable should you wish to recover it. If Iceberg were to drop metadata, then 
it would be extremely difficult to actually use the data files that are left if 
you wanted to recover the table.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



[GitHub] [incubator-iceberg] rdblue commented on issue #751: Add an option to decide whether to delete data files in Catalog.dropTable()

2020-02-02 Thread GitBox
rdblue commented on issue #751: Add an option to decide whether to delete data 
files in Catalog.dropTable()
URL: 
https://github.com/apache/incubator-iceberg/issues/751#issuecomment-581184344
 
 
   I think you're saying you want a purge option that deletes metadata, but not 
data?
   
   I'm very reluctant to add cases like this to the API. We want to keep the 
API small, and I think this may be specific to your use case. What about doing 
this in the application that creates the staging tables instead? You'd set 
purge=false when dropping the table and then clean up the metadata using your 
own code. Would that work?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org