shardulm94 commented on pull request #900: URL: https://github.com/apache/incubator-iceberg/pull/900#issuecomment-632832524
I think it is ready. @aokolnychyi had a comment about not testing timestamp types in here, but thats because 1. Iceberg Spark doesn't support Timestamp without zone 2. Spark file readers don't support TIMESTAMP_INSTANT which is the ORC type Iceberg uses for Timestamp with zone ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org