Re: [PR] Geo type changes [iceberg-rust]

2026-04-12 Thread via GitHub


github-actions[bot] commented on PR #2019:
URL: https://github.com/apache/iceberg-rust/pull/2019#issuecomment-4233099847

   This pull request has been closed due to lack of activity. This is not a 
judgement on the merit of the PR in any way. It is just a way of keeping the PR 
queue manageable. If you think that is incorrect, or the pull request requires 
review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Geo type changes [iceberg-rust]

2026-04-12 Thread via GitHub


github-actions[bot] closed pull request #2019: Geo type changes
URL: https://github.com/apache/iceberg-rust/pull/2019


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Geo type changes [iceberg-rust]

2026-04-05 Thread via GitHub


github-actions[bot] commented on PR #2019:
URL: https://github.com/apache/iceberg-rust/pull/2019#issuecomment-4189810048

   This pull request has been marked as stale due to 30 days of inactivity. It 
will be closed in 1 week if no further activity occurs. If you think that’s 
incorrect or this pull request requires a review, please simply write any 
comment. If closed, you can revive the PR at any time and @mention a reviewer 
or discuss it on the [email protected] list. Thank you for your 
contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Geo type changes [iceberg-rust]

2026-03-06 Thread via GitHub


nuts-rice commented on PR #2019:
URL: https://github.com/apache/iceberg-rust/pull/2019#issuecomment-4012254767

   Would you mind if I fork this to add a geo types example?
   #1826 was working on this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Geo type changes [iceberg-rust]

2026-03-04 Thread via GitHub


brgr-s commented on PR #2019:
URL: https://github.com/apache/iceberg-rust/pull/2019#issuecomment-3996290622

   @rambleraptor 
   
   I came across this PR because we wanted to implement geospatial columns for 
our [fork of icebeg-rust](https://github.com/lakekeeper/iceberg-rust) that we 
are using in Lakekeeper. We already provided a PR for partial support of the 
VARIANT type (https://github.com/apache/iceberg-rust/pull/2188)
   
   I made some additions to your changes because I _think_ there where Edge 
Interpolation Algorithms missing for the GEOGRAPHY type. Also I couldn't find 
the 'planar' Edge Interpolaton Algorithm, at least in the parquet spec.
   
   If you find those changes usefull you can find them here: 
https://github.com/brgr-s/iceberg-rust/tree/feat/geo-types-support
   
   I think the biggest obstacle is that integration tests that Spark 4.1 does 
not yet support geospatial types, so we can't integration test the feature at 
the moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Geo type changes [iceberg-rust]

2026-02-23 Thread via GitHub


BlakeOrth commented on PR #2019:
URL: https://github.com/apache/iceberg-rust/pull/2019#issuecomment-3947814732

   hi @rambleraptor I came across this PR from the attached issue and am 
interested in helping this effort move forward. It looks like there are still 
some "todo" items in this implementation and it's not immediately clear to me 
if you're still working on this or are waiting on review etc.
   
   I'd be happy to give a more thorough review against the spec if that's 
something you're needing to push forward on this. Otherwise, is there anything 
I can do to help move this along?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]