Re: [PR] REST: Refactor docker image files [iceberg]
Fokko merged PR #11676: URL: https://github.com/apache/iceberg/pull/11676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] REST: Refactor docker image files [iceberg]
Fokko commented on PR #11676: URL: https://github.com/apache/iceberg/pull/11676#issuecomment-2509608109 Let's move this forward. Once the [Infra](https://issues.apache.org/jira/browse/INFRA-26275) ticket is resolved, we can push this forward :) Thanks again @ajantha-bhat for fixing this, and thanks @kevinjqliu and @sungwy for the review 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] REST: Refactor docker image files [iceberg]
kevinjqliu commented on code in PR #11676: URL: https://github.com/apache/iceberg/pull/11676#discussion_r1864452782 ## .github/workflows/publish-iceberg-rest-fixture-docker.yml: ## @@ -28,6 +28,7 @@ on: env: DOCKER_IMAGE_TAG: iceberg-rest-fixture DOCKER_IMAGE_VERSION: latest + DOCKER_REPOSITORY: apache Review Comment: this was to match the order of the docker name part of: ``` docker push $DOCKER_REPOSITORY/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION ``` again, nit comment :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] REST: Refactor docker image files [iceberg]
ajantha-bhat commented on code in PR #11676: URL: https://github.com/apache/iceberg/pull/11676#discussion_r1864021521 ## .github/workflows/publish-iceberg-rest-fixture-docker.yml: ## @@ -28,6 +28,7 @@ on: env: DOCKER_IMAGE_TAG: iceberg-rest-fixture DOCKER_IMAGE_VERSION: latest + DOCKER_REPOSITORY: apache Review Comment: keys were alphabetically sorted before. I didn't get the intention behind this comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] REST: Refactor docker image files [iceberg]
kevinjqliu commented on code in PR #11676: URL: https://github.com/apache/iceberg/pull/11676#discussion_r1863874986 ## .github/workflows/publish-iceberg-rest-fixture-docker.yml: ## @@ -28,6 +28,7 @@ on: env: DOCKER_IMAGE_TAG: iceberg-rest-fixture DOCKER_IMAGE_VERSION: latest + DOCKER_REPOSITORY: apache Review Comment: ```suggestion DOCKER_REPOSITORY: apache DOCKER_IMAGE_TAG: iceberg-rest-fixture DOCKER_IMAGE_VERSION: latest ``` nit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] REST: Refactor docker image files [iceberg]
kevinjqliu commented on code in PR #11676: URL: https://github.com/apache/iceberg/pull/11676#discussion_r1863872835 ## docker/iceberg-rest-fixture/README.md: ## @@ -32,7 +32,7 @@ When making changes to the local files and test them out, you can build the imag ./gradlew :iceberg-open-api:shadowJar # Rebuild the docker image -docker image rm -f apache/iceberg-rest-adapter && docker build -t apache/iceberg-rest-adapter -f docker/iceberg-rest-adapter-image/Dockerfile . +docker image rm -f apache/iceberg-rest-adapter && docker build -t apache/iceberg-rest-adapter -f docker/iceberg-rest-fixture/Dockerfile . Review Comment: nit: change the name to `iceberg-rest-fixture` to match dockerhub, ```suggestion docker image rm -f apache/iceberg-rest-fixture && docker build -t apache/iceberg-rest-fixture -f docker/iceberg-rest-fixture/Dockerfile . ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] REST: Refactor docker image files [iceberg]
sungwy commented on code in PR #11676: URL: https://github.com/apache/iceberg/pull/11676#discussion_r1863869770 ## docker/iceberg-rest-fixture/README.md: ## @@ -32,7 +32,7 @@ When making changes to the local files and test them out, you can build the imag ./gradlew :iceberg-open-api:shadowJar # Rebuild the docker image -docker image rm -f apache/iceberg-rest-adapter && docker build -t apache/iceberg-rest-adapter -f docker/iceberg-rest-adapter-image/Dockerfile . +docker image rm -f apache/iceberg-rest-adapter && docker build -t apache/iceberg-rest-adapter -f docker/iceberg-rest-fixture/Dockerfile . Review Comment: minor nit here: ```suggestion docker image rm -f apache/iceberg-rest-fixture && docker build -t apache/iceberg-rest-fixture -f docker/iceberg-rest-fixture/Dockerfile . ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] REST: Refactor docker image files [iceberg]
Fokko commented on code in PR #11676:
URL: https://github.com/apache/iceberg/pull/11676#discussion_r1863459375
##
.github/workflows/publish-iceberg-rest-fixture-docker.yml:
##
@@ -42,14 +42,14 @@ jobs:
run: ./gradlew :iceberg-open-api:shadowJar
- name: Login to Docker Hub
run: |
-docker login -u ${{ secrets.DOCKERHUB_USER }} -p ${{
secrets.DOCKERHUB_TOKEN }}
+docker login -u apache -p ${{ secrets.DOCKERHUB_TOKEN }}
- name: Set the tagged version
- # for tag 'apache-iceberg-1.7.0', publish image
'apache/iceberg-rest-fixture:1.7.1'
+ # for tag 'apache-iceberg-1.7.1', publish image
'apache/iceberg-rest-fixture:1.7.1'
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
run: |
echo "DOCKER_IMAGE_VERSION=`echo ${{ github.ref }} | tr -d -c 0-9.`"
>> "$GITHUB_ENV"
- name: Build Docker Image
- run: docker build -t ${{ secrets.DOCKERHUB_USER
}}/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION -f
docker/iceberg-rest-adapter-image/Dockerfile .
+ run: docker build -t apache/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION -f
docker/iceberg-rest-fixture/Dockerfile .
Review Comment:
```suggestion
run: docker build -t
$DOCKER_REPOSITORY/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION -f
docker/iceberg-rest-fixture/Dockerfile .
```
##
.github/workflows/publish-iceberg-rest-fixture-docker.yml:
##
@@ -42,14 +42,14 @@ jobs:
run: ./gradlew :iceberg-open-api:shadowJar
- name: Login to Docker Hub
run: |
-docker login -u ${{ secrets.DOCKERHUB_USER }} -p ${{
secrets.DOCKERHUB_TOKEN }}
+docker login -u apache -p ${{ secrets.DOCKERHUB_TOKEN }}
Review Comment:
As mentioned in the comment
https://github.com/apache/iceberg/pull/11673#issuecomment-2507538087 the user
and repository can be different if you're using an organization:
```suggestion
docker login -u ${{ secrets.DOCKERHUB_USER }} -p ${{
secrets.DOCKERHUB_TOKEN }}
```
##
.github/workflows/publish-iceberg-rest-fixture-docker.yml:
##
@@ -42,14 +42,14 @@ jobs:
run: ./gradlew :iceberg-open-api:shadowJar
- name: Login to Docker Hub
run: |
-docker login -u ${{ secrets.DOCKERHUB_USER }} -p ${{
secrets.DOCKERHUB_TOKEN }}
+docker login -u apache -p ${{ secrets.DOCKERHUB_TOKEN }}
- name: Set the tagged version
- # for tag 'apache-iceberg-1.7.0', publish image
'apache/iceberg-rest-fixture:1.7.1'
+ # for tag 'apache-iceberg-1.7.1', publish image
'apache/iceberg-rest-fixture:1.7.1'
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
run: |
echo "DOCKER_IMAGE_VERSION=`echo ${{ github.ref }} | tr -d -c 0-9.`"
>> "$GITHUB_ENV"
- name: Build Docker Image
- run: docker build -t ${{ secrets.DOCKERHUB_USER
}}/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION -f
docker/iceberg-rest-adapter-image/Dockerfile .
+ run: docker build -t apache/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION -f
docker/iceberg-rest-fixture/Dockerfile .
- name: Push Docker Image
run: |
-docker push ${{ secrets.DOCKERHUB_USER
}}/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION
+docker push apache/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION
Review Comment:
```suggestion
docker push
$DOCKER_REPOSITORY/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
