[jira] [Comment Edited] (IGNITE-5233) JDBC thin Driver: implement metadata support

2017-08-14 Thread Vladimir Ozerov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125565#comment-16125565
 ] 

Vladimir Ozerov edited comment on IGNITE-5233 at 8/14/17 11:32 AM:
---

[~tledkov-gridgain], please see my comments inlined in the code.


was (Author: vozerov):
[~tledkov-gridgain], please see my comments inlined to the code.

> JDBC thin Driver: implement metadata support 
> -
>
> Key: IGNITE-5233
> URL: https://issues.apache.org/jira/browse/IGNITE-5233
> Project: Ignite
>  Issue Type: Task
>  Components: jdbc
>Affects Versions: 2.0
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
>Priority: Blocker
> Fix For: 2.2
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (IGNITE-5233) JDBC thin Driver: implement metadata support

2017-08-10 Thread Taras Ledkov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121789#comment-16121789
 ] 

Taras Ledkov edited comment on IGNITE-5233 at 8/10/17 3:25 PM:
---

Comments are fixed except:
10. & 23. For {{getFunctions}} methods the separate ticket is filed: 
IGNITE-6028.
17. Ignite and H2 don't support user-defined SQL types.
22. There is the ticket for the Client Info: IGNITE-5425.

[Tests 
results|https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests=projectOverview_Ignite20Tests=pull%2F2079%2Fhead]
 are OK.

Also, I propose to add full API tests for metadata with the ticket: IGNITE-5339.

[~vozerov], please take a look.


was (Author: tledkov-gridgain):
Comments are fixed except:
10. & 23. For {{getFunctions}} methods the separate ticket is filed: 
IGNITE-6028.
17. Ignite and H2 don't support user-defined SQL types.
22. There is the ticket for the Client Info: IGNITE-5425.

[Tests 
results|https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests=projectOverview_Ignite20Tests=pull%2F2079%2Fhead]
 are OK.

Also, I propose to add full API tests for metadata with the ticket: IGNITE-5339.

> JDBC thin Driver: implement metadata support 
> -
>
> Key: IGNITE-5233
> URL: https://issues.apache.org/jira/browse/IGNITE-5233
> Project: Ignite
>  Issue Type: Task
>  Components: jdbc
>Affects Versions: 2.0
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
> Fix For: 2.2
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (IGNITE-5233) JDBC thin Driver: implement metadata support

2017-08-10 Thread Taras Ledkov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121789#comment-16121789
 ] 

Taras Ledkov edited comment on IGNITE-5233 at 8/10/17 3:25 PM:
---

Comments are fixed except:
10. & 23. For {{getFunctions}} methods the separate ticket is filed: 
IGNITE-6028.
17. Ignite and H2 don't support user-defined SQL types.
22. There is the ticket for the Client Info: IGNITE-5425.

[Tests 
results|https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests=projectOverview_Ignite20Tests=pull%2F2079%2Fhead]
 are OK.

Also, I propose to add full API tests for metadata with the ticket: IGNITE-5339.


was (Author: tledkov-gridgain):
Comments are fixed except:
10. & 23. For {{getFunctions}} methods the separate ticket is filed: 
IGNITE-6028.
17. Ignite and H2 don't support user-defined SQL types.
22. There is the ticket for the Client Info: IGNITE-5425.

[Tests 
results|https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests=projectOverview_Ignite20Tests=pull%2F2079%2Fhead]
 are OK.

> JDBC thin Driver: implement metadata support 
> -
>
> Key: IGNITE-5233
> URL: https://issues.apache.org/jira/browse/IGNITE-5233
> Project: Ignite
>  Issue Type: Task
>  Components: jdbc
>Affects Versions: 2.0
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
> Fix For: 2.2
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (IGNITE-5233) JDBC thin Driver: implement metadata support

2017-08-08 Thread Sergey Kalashnikov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118225#comment-16118225
 ] 

Sergey Kalashnikov edited comment on IGNITE-5233 at 8/8/17 11:47 AM:
-

[~tledkov-gridgain]
I only have 1 new comment:

{{JdbcRequestHandler.getPrimaryKeys()}}. Please change new String[] {"_KEY"} to 
new String[] {keyName}.


was (Author: skalashnikov):
[~tledkov-gridgain]
I only have 1 new comment:

{{JdbcRequestHandler.getPrimaryKeys()}}. Please change {{new String[] 
{"_KEY"}}} to {{new String[] {keyName}}}.

> JDBC thin Driver: implement metadata support 
> -
>
> Key: IGNITE-5233
> URL: https://issues.apache.org/jira/browse/IGNITE-5233
> Project: Ignite
>  Issue Type: Task
>  Components: jdbc
>Affects Versions: 2.0
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
> Fix For: 2.2
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (IGNITE-5233) JDBC thin Driver: implement metadata support

2017-08-08 Thread Taras Ledkov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118109#comment-16118109
 ] 

Taras Ledkov edited comment on IGNITE-5233 at 8/8/17 10:03 AM:
---

[~skalashnikov], thanks for your comments.

1. Fixed. I've removed upper cases forcing.
2. Fixed.
3. Fixed. Add correct handle for {{null}} params; table name splitting is 
removed because JDBC docs doesn't contain any information about it and e.g. H2 
doesn't.
4-11. Fixed.

[Tests 
results|https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests=projectOverview_Ignite20Tests=pull%2F2079%2Fhead]
 are OK.


was (Author: tledkov-gridgain):
[~skalashnikov], thanks for your comments.

1. Fixed. I've removed upper cases forcing.
2. Fixed.
3. Fixed. Add correct handle for {{null}} params; table name splitting is 
removed because JDBC docs doesn't contain any information about it and e.g. H2 
doesn't.
4-11. Fixed.

[Tests 
results|https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests=projectOverview_Ignite20Tests=pull%2F2079%2Fhead]

> JDBC thin Driver: implement metadata support 
> -
>
> Key: IGNITE-5233
> URL: https://issues.apache.org/jira/browse/IGNITE-5233
> Project: Ignite
>  Issue Type: Task
>  Components: jdbc
>Affects Versions: 2.0
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
> Fix For: 2.2
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (IGNITE-5233) JDBC thin Driver: implement metadata support

2017-08-08 Thread Taras Ledkov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118109#comment-16118109
 ] 

Taras Ledkov edited comment on IGNITE-5233 at 8/8/17 9:50 AM:
--

[~skalashnikov], thanks for your comments.

1. Fixed. I've removed upper cases forcing.
2. Fixed.
3. Fixed. Add correct handle for {{null}} params; table name splitting is 
removed because JDBC docs doesn't contain any information about it and e.g. H2 
doesn't.
4-11. Fixed.

[Tests 
results|https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests=projectOverview_Ignite20Tests=pull%2F2079%2Fhead]


was (Author: tledkov-gridgain):
[~skalashnikov], thanks for your comments.

1. Fixed. I've removed upper cases forcing.
2. Fixed.
3. Fixed. Add correct handle for {{null}} params; table name splitting is 
removed because JDBC docs doesn't contain any information about it and e.g. H2 
doesn't.
4-11. Fixed.

> JDBC thin Driver: implement metadata support 
> -
>
> Key: IGNITE-5233
> URL: https://issues.apache.org/jira/browse/IGNITE-5233
> Project: Ignite
>  Issue Type: Task
>  Components: jdbc
>Affects Versions: 2.0
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
> Fix For: 2.2
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (IGNITE-5233) JDBC thin Driver: implement metadata support

2017-08-08 Thread Taras Ledkov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118109#comment-16118109
 ] 

Taras Ledkov edited comment on IGNITE-5233 at 8/8/17 9:50 AM:
--

[~skalashnikov], thanks for your comments.

1. Fixed. I've removed upper cases forcing.
2. Fixed.
3. Fixed. Add correct handle for {{null}} params; table name splitting is 
removed because JDBC docs doesn't contain any information about it and e.g. H2 
doesn't.
4-11. Fixed.


was (Author: tledkov-gridgain):
[~skalashnikov], thanks for your comments.

1. Fixed. I've removed upper cases forcing.
2. Fixed.
3. Fixed. Add correct handle for {{null}} params; table name splitting is 
removed because JDBC docs doesn't contain any information about it and e.g. H2 
doesn't.
4-11. Fixed.

> JDBC thin Driver: implement metadata support 
> -
>
> Key: IGNITE-5233
> URL: https://issues.apache.org/jira/browse/IGNITE-5233
> Project: Ignite
>  Issue Type: Task
>  Components: jdbc
>Affects Versions: 2.0
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
> Fix For: 2.2
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (IGNITE-5233) JDBC thin Driver: implement metadata support

2017-08-04 Thread Taras Ledkov (JIRA)

[ 
https://issues.apache.org/jira/browse/IGNITE-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114231#comment-16114231
 ] 

Taras Ledkov edited comment on IGNITE-5233 at 8/4/17 11:32 AM:
---

I've re-merged patch with master.
[~skalashnikov], [~al.psc] , please review the patch.


was (Author: tledkov-gridgain):
I've re-merged patch with master.
[~vozerov], please review the patch.

> JDBC thin Driver: implement metadata support 
> -
>
> Key: IGNITE-5233
> URL: https://issues.apache.org/jira/browse/IGNITE-5233
> Project: Ignite
>  Issue Type: Task
>  Components: jdbc
>Affects Versions: 2.0
>Reporter: Taras Ledkov
>Assignee: Taras Ledkov
> Fix For: 2.2
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)