[jira] [Commented] (IGNITE-10528) [ML] Fix incorrect comparing of double values in ML examples

2018-12-13 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720194#comment-16720194
 ] 

ASF GitHub Bot commented on IGNITE-10528:
-

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/5655


> [ML] Fix incorrect comparing of double values in ML examples
> 
>
> Key: IGNITE-10528
> URL: https://issues.apache.org/jira/browse/IGNITE-10528
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Affects Versions: 2.8
>Reporter: Aleksey Zinoviev
>Assignee: Aleksey Zinoviev
>Priority: Critical
> Fix For: 2.8
>
>
> Look at code row
> if (groundTruth != prediction)
> in each example
> Fix with Math.abs or Double.compare method (don't forget precision)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (IGNITE-10528) [ML] Fix incorrect comparing of double values in ML examples

2018-12-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719119#comment-16719119
 ] 

ASF GitHub Bot commented on IGNITE-10528:
-

GitHub user zaleslaw opened a pull request:

https://github.com/apache/ignite/pull/5655

IGNITE-10528: Fix incorrect comparing of double values in ML examples



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-10528

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/5655.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5655


commit 3e4c8002870a25501bfd8508cb9073d27b9af33d
Author: Zinoviev Alexey 
Date:   2018-12-12T15:50:25Z

IGNITE-10528: Fix incorrect comparing of double values in ML examples




> [ML] Fix incorrect comparing of double values in ML examples
> 
>
> Key: IGNITE-10528
> URL: https://issues.apache.org/jira/browse/IGNITE-10528
> Project: Ignite
>  Issue Type: Bug
>  Components: ml
>Affects Versions: 2.8
>Reporter: Aleksey Zinoviev
>Assignee: Aleksey Zinoviev
>Priority: Critical
> Fix For: 2.8
>
>
> Look at code row
> if (groundTruth != prediction)
> in each example
> Fix with Math.abs or Double.compare method (don't forget precision)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)