[jira] [Commented] (IGNITE-12412) Incomplete check for ABA problem in PageMemoryImpl#PagePool

2019-12-12 Thread Alexey Goncharuk (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994916#comment-16994916
 ] 

Alexey Goncharuk commented on IGNITE-12412:
---

Done, the visa is acquired on a separate refactoring + fix PR.

> Incomplete check for ABA problem in PageMemoryImpl#PagePool
> ---
>
> Key: IGNITE-12412
> URL: https://issues.apache.org/jira/browse/IGNITE-12412
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Critical
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In current implementation, {{PagePool#releasePage}} clears the counter part 
> of the returned page ID, which effectively disables the ABA check intended in 
> the class. This issue can be rarely reproduced on zOS during checkpoints 
> (when pages are being taken and returned to the checkpoint pages pool).
> I managed to write a unit-test to reproduce this issue on x86.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12412) Incomplete check for ABA problem in PageMemoryImpl#PagePool

2019-12-12 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994915#comment-16994915
 ] 

Ignite TC Bot commented on IGNITE-12412:


{panel:title=Branch: [pull/7098/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4826256&buildTypeId=IgniteTests24Java8_RunAll]

> Incomplete check for ABA problem in PageMemoryImpl#PagePool
> ---
>
> Key: IGNITE-12412
> URL: https://issues.apache.org/jira/browse/IGNITE-12412
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Critical
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In current implementation, {{PagePool#releasePage}} clears the counter part 
> of the returned page ID, which effectively disables the ABA check intended in 
> the class. This issue can be rarely reproduced on zOS during checkpoints 
> (when pages are being taken and returned to the checkpoint pages pool).
> I managed to write a unit-test to reproduce this issue on x86.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12412) Incomplete check for ABA problem in PageMemoryImpl#PagePool

2019-12-09 Thread Ivan Rakov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991821#comment-16991821
 ] 

Ivan Rakov commented on IGNITE-12412:
-

[~agoncharuk] Looks good.
Please split your patch into two commits (fix itself and refactoring) and merge 
them separately - it would simplify further fix porting.

> Incomplete check for ABA problem in PageMemoryImpl#PagePool
> ---
>
> Key: IGNITE-12412
> URL: https://issues.apache.org/jira/browse/IGNITE-12412
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Critical
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In current implementation, {{PagePool#releasePage}} clears the counter part 
> of the returned page ID, which effectively disables the ABA check intended in 
> the class. This issue can be rarely reproduced on zOS during checkpoints 
> (when pages are being taken and returned to the checkpoint pages pool).
> I managed to write a unit-test to reproduce this issue on x86.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12412) Incomplete check for ABA problem in PageMemoryImpl#PagePool

2019-12-09 Thread Andrey N. Gura (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991671#comment-16991671
 ] 

Andrey N. Gura commented on IGNITE-12412:
-

[~agoncharuk] Thanks! LGTM.

> Incomplete check for ABA problem in PageMemoryImpl#PagePool
> ---
>
> Key: IGNITE-12412
> URL: https://issues.apache.org/jira/browse/IGNITE-12412
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Critical
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In current implementation, {{PagePool#releasePage}} clears the counter part 
> of the returned page ID, which effectively disables the ABA check intended in 
> the class. This issue can be rarely reproduced on zOS during checkpoints 
> (when pages are being taken and returned to the checkpoint pages pool).
> I managed to write a unit-test to reproduce this issue on x86.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12412) Incomplete check for ABA problem in PageMemoryImpl#PagePool

2019-12-09 Thread Alexey Goncharuk (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991611#comment-16991611
 ] 

Alexey Goncharuk commented on IGNITE-12412:
---

[~agura] fixed (I changed the suggestion for nearest power of 2 though to fit 
the intended behavior).

> Incomplete check for ABA problem in PageMemoryImpl#PagePool
> ---
>
> Key: IGNITE-12412
> URL: https://issues.apache.org/jira/browse/IGNITE-12412
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Critical
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In current implementation, {{PagePool#releasePage}} clears the counter part 
> of the returned page ID, which effectively disables the ABA check intended in 
> the class. This issue can be rarely reproduced on zOS during checkpoints 
> (when pages are being taken and returned to the checkpoint pages pool).
> I managed to write a unit-test to reproduce this issue on x86.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12412) Incomplete check for ABA problem in PageMemoryImpl#PagePool

2019-12-04 Thread Andrey N. Gura (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987804#comment-16987804
 ] 

Andrey N. Gura commented on IGNITE-12412:
-

@[~agoncharuk] I left a few comments to the PR. Please, take a look.

> Incomplete check for ABA problem in PageMemoryImpl#PagePool
> ---
>
> Key: IGNITE-12412
> URL: https://issues.apache.org/jira/browse/IGNITE-12412
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Critical
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In current implementation, {{PagePool#releasePage}} clears the counter part 
> of the returned page ID, which effectively disables the ABA check intended in 
> the class. This issue can be rarely reproduced on zOS during checkpoints 
> (when pages are being taken and returned to the checkpoint pages pool).
> I managed to write a unit-test to reproduce this issue on x86.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12412) Incomplete check for ABA problem in PageMemoryImpl#PagePool

2019-12-04 Thread Alexey Goncharuk (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987683#comment-16987683
 ] 

Alexey Goncharuk commented on IGNITE-12412:
---

[~agura], please take a look as well.

> Incomplete check for ABA problem in PageMemoryImpl#PagePool
> ---
>
> Key: IGNITE-12412
> URL: https://issues.apache.org/jira/browse/IGNITE-12412
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Critical
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In current implementation, {{PagePool#releasePage}} clears the counter part 
> of the returned page ID, which effectively disables the ABA check intended in 
> the class. This issue can be rarely reproduced on zOS during checkpoints 
> (when pages are being taken and returned to the checkpoint pages pool).
> I managed to write a unit-test to reproduce this issue on x86.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12412) Incomplete check for ABA problem in PageMemoryImpl#PagePool

2019-12-03 Thread Ignite TC Bot (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987098#comment-16987098
 ] 

Ignite TC Bot commented on IGNITE-12412:


{panel:title=Branch: [pull/7098/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4808374&buildTypeId=IgniteTests24Java8_RunAll]

> Incomplete check for ABA problem in PageMemoryImpl#PagePool
> ---
>
> Key: IGNITE-12412
> URL: https://issues.apache.org/jira/browse/IGNITE-12412
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Critical
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In current implementation, {{PagePool#releasePage}} clears the counter part 
> of the returned page ID, which effectively disables the ABA check intended in 
> the class. This issue can be rarely reproduced on zOS during checkpoints 
> (when pages are being taken and returned to the checkpoint pages pool).
> I managed to write a unit-test to reproduce this issue on x86.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12412) Incomplete check for ABA problem in PageMemoryImpl#PagePool

2019-12-03 Thread Alexey Goncharuk (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986887#comment-16986887
 ] 

Alexey Goncharuk commented on IGNITE-12412:
---

[~akalashnikov] [~irakov] folks, I appreciate if you review this change as it 
introduces some refactoring to {{PageMemoryImpl}}

> Incomplete check for ABA problem in PageMemoryImpl#PagePool
> ---
>
> Key: IGNITE-12412
> URL: https://issues.apache.org/jira/browse/IGNITE-12412
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Critical
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In current implementation, {{PagePool#releasePage}} clears the counter part 
> of the returned page ID, which effectively disables the ABA check intended in 
> the class. This issue can be rarely reproduced on zOS during checkpoints 
> (when pages are being taken and returned to the checkpoint pages pool).
> I managed to write a unit-test to reproduce this issue on x86.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12412) Incomplete check for ABA problem in PageMemoryImpl#PagePool

2019-12-02 Thread Alexey Goncharuk (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986209#comment-16986209
 ] 

Alexey Goncharuk commented on IGNITE-12412:
---

The test alongside with a small refactoring required to create the test are in 
the attached PR.

> Incomplete check for ABA problem in PageMemoryImpl#PagePool
> ---
>
> Key: IGNITE-12412
> URL: https://issues.apache.org/jira/browse/IGNITE-12412
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Alexey Goncharuk
>Assignee: Alexey Goncharuk
>Priority: Critical
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In current implementation, {{PagePool#releasePage}} clears the counter part 
> of the returned page ID, which effectively disables the ABA check intended in 
> the class. This issue can be rarely reproduced on zOS during checkpoints 
> (when pages are being taken and returned to the checkpoint pages pool).
> I managed to write a unit-test to reproduce this issue on x86.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)