[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419743#comment-17419743 ] Pavel Pereslegin commented on IGNITE-12464: --- [~vladsz83], sorry, my mistake, getServiceProxy/GetDynamicServiceProxy returns a link to the platform service (not the .Net service itself), I didn't notice it. It seems to work fine. > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Nikolay Izhikov >Assignee: Vladimir Steshin >Priority: Minor > Labels: IEP-35 > Time Spent: 20.5h > Remaining Estimate: 0h > > We should provide the following metrics for each deployed service: > * -Count of executions- - this number seems useless, because, we can compute > it just by summing all histograms values. > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419309#comment-17419309 ] Pavel Pereslegin commented on IGNITE-12464: --- Hello Vladimir Steshin, as I can see - .Net service can still run locally without metrics, is this okay? (For example GetServiceProxy/GetDynamicServiceProxy in Services.cs can return service itself). If we don't plan to fully cover .Net services in this ticket, we need to create a separate one, and don't forget to describe limitations in the documentation. > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Nikolay Izhikov >Assignee: Vladimir Steshin >Priority: Minor > Labels: IEP-35 > Time Spent: 20.5h > Remaining Estimate: 0h > > We should provide the following metrics for each deployed service: > * -Count of executions- - this number seems useless, because, we can compute > it just by summing all histograms values. > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419299#comment-17419299 ] Pavel Pereslegin commented on IGNITE-12464: --- Hello [~vladsz83], what about .Net services? As I can see - .Net service can still run locally without metrics, is this okay? (For example GetServiceProxy/GetDynamicServiceProxy in Services.cs can return service itself). If we don't plan to fully cover .Net services in this ticket, we need to create a separate one, and don't forget to describe limitations in the documentation. > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Nikolay Izhikov >Assignee: Vladimir Steshin >Priority: Minor > Labels: IEP-35 > Time Spent: 20.5h > Remaining Estimate: 0h > > We should provide the following metrics for each deployed service: > * -Count of executions- - this number seems useless, because, we can compute > it just by summing all histograms values. > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[
https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412236#comment-17412236
]
Ignite TC Bot commented on IGNITE-12464:
{panel:title=Branch: [pull/7622/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/7622/head] Base: [master] : New Tests
(18)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Service Grid (legacy mode){color} [[tests
9|https://ci.ignite.apache.org/viewLog.html?buildId=6162292]]
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testMetricNaming - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testMultipleDeployment - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsMultyFew - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsSingle - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsMulty - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsMultyDuplicated - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsMultyFewDuplicated - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testMetricDeplotmentUndeployment - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsEnabledDisabled - PASSED{color}
{color:#8b}Service Grid{color} [[tests
9|https://ci.ignite.apache.org/viewLog.html?buildId=6162291]]
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testMetricNaming - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testMultipleDeployment - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsMultyFew - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsSingle - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsMulty - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsMultyDuplicated - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsMultyFewDuplicated - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testMetricDeplotmentUndeployment - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite:
GridServiceMetricsTest.testServiceMetricsEnabledDisabled - PASSED{color}
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6162307buildTypeId=IgniteTests24Java8_RunAll]
> Service metrics
> ---
>
> Key: IGNITE-12464
> URL: https://issues.apache.org/jira/browse/IGNITE-12464
> Project: Ignite
> Issue Type: Improvement
>Affects Versions: 2.8
>Reporter: Nikolay Izhikov
>Assignee: Vladimir Steshin
>Priority: Minor
> Labels: IEP-35
> Time Spent: 20.5h
> Remaining Estimate: 0h
>
> We should provide the following metrics for each deployed service:
> * -Count of executions- - this number seems useless, because, we can compute
> it just by summing all histograms values.
> * Histogram of executions duration
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409007#comment-17409007 ] Vladimir Steshin commented on IGNITE-12464: --- [~ivandasch], please review again. Master merged. Got some issues with your IGNITE-10100. > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Nikolay Izhikov >Assignee: Vladimir Steshin >Priority: Minor > Labels: IEP-35 > Time Spent: 20.5h > Remaining Estimate: 0h > > We should provide the following metrics for each deployed service: > * -Count of executions- - this number seems useless, because, we can compute > it just by summing all histograms values. > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271515#comment-17271515 ] Maxim Muzafarov commented on IGNITE-12464: -- Folks, any updates? > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Nikolay Izhikov >Assignee: Vladimir Steshin >Priority: Minor > Labels: IEP-35 > Fix For: 2.10 > > Time Spent: 20.5h > Remaining Estimate: 0h > > We should provide the following metrics for each deployed service: > * -Count of executions- - this number seems useless, because, we can compute > it just by summing all histograms values. > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17255863#comment-17255863 ] Maxim Muzafarov commented on IGNITE-12464: -- [~vladsz83], [~nizhikov] Hello folks, can we proceed with the merge? > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Nikolay Izhikov >Assignee: Vladimir Steshin >Priority: Minor > Labels: IEP-35 > Fix For: 2.10 > > Time Spent: 20.5h > Remaining Estimate: 0h > > We should provide the following metrics for each deployed service: > * -Count of executions- - this number seems useless, because, we can compute > it just by summing all histograms values. > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076282#comment-17076282 ] Ivan Daschinskiy commented on IGNITE-12464: --- [~vladsz83] Great job, your patch looks good for me. > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.8 >Reporter: Nikolay Izhikov >Assignee: Vladimir Steshin >Priority: Minor > Labels: IEP-35 > Time Spent: 20.5h > Remaining Estimate: 0h > > We should provide the following metrics for each deployed service: > * -Count of executions- - this number seems useless, because, we can compute > it just by summing all histograms values. > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[
https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076277#comment-17076277
]
Ignite TC Bot commented on IGNITE-12464:
{panel:title=Branch: [pull/7622/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=5195913buildTypeId=IgniteTests24Java8_RunAll]
> Service metrics
> ---
>
> Key: IGNITE-12464
> URL: https://issues.apache.org/jira/browse/IGNITE-12464
> Project: Ignite
> Issue Type: Improvement
>Affects Versions: 2.8
>Reporter: Nikolay Izhikov
>Assignee: Vladimir Steshin
>Priority: Minor
> Labels: IEP-35
> Time Spent: 20.5h
> Remaining Estimate: 0h
>
> We should provide the following metrics for each deployed service:
> * -Count of executions- - this number seems useless, because, we can compute
> it just by summing all histograms values.
> * Histogram of executions duration
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046748#comment-17046748 ] Andrey N. Gura commented on IGNITE-12464: - [~vladsz83] Thanks for clarification. > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7.6 >Reporter: Nikolay Izhikov >Assignee: Vladimir Steshin >Priority: Minor > Labels: IEP-35 > Time Spent: 3h > Remaining Estimate: 0h > > We should provide the following metrics for each deployed service: > * -Count of executions- - this number seems useless, because, we can compute > it just by summing all histograms values. > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046536#comment-17046536 ] Vladimir Steshin commented on IGNITE-12464: --- [~agura], several service instances share same metrics. Metrics is raised with single or first instance of a service, removed with undeploying of last service instance. > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7.6 >Reporter: Nikolay Izhikov >Assignee: Vladimir Steshin >Priority: Minor > Labels: IEP-35 > Time Spent: 1h 10m > Remaining Estimate: 0h > > We should provide the following metrics for each deployed service: > * -Count of executions- - this number seems useless, because, we can compute > it just by summing all histograms values. > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[
https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045725#comment-17045725
]
Andrey N. Gura commented on IGNITE-12464:
-
[~vladsz83] What about multiple instances of service per node? Is it supported?
See {{org.apache.ignite.IgniteServices#deployMultiple}} method for details.
> Service metrics
> ---
>
> Key: IGNITE-12464
> URL: https://issues.apache.org/jira/browse/IGNITE-12464
> Project: Ignite
> Issue Type: Improvement
>Affects Versions: 2.7.6
>Reporter: Nikolay Izhikov
>Assignee: Vladimir Steshin
>Priority: Minor
> Labels: IEP-35
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We should provide the following metrics for each deployed service:
> * -Count of executions- - this number seems useless, because, we can compute
> it just by summing all histograms values.
> * Histogram of executions duration
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042042#comment-17042042 ] Vladimir Steshin commented on IGNITE-12464: --- Major changes: 1) The services are now proxied with IgniteServiceProcessor#LocalInvocationHandler which measures service methods duration. 2) Service metrics are created for each interface method on service deployment, after init(), before execute(). 4) Fixed failed tests which used service class directly instead of its interface. > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7.6 >Reporter: Nikolay Izhikov >Assignee: Vladimir Steshin >Priority: Minor > Labels: IEP-35 > Time Spent: 1h > Remaining Estimate: 0h > > We should provide the following metrics for each deployed service: > * -Count of executions- - this number seems useless, because, we can compute > it just by summing all histograms values. > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014200#comment-17014200 ] Andrey N. Gura commented on IGNITE-12464: - [~nizhikov] It will not work after IGNITE-11927 because all metrics must be registered in metric registry before registration of metric registry. So item 2 in your solution should be joined with item 1 where metric will be created for each public method of service. > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7.6 >Reporter: Nikolay Izhikov >Priority: Minor > Labels: IEP-35 > > We should provide the following metrics for each deployed service: > * Count of executions > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002393#comment-17002393 ] Nikolay Izhikov commented on IGNITE-12464: -- [~agura] > Could you please describe the proposed solution? 1. Create a metric registry on service deployment. 2. Create required metrics on the first execution of service method. 3. Update metrics values on each execution of the service method. 4. Remove the metric registry on service undeployment. > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7.6 >Reporter: Nikolay Izhikov >Priority: Minor > Labels: IEP-35 > > We should provide the following metrics for each deployed service: > * Count of executions > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002389#comment-17002389 ] Andrey N. Gura commented on IGNITE-12464: - [~nizhikov] Ok. So it will require some additional mini framework that will solve the problem. Could you please describe proposed solution? > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7.6 >Reporter: Nikolay Izhikov >Priority: Minor > Labels: IEP-35 > > We should provide the following metrics for each deployed service: > * Count of executions > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002386#comment-17002386 ] Nikolay Izhikov commented on IGNITE-12464: -- [~agura] execution == each service method invocation. The metric name should contains a service method name, obviously. > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7.6 >Reporter: Nikolay Izhikov >Priority: Minor > Labels: IEP-35 > > We should provide the following metrics for each deployed service: > * Count of executions > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-12464) Service metrics
[ https://issues.apache.org/jira/browse/IGNITE-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002376#comment-17002376 ] Andrey N. Gura commented on IGNITE-12464: - [~nizhikov] Could you please clarify what does it mean "execution" in service context? > Service metrics > --- > > Key: IGNITE-12464 > URL: https://issues.apache.org/jira/browse/IGNITE-12464 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7.6 >Reporter: Nikolay Izhikov >Priority: Minor > Labels: IEP-35 > > We should provide the following metrics for each deployed service: > * Count of executions > * Histogram of executions duration -- This message was sent by Atlassian Jira (v8.3.4#803005)
