[jira] [Commented] (IGNITE-25119) .NET: Decimal value scale overflow on representable values
[
https://issues.apache.org/jira/browse/IGNITE-25119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18108918#comment-18108918
]
Ignite TC Bot commented on IGNITE-25119:
I reviewed implementation PR #12102 and commit 4e6a6c54ca in the local Ignite 2
checkout. This is a .NET binary serialization bug fix for decimal values with
negative scale and does not add a new .NET API, configuration option, or
user-facing documentation surface. I removed only Docs Required and preserved
Release Notes Required.
> .NET: Decimal value scale overflow on representable values
> --
>
> Key: IGNITE-25119
> URL: https://issues.apache.org/jira/browse/IGNITE-25119
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.17
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Major
> Labels: .NET
> Fix For: 2.18
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> BigDecimal values like "7.3770697413E+11" or "1E+1", when inserted from Java
> and read from .NET, result in an exception:
> {code}
> Decimal value scale overflow (must be between 0 and 28): -1
> {code}
> There is even a test for that in *TestEchoDecimal*.
> Those values can be represented in .NET (as 737706974130 and 10,
> respectively), we should not throw exceptions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (IGNITE-25119) .NET: Decimal value scale overflow on representable values
[
https://issues.apache.org/jira/browse/IGNITE-25119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954526#comment-17954526
]
Pavel Tupitsyn commented on IGNITE-25119:
-
Merged to master:
https://github.com/apache/ignite/commit/4e6a6c54ca98a94024cb934c8d30f42844704219
> .NET: Decimal value scale overflow on representable values
> --
>
> Key: IGNITE-25119
> URL: https://issues.apache.org/jira/browse/IGNITE-25119
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.17
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Major
> Labels: .NET
> Fix For: 2.18
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> BigDecimal values like "7.3770697413E+11" or "1E+1", when inserted from Java
> and read from .NET, result in an exception:
> {code}
> Decimal value scale overflow (must be between 0 and 28): -1
> {code}
> There is even a test for that in *TestEchoDecimal*.
> Those values can be represented in .NET (as 737706974130 and 10,
> respectively), we should not throw exceptions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (IGNITE-25119) .NET: Decimal value scale overflow on representable values
[
https://issues.apache.org/jira/browse/IGNITE-25119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954522#comment-17954522
]
Igor Sapego commented on IGNITE-25119:
--
Looks good to me.
> .NET: Decimal value scale overflow on representable values
> --
>
> Key: IGNITE-25119
> URL: https://issues.apache.org/jira/browse/IGNITE-25119
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.17
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Major
> Labels: .NET
> Fix For: 2.18
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> BigDecimal values like "7.3770697413E+11" or "1E+1", when inserted from Java
> and read from .NET, result in an exception:
> {code}
> Decimal value scale overflow (must be between 0 and 28): -1
> {code}
> There is even a test for that in *TestEchoDecimal*.
> Those values can be represented in .NET (as 737706974130 and 10,
> respectively), we should not throw exceptions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (IGNITE-25119) .NET: Decimal value scale overflow on representable values
[
https://issues.apache.org/jira/browse/IGNITE-25119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954492#comment-17954492
]
Ignite TC Bot commented on IGNITE-25119:
{panel:title=Branch: [pull/12102/head] Base: [master] : Possible Blockers
(2)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}[Check Code Style Ducktests]{color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=9173315]]
{color:#d04437}Platform C++ CMake (Win x64 / Release){color} [[tests 0 Exit
Code |https://ci.ignite.apache.org/viewLog.html?buildId=9173317]]
{panel}
{panel:title=Branch: [pull/12102/head] Base: [master] : New Tests
(8)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Platform .NET (Core Linux){color} [[tests
4|https://ci.ignite.apache.org/viewLog.html?buildId=9171954]]
* {color:#013220}DotNetCore:
ComputeApiTest.TestEchoDecimalNegativeScaleOverflow - PASSED{color}
* {color:#013220}DotNetCore:
ComputeApiTestFullFooter.TestEchoDecimalNegativeScale - PASSED{color}
* {color:#013220}DotNetCore:
ComputeApiTestFullFooter.TestEchoDecimalNegativeScaleOverflow - PASSED{color}
* {color:#013220}DotNetCore: ComputeApiTest.TestEchoDecimalNegativeScale -
PASSED{color}
{color:#8b}Platform .NET (Windows){color} [[tests
4|https://ci.ignite.apache.org/viewLog.html?buildId=9171955]]
* {color:#013220}exe: ComputeApiTestFullFooter.TestEchoDecimalNegativeScale -
PASSED{color}
* {color:#013220}exe: ComputeApiTest.TestEchoDecimalNegativeScaleOverflow -
PASSED{color}
* {color:#013220}exe:
ComputeApiTestFullFooter.TestEchoDecimalNegativeScaleOverflow - PASSED{color}
* {color:#013220}exe: ComputeApiTest.TestEchoDecimalNegativeScale -
PASSED{color}
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=9171997&buildTypeId=IgniteTests24Java8_RunAll]
> .NET: Decimal value scale overflow on representable values
> --
>
> Key: IGNITE-25119
> URL: https://issues.apache.org/jira/browse/IGNITE-25119
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.17
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Major
> Labels: .NET
> Fix For: 2.18
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> BigDecimal values like "7.3770697413E+11" or "1E+1", when inserted from Java
> and read from .NET, result in an exception:
> {code}
> Decimal value scale overflow (must be between 0 and 28): -1
> {code}
> There is even a test for that in *TestEchoDecimal*.
> Those values can be represented in .NET (as 737706974130 and 10,
> respectively), we should not throw exceptions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (IGNITE-25119) .NET: Decimal value scale overflow on representable values
[
https://issues.apache.org/jira/browse/IGNITE-25119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954388#comment-17954388
]
Ignite TC Bot commented on IGNITE-25119:
{panel:title=Branch: [pull/12102/head] Base: [master] : Possible Blockers
(8)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}[Check Code Style Ducktests]{color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=9171913]]
{color:#d04437}Platform C++ CMake (Win x64 / Release){color} [[tests 0 Exit
Code |https://ci.ignite.apache.org/viewLog.html?buildId=9171951]]
{color:#d04437}Disk Page Compressions 2{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=9171985]]
{color:#d04437}PDS 2{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=9171941]]
{color:#d04437}Cache (Failover) 2{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=9171903]]
* IgniteCacheFailoverTestSuite2:
GridCacheReplicatedFailoverSelfTest.testPessimisticRepeatableReadTxTopologyChange
- Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}Control Utility 1{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=9171922]]
* IgniteControlUtilityTestSuite:
GridCommandHandlerIndexingWithSSLTest.testValidateIndexesFailedOnNotIdleCluster[cmdHnd=cli]
- Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}Snapshots With Indexes{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=9171968]]
* IgniteSnapshotWithIndexingTestSuite:
IgniteClusterSnapshotMetricsTest.testCreateSnapshotProgress[encryption=true,
onlyPrimay=true] - Test has low fail rate in base branch 0,0% and is not flaky
* IgniteSnapshotWithIndexingTestSuite:
IgniteClusterSnapshotMetricsTest.testCreateSnapshotProgress[encryption=false,
onlyPrimay=false] - Test has low fail rate in base branch 0,0% and is not flaky
{panel}
{panel:title=Branch: [pull/12102/head] Base: [master] : New Tests
(8)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#8b}Platform .NET (Core Linux){color} [[tests
4|https://ci.ignite.apache.org/viewLog.html?buildId=9171954]]
* {color:#013220}DotNetCore:
ComputeApiTest.TestEchoDecimalNegativeScaleOverflow - PASSED{color}
* {color:#013220}DotNetCore:
ComputeApiTestFullFooter.TestEchoDecimalNegativeScale - PASSED{color}
* {color:#013220}DotNetCore:
ComputeApiTestFullFooter.TestEchoDecimalNegativeScaleOverflow - PASSED{color}
* {color:#013220}DotNetCore: ComputeApiTest.TestEchoDecimalNegativeScale -
PASSED{color}
{color:#8b}Platform .NET (Windows){color} [[tests
4|https://ci.ignite.apache.org/viewLog.html?buildId=9171955]]
* {color:#013220}exe: ComputeApiTestFullFooter.TestEchoDecimalNegativeScale -
PASSED{color}
* {color:#013220}exe: ComputeApiTest.TestEchoDecimalNegativeScaleOverflow -
PASSED{color}
* {color:#013220}exe:
ComputeApiTestFullFooter.TestEchoDecimalNegativeScaleOverflow - PASSED{color}
* {color:#013220}exe: ComputeApiTest.TestEchoDecimalNegativeScale -
PASSED{color}
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=9171997&buildTypeId=IgniteTests24Java8_RunAll]
> .NET: Decimal value scale overflow on representable values
> --
>
> Key: IGNITE-25119
> URL: https://issues.apache.org/jira/browse/IGNITE-25119
> Project: Ignite
> Issue Type: Bug
> Components: platforms
>Affects Versions: 2.17
>Reporter: Pavel Tupitsyn
>Assignee: Pavel Tupitsyn
>Priority: Major
> Labels: .NET
> Fix For: 2.18
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> BigDecimal values like "7.3770697413E+11" or "1E+1", when inserted from Java
> and read from .NET, result in an exception:
> {code}
> Decimal value scale overflow (must be between 0 and 28): -1
> {code}
> There is even a test for that in *TestEchoDecimal*.
> Those values can be represented in .NET (as 737706974130 and 10,
> respectively), we should not throw exceptions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
