[jira] [Commented] (IGNITE-2698) CacheKeyConfiguration is used only with BinaryMarshaller
[ https://issues.apache.org/jira/browse/IGNITE-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504417#comment-16504417 ] Alexey Goncharuk commented on IGNITE-2698: -- The PR has multiple conflicts, need to resolve them before further review. > CacheKeyConfiguration is used only with BinaryMarshaller > > > Key: IGNITE-2698 > URL: https://issues.apache.org/jira/browse/IGNITE-2698 > Project: Ignite > Issue Type: Bug > Components: cache >Reporter: Semen Boikov >Priority: Major > > Now if CacheKeyConfiguration is specified it is used only with > BinaryMarshaller. Need to take it into account with others marshallers as > well or update documentation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-2698) CacheKeyConfiguration is used only with BinaryMarshaller
[ https://issues.apache.org/jira/browse/IGNITE-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584665#comment-15584665 ] Andrey Martianov commented on IGNITE-2698: -- Hi [~sboikov], Thanks for your comments, I agree with you. I addressed it and updated pull-request. TC is ok, please review. Thanks > CacheKeyConfiguration is used only with BinaryMarshaller > > > Key: IGNITE-2698 > URL: https://issues.apache.org/jira/browse/IGNITE-2698 > Project: Ignite > Issue Type: Bug > Components: cache >Reporter: Semen Boikov >Assignee: Andrey Martianov > Fix For: 1.8 > > > Now if CacheKeyConfiguration is specified it is used only with > BinaryMarshaller. Need to take it into account with others marshallers as > well or update documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2698) CacheKeyConfiguration is used only with BinaryMarshaller
[ https://issues.apache.org/jira/browse/IGNITE-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512946#comment-15512946 ] Andrey Martianov commented on IGNITE-2698: -- I ran tests on TC - everything seems ok. Please review > CacheKeyConfiguration is used only with BinaryMarshaller > > > Key: IGNITE-2698 > URL: https://issues.apache.org/jira/browse/IGNITE-2698 > Project: Ignite > Issue Type: Bug > Components: cache >Reporter: Semen Boikov >Assignee: Andrey Martianov > Fix For: 1.8 > > > Now if CacheKeyConfiguration is specified it is used only with > BinaryMarshaller. Need to take it into account with others marshallers as > well or update documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2698) CacheKeyConfiguration is used only with BinaryMarshaller
[ https://issues.apache.org/jira/browse/IGNITE-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509786#comment-15509786 ] Andrey Martianov commented on IGNITE-2698: -- I made following changes: 1. Added processing of CacheKeyConfiguration when Jdk/Optimized marshallers are used. 2. Added check at node startup (if Jdk/Optimized marshallers are used) that local cache key configurations are in accordance with remote cache key configurations. 3. Fixed bug: BinaryMarshaller doesn't use CacheKeyConfiguration for classes those aren't explicitly defined in BinaryConfiguration (using BinaryTypeConfiguration). > CacheKeyConfiguration is used only with BinaryMarshaller > > > Key: IGNITE-2698 > URL: https://issues.apache.org/jira/browse/IGNITE-2698 > Project: Ignite > Issue Type: Bug > Components: cache >Reporter: Semen Boikov >Assignee: Andrey Martianov > Fix For: 1.8 > > > Now if CacheKeyConfiguration is specified it is used only with > BinaryMarshaller. Need to take it into account with others marshallers as > well or update documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2698) CacheKeyConfiguration is used only with BinaryMarshaller
[ https://issues.apache.org/jira/browse/IGNITE-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509736#comment-15509736 ] ASF GitHub Bot commented on IGNITE-2698: GitHub user amartianov opened a pull request: https://github.com/apache/ignite/pull/1096 IGNITE-2698: Using CacheKeyConfiguration with Jdk/Optimized marshallers + tests on CacheKeyConfigurations. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-2698 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/1096.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1096 commit 2d12b6b301266133634583c7fb313d6df3b5fb23 Author: Andrey Martianov Date: 2016-09-21T12:08:46Z IGNITE-2698: Using CacheKeyConfiguration with Jdk/Optimized marshallers > CacheKeyConfiguration is used only with BinaryMarshaller > > > Key: IGNITE-2698 > URL: https://issues.apache.org/jira/browse/IGNITE-2698 > Project: Ignite > Issue Type: Bug > Components: cache >Reporter: Semen Boikov >Assignee: Andrey Martianov > Fix For: 1.8 > > > Now if CacheKeyConfiguration is specified it is used only with > BinaryMarshaller. Need to take it into account with others marshallers as > well or update documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2698) CacheKeyConfiguration is used only with BinaryMarshaller
[ https://issues.apache.org/jira/browse/IGNITE-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506971#comment-15506971 ] Andrey Martianov commented on IGNITE-2698: -- Found out root cause. Working on fix. > CacheKeyConfiguration is used only with BinaryMarshaller > > > Key: IGNITE-2698 > URL: https://issues.apache.org/jira/browse/IGNITE-2698 > Project: Ignite > Issue Type: Bug > Components: cache >Reporter: Semen Boikov >Assignee: Andrey Martianov > Fix For: 1.8 > > > Now if CacheKeyConfiguration is specified it is used only with > BinaryMarshaller. Need to take it into account with others marshallers as > well or update documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2698) CacheKeyConfiguration is used only with BinaryMarshaller
[ https://issues.apache.org/jira/browse/IGNITE-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155499#comment-15155499 ] Semen Boikov commented on IGNITE-2698: -- One more note: there are not tests for CacheKeyConfiguration(Class keyCls). Also need to add validation that typeName and affKeyFieldName are not null. > CacheKeyConfiguration is used only with BinaryMarshaller > > > Key: IGNITE-2698 > URL: https://issues.apache.org/jira/browse/IGNITE-2698 > Project: Ignite > Issue Type: Bug > Components: cache >Reporter: Semen Boikov >Assignee: Yakov Zhdanov > Fix For: 1.6 > > > Now if CacheKeyConfiguration is specified it is used only with > BinaryMarshaller. Need to take it into account with others marshallers as > well or update documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)