[jira] [Commented] (IGNITE-3699) CreatedExpiryPolicy doesn't work if entry is loaded from store

[Semen Boikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834221#comment-15834221
 ] 

Semen Boikov commented on IGNITE-3699:
--

Hi Anton,

I reviewed your changes, look good. One minor comment: in test please restore 
case when 'get' is called outside of explicit transaction.

Thanks!

> CreatedExpiryPolicy doesn't work if entry is loaded from store
> --
>
> Key: IGNITE-3699
> URL: https://issues.apache.org/jira/browse/IGNITE-3699
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
>Priority: Critical
> Fix For: 2.0
>
> Attachments: LoadWithExpiryTest.java
>
>
> According to JCache spec, {{ExpiryPolicy.getExpiryForCreation()}} must be 
> triggered on {{get()}} operation if the entry is loaded from the store. 
> Currently this is not happening.
> Test reproducing the issue is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3699) CreatedExpiryPolicy doesn't work if entry is loaded from store

[Anton Vinogradov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820613#comment-15820613
 ] 

Anton Vinogradov commented on IGNITE-3699:
--

Amir, 
since this issue is critical, I'm going to fix the rest of the issues.
Currently I'm already have most of these fixes done and going to merge them in 
nearest days.
Please let me know in case you're already work on these fixes. I will be a good 
case to check both implementations before merge.

> CreatedExpiryPolicy doesn't work if entry is loaded from store
> --
>
> Key: IGNITE-3699
> URL: https://issues.apache.org/jira/browse/IGNITE-3699
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Anton Vinogradov
>Priority: Critical
> Fix For: 2.0
>
> Attachments: LoadWithExpiryTest.java
>
>
> According to JCache spec, {{ExpiryPolicy.getExpiryForCreation()}} must be 
> triggered on {{get()}} operation if the entry is loaded from the store. 
> Currently this is not happening.
> Test reproducing the issue is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3699) CreatedExpiryPolicy doesn't work if entry is loaded from store

[Amir Akhmedov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703061#comment-15703061
 ] 

Amir Akhmedov commented on IGNITE-3699:
---

Hi Semen,

I update PR with corresponding changes:

1. Switched JDK to version 7 and ran TeamCity tests. Some of them are failing 
but from test's history I see that they also failing on master

2. Now {{getAllAsync0}} calculates the ttl and passes it to {{versionedValue}}

3. The change in GridDhtTxPrepareFuture was done to fix IGNITE-821. But I 
realized that it's not correct fix and I reverted back the changes.

Please let me know if you any comments

Thanks.

> CreatedExpiryPolicy doesn't work if entry is loaded from store
> --
>
> Key: IGNITE-3699
> URL: https://issues.apache.org/jira/browse/IGNITE-3699
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Amir Akhmedov
>Priority: Critical
> Fix For: 2.0
>
> Attachments: LoadWithExpiryTest.java
>
>
> According to JCache spec, {{ExpiryPolicy.getExpiryForCreation()}} must be 
> triggered on {{get()}} operation if the entry is loaded from the store. 
> Currently this is not happening.
> Test reproducing the issue is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3699) CreatedExpiryPolicy doesn't work if entry is loaded from store

[Hagmonk (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592530#comment-15592530
 ] 

Hagmonk commented on IGNITE-3699:
-

What's the update on this issue? Will it be integrated into Ignite 1.8.0? I'd 
like to stop maintaining my own Ignite branch :)

> CreatedExpiryPolicy doesn't work if entry is loaded from store
> --
>
> Key: IGNITE-3699
> URL: https://issues.apache.org/jira/browse/IGNITE-3699
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Amir Akhmedov
> Fix For: 1.8
>
> Attachments: LoadWithExpiryTest.java
>
>
> According to JCache spec, {{ExpiryPolicy.getExpiryForCreation()}} must be 
> triggered on {{get()}} operation if the entry is loaded from the store. 
> Currently this is not happening.
> Test reproducing the issue is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3699) CreatedExpiryPolicy doesn't work if entry is loaded from store

[Hagmonk (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510991#comment-15510991
 ] 

Hagmonk commented on IGNITE-3699:
-

I came here and created a JIRA account just to say that this patch applies 
cleanly, and resolves the issue for me. It was going to be a serious problem if 
my CacheStore backed cache could not be managed with an expiry policy! I tested 
the patch using a CreatedExpiryPolicy and ModifiedExpiryPolicy. I applied the 
patch against bcbe8cc4492449957ff983976f8f16e090c0b239.

> CreatedExpiryPolicy doesn't work if entry is loaded from store
> --
>
> Key: IGNITE-3699
> URL: https://issues.apache.org/jira/browse/IGNITE-3699
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Valentin Kulichenko
> Fix For: 1.8
>
> Attachments: LoadWithExpiryTest.java
>
>
> According to JCache spec, {{ExpiryPolicy.getExpiryForCreation()}} must be 
> triggered on {{get()}} operation if the entry is loaded from the store. 
> Currently this is not happening.
> Test reproducing the issue is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3699) CreatedExpiryPolicy doesn't work if entry is loaded from store

[Amir Akhmedov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15466316#comment-15466316
 ] 

Amir Akhmedov commented on IGNITE-3699:
---

[~vkulichenko], I updated PR. Reverted back tests for {{invoke}} and fixed ttl 
calculation for {{Transactional}} cache. Can you please review it and let me 
know. Thanks.

> CreatedExpiryPolicy doesn't work if entry is loaded from store
> --
>
> Key: IGNITE-3699
> URL: https://issues.apache.org/jira/browse/IGNITE-3699
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Amir Akhmedov
> Fix For: 1.8
>
> Attachments: LoadWithExpiryTest.java
>
>
> According to JCache spec, {{ExpiryPolicy.getExpiryForCreation()}} must be 
> triggered on {{get()}} operation if the entry is loaded from the store. 
> Currently this is not happening.
> Test reproducing the issue is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3699) CreatedExpiryPolicy doesn't work if entry is loaded from store

[Amir Akhmedov (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457320#comment-15457320
 ] 

Amir Akhmedov commented on IGNITE-3699:
---

[~vkulichenko], thank you for your comments.
1. Totally agree with you, will update the PR for this case.
2. In case of Atomic cache {code}GridCacheAdapter.getAllAsync0{code} is called. 
In this method if cache does not have a specified key it loads the value from 
store and creates a cache entry for the key-value pair. At this place I'm 
setting the TTL for this cache entry.

> CreatedExpiryPolicy doesn't work if entry is loaded from store
> --
>
> Key: IGNITE-3699
> URL: https://issues.apache.org/jira/browse/IGNITE-3699
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Amir Akhmedov
> Fix For: 1.8
>
> Attachments: LoadWithExpiryTest.java
>
>
> According to JCache spec, {{ExpiryPolicy.getExpiryForCreation()}} must be 
> triggered on {{get()}} operation if the entry is loaded from the store. 
> Currently this is not happening.
> Test reproducing the issue is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (IGNITE-3699) CreatedExpiryPolicy doesn't work if entry is loaded from store

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/IGNITE-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450772#comment-15450772
 ] 

ASF GitHub Bot commented on IGNITE-3699:


GitHub user amirakhmedov opened a pull request:

https://github.com/apache/ignite/pull/1011

`IGNITE-3699: CreatedExpiryPolicy doesn't work if entry is loaded from…

… store

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/amirakhmedov/ignite IGNITE-3699

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1011.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1011


commit 431bdb068604f1809573bb6526fbdfb09af01cdd
Author: Amir Akhmedov 
Date:   2016-08-31T01:37:44Z

IGNITE-3699: CreatedExpiryPolicy doesn't work if entry is loaded from store




> CreatedExpiryPolicy doesn't work if entry is loaded from store
> --
>
> Key: IGNITE-3699
> URL: https://issues.apache.org/jira/browse/IGNITE-3699
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 1.7
>Reporter: Valentin Kulichenko
>Assignee: Amir Akhmedov
> Fix For: 1.8
>
> Attachments: LoadWithExpiryTest.java
>
>
> According to JCache spec, {{ExpiryPolicy.getExpiryForCreation()}} must be 
> triggered on {{get()}} operation if the entry is loaded from the store. 
> Currently this is not happening.
> Test reproducing the issue is attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)