[jira] [Commented] (IGNITE-5912) [Redis] EXPIRE/PEXPIRE on keys

2017-08-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120898#comment-16120898
 ] 

ASF GitHub Bot commented on IGNITE-5912:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2383


> [Redis] EXPIRE/PEXPIRE on keys
> --
>
> Key: IGNITE-5912
> URL: https://issues.apache.org/jira/browse/IGNITE-5912
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/expire
> https://redis.io/commands/pexpire



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5912) [Redis] EXPIRE/PEXPIRE on keys

2017-08-07 Thread Andrey Novikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116345#comment-16116345
 ] 

Andrey Novikov commented on IGNITE-5912:


It's ok for me, please check tests on CI server.

> [Redis] EXPIRE/PEXPIRE on keys
> --
>
> Key: IGNITE-5912
> URL: https://issues.apache.org/jira/browse/IGNITE-5912
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/expire
> https://redis.io/commands/pexpire



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5912) [Redis] EXPIRE/PEXPIRE on keys

2017-08-07 Thread Roman Shtykh (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116292#comment-16116292
 ] 

Roman Shtykh commented on IGNITE-5912:
--

Hi [~anovikov],

I missed `KEY_REQUIRED_REQUESTS`. Thanks for pointing! How about it now?

> [Redis] EXPIRE/PEXPIRE on keys
> --
>
> Key: IGNITE-5912
> URL: https://issues.apache.org/jira/browse/IGNITE-5912
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/expire
> https://redis.io/commands/pexpire



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5912) [Redis] EXPIRE/PEXPIRE on keys

2017-08-06 Thread Andrey Novikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115808#comment-16115808
 ] 

Andrey Novikov commented on IGNITE-5912:


Oh, I get it you use common variable and for some commands, ttl is optional 
parameter.

You need check if ttl exist before execute command, and add CACHE_UPDATE_TLL to 
KEY_REQUIRED_REQUESTS.

{code}
case CACHE_UPDATE_TLL: 

if (ttl == null)
  throw new 
IgniteCheckedException(GridRestCommandHandlerAdapter.missingParameter("ttl"));

fut = executeCommand(req.destinationId(), req.clientId(), cacheName, key, new 
UpdateTllCommand(key, ttl));
{code}

> [Redis] EXPIRE/PEXPIRE on keys
> --
>
> Key: IGNITE-5912
> URL: https://issues.apache.org/jira/browse/IGNITE-5912
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/expire
> https://redis.io/commands/pexpire



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5912) [Redis] EXPIRE/PEXPIRE on keys

2017-08-04 Thread Roman Shtykh (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114346#comment-16114346
 ] 

Roman Shtykh commented on IGNITE-5912:
--

Hi [~anovikov],

Thanks for checking the pr.
Modified as you pointed out. Many thanks!

The only thing I have a question about is why `ExpireCommand.ttl` should be 
`long`? As I see all other commands have `ttl` as `Long`.

> [Redis] EXPIRE/PEXPIRE on keys
> --
>
> Key: IGNITE-5912
> URL: https://issues.apache.org/jira/browse/IGNITE-5912
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/expire
> https://redis.io/commands/pexpire



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5912) [Redis] EXPIRE/PEXPIRE on keys

2017-08-04 Thread Andrey Novikov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114229#comment-16114229
 ] 

Andrey Novikov commented on IGNITE-5912:


Hi [~roman_s],

I reviewed your pull request and found following:
* I think CACHE_UPDATE_TTL will be better than CACHE_EXPIRE
* Need throw exception if command have wrong arguments count (missing: key, ttl)
* ExpireCommand.ttl should be {{long}}

> [Redis] EXPIRE/PEXPIRE on keys
> --
>
> Key: IGNITE-5912
> URL: https://issues.apache.org/jira/browse/IGNITE-5912
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/expire
> https://redis.io/commands/pexpire



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-5912) [Redis] EXPIRE/PEXPIRE on keys

2017-08-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112382#comment-16112382
 ] 

ASF GitHub Bot commented on IGNITE-5912:


GitHub user shroman opened a pull request:

https://github.com/apache/ignite/pull/2383

IGNITE-5912: Redis EXPIRE/PEXPIRE commands.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shroman/ignite IGNITE-5912

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2383


commit 696c1613d41c741a66241da6214559f2f5dd1494
Author: shroman 
Date:   2017-08-03T07:59:50Z

IGNITE-5912: Redis EXPIRE/PEXPIRE commands.

commit 0c86dc18d55749df6e1d2282a2edd222c0330833
Author: shroman 
Date:   2017-08-03T08:08:18Z

IGNITE-5912: Redis EXPIRE/PEXPIRE commands. Replaced lambdas with anonymous 
classes for Java 7.




> [Redis] EXPIRE/PEXPIRE on keys
> --
>
> Key: IGNITE-5912
> URL: https://issues.apache.org/jira/browse/IGNITE-5912
> Project: Ignite
>  Issue Type: New Feature
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> https://redis.io/commands/expire
> https://redis.io/commands/pexpire



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)