[jira] [Commented] (IGNITE-6552) The ability to set WAL history size in time units
[ https://issues.apache.org/jira/browse/IGNITE-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511157#comment-16511157 ] Anton Kalashnikov commented on IGNITE-6552: --- UP - [https://reviews.ignite.apache.org/ignite/review/IGNT-CR-503] > The ability to set WAL history size in time units > - > > Key: IGNITE-6552 > URL: https://issues.apache.org/jira/browse/IGNITE-6552 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 2.2 >Reporter: Vladislav Pyatkov >Assignee: Anton Kalashnikov >Priority: Major > Fix For: 2.6 > > > We can to set size of WAL history in number of checkpoints. > {code} > org.apache.ignite.configuration.PersistentStoreConfiguration#setWalHistorySize > {code} > But it is not convenient fro end user. Nobody to say how many checkpoint to > occur over several minutes. > I think, it will be better if we will have ability to set WAL history size in > time units (milliseconds for example). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6552) The ability to set WAL history size in time units
[ https://issues.apache.org/jira/browse/IGNITE-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407694#comment-16407694 ] Anton Kalashnikov commented on IGNITE-6552: --- TC - https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&branch_IgniteTests24Java8=pull%2F3559%2Fhead > The ability to set WAL history size in time units > - > > Key: IGNITE-6552 > URL: https://issues.apache.org/jira/browse/IGNITE-6552 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 2.2 >Reporter: Vladislav Pyatkov >Assignee: Anton Kalashnikov >Priority: Major > Fix For: 2.5 > > > We can to set size of WAL history in number of checkpoints. > {code} > org.apache.ignite.configuration.PersistentStoreConfiguration#setWalHistorySize > {code} > But it is not convenient fro end user. Nobody to say how many checkpoint to > occur over several minutes. > I think, it will be better if we will have ability to set WAL history size in > time units (milliseconds for example). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6552) The ability to set WAL history size in time units
[ https://issues.apache.org/jira/browse/IGNITE-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372777#comment-16372777 ] ASF GitHub Bot commented on IGNITE-6552: GitHub user akalash opened a pull request: https://github.com/apache/ignite/pull/3559 IGNITE-6552 ability to set WAL history size in MBytes You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6552 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3559.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3559 commit 10a7221392d00caa25f99f7f1aa33408c085e759 Author: Anton Kalashnikov Date: 2018-02-22T11:57:38Z IGNITE-6552 ability to set WAL history size in MBytes commit 1bf01c091e064bc48fe49a3b750e1c47e68fbc4a Author: Anton Kalashnikov Date: 2018-02-22T13:00:59Z IGNITE-6552 change FileDescriptor header > The ability to set WAL history size in time units > - > > Key: IGNITE-6552 > URL: https://issues.apache.org/jira/browse/IGNITE-6552 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 2.2 >Reporter: Vladislav Pyatkov >Assignee: Anton Kalashnikov >Priority: Major > Fix For: 2.5 > > > We can to set size of WAL history in number of checkpoints. > {code} > org.apache.ignite.configuration.PersistentStoreConfiguration#setWalHistorySize > {code} > But it is not convenient fro end user. Nobody to say how many checkpoint to > occur over several minutes. > I think, it will be better if we will have ability to set WAL history size in > time units (milliseconds for example). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6552) The ability to set WAL history size in time units
[ https://issues.apache.org/jira/browse/IGNITE-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355640#comment-16355640 ] Alexey Goncharuk commented on IGNITE-6552: -- Alternatively, we may have an ability to set WAL history size in Gbytes. When we are too close to the WAL limit, we should trigger another checkpoint. > The ability to set WAL history size in time units > - > > Key: IGNITE-6552 > URL: https://issues.apache.org/jira/browse/IGNITE-6552 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 2.2 >Reporter: Vladislav Pyatkov >Priority: Major > > We can to set size of WAL history in number of checkpoints. > {code} > org.apache.ignite.configuration.PersistentStoreConfiguration#setWalHistorySize > {code} > But it is not convenient fro end user. Nobody to say how many checkpoint to > occur over several minutes. > I think, it will be better if we will have ability to set WAL history size in > time units (milliseconds for example). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-6552) The ability to set WAL history size in time units
[ https://issues.apache.org/jira/browse/IGNITE-6552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189836#comment-16189836 ] Dmitriy Pavlov commented on IGNITE-6552: In corner case we need to keep at least 1 finished checkpoint (we dont' count incompleted). For more info please see https://cwiki.apache.org/confluence/display/IGNITE/Ignite+Persistent+Store+-+under+the+hood#IgnitePersistentStore-underthehood-WALhistorysize We can't keep less than 1 completed CP, because we will not be able to restore. We should avoid applying timeout if we remove latest completed checkpoint. > The ability to set WAL history size in time units > - > > Key: IGNITE-6552 > URL: https://issues.apache.org/jira/browse/IGNITE-6552 > Project: Ignite > Issue Type: Improvement > Components: persistence >Affects Versions: 2.2 >Reporter: Vladislav Pyatkov > > We can to set size of WAL history in number of checkpoints. > {code} > org.apache.ignite.configuration.PersistentStoreConfiguration#setWalHistorySize > {code} > But it is not convenient fro end user. Nobody to say how many checkpoint to > occur over several minutes. > I think, it will be better if we will have ability to set WAL history size in > time units (milliseconds for example). -- This message was sent by Atlassian JIRA (v6.4.14#64029)