[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444895#comment-16444895
]
Nikolay Izhikov commented on IGNITE-7691:
-
This patch was discussed with [~vozerov] and
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444076#comment-16444076
]
Nikolay Izhikov commented on IGNITE-7691:
-
[~vozerov]
As far as I can see there is no backward
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443948#comment-16443948
]
Nikolay Izhikov commented on IGNITE-7691:
-
[~NIzhikov]
> 1) Binary compatibility for thin .NET
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443979#comment-16443979
]
Nikolay Izhikov commented on IGNITE-7691:
-
[~vozerov]
Actually, this ticket is based on your
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443978#comment-16443978
]
Dmitriy Pavlov commented on IGNITE-7691:
[~vozerov] which compatibilty do you mean? All
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443975#comment-16443975
]
Vladimir Ozerov commented on IGNITE-7691:
-
[~NIzhikov], the main problem is that we implemented a
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443980#comment-16443980
]
Nikolay Izhikov commented on IGNITE-7691:
-
[~vozerov]
> Ignite hadn't supported scale/precision
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443969#comment-16443969
]
Vladimir Ozerov commented on IGNITE-7691:
-
Solution which makes sense to me:
1) Revert current
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443954#comment-16443954
]
Nikolay Izhikov commented on IGNITE-7691:
-
[~vozerov]
> even though we set the precision, it is
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443939#comment-16443939
]
Vladimir Ozerov commented on IGNITE-7691:
-
[~NIzhikov], [~dpavlov], another critical comment is
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443936#comment-16443936
]
Vladimir Ozerov commented on IGNITE-7691:
-
[~NIzhikov], [~dpavlov], [~tledkov-gridgain],
Folks,
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437038#comment-16437038
]
ASF GitHub Bot commented on IGNITE-7691:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435386#comment-16435386
]
Dmitriy Pavlov commented on IGNITE-7691:
It seems there are no test left, all others are failing
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435345#comment-16435345
]
Nikolay Izhikov commented on IGNITE-7691:
-
Latest "Run All" for my PR -
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433876#comment-16433876
]
Nikolay Izhikov commented on IGNITE-7691:
-
[~dpavlov] Thank you.
Actually, these failures ARE
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432152#comment-16432152
]
Dmitriy Pavlov commented on IGNITE-7691:
There is still concern about failing tests:
{noformat}
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432070#comment-16432070
]
Taras Ledkov commented on IGNITE-7691:
--
[~NIzhikov] you are right. Please merge the path.
> Provide
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430553#comment-16430553
]
Nikolay Izhikov commented on IGNITE-7691:
-
Hello, [~tledkov-gridgain].
Thanks for the review.
>
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430507#comment-16430507
]
Taras Ledkov commented on IGNITE-7691:
--
[~NIzhikov], [~vozerov], the patch looks good.
But I have
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425785#comment-16425785
]
Nikolay Izhikov commented on IGNITE-7691:
-
Run All -
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425762#comment-16425762
]
Dmitriy Pavlov commented on IGNITE-7691:
[~tledkov-gridgain], could you please review SQL part?
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425724#comment-16425724
]
Dmitriy Pavlov commented on IGNITE-7691:
I've checked the tests, most of failures are common with
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421624#comment-16421624
]
Nikolay Izhikov commented on IGNITE-7691:
-
[~dpavlov] Here they are -
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420682#comment-16420682
]
Dmitriy Pavlov commented on IGNITE-7691:
First run is more or less ok, let's wait for second run.
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420238#comment-16420238
]
Pavel Tupitsyn commented on IGNITE-7691:
Hi [~NIzhikov], changes look good to me in gerenal,
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419077#comment-16419077
]
Nikolay Izhikov commented on IGNITE-7691:
-
Hello, [~ptupitsyn]
Could you, please, review .Net
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419075#comment-16419075
]
Nikolay Izhikov commented on IGNITE-7691:
-
Hello, [~vozerov].
Could you, please, review my
[
https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411202#comment-16411202
]
ASF GitHub Bot commented on IGNITE-7691:
GitHub user nizhikov opened a pull request:
28 matches
Mail list logo