[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444895#comment-16444895 ] Nikolay Izhikov commented on IGNITE-7691: - This patch was discussed with [~vozerov] and

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444076#comment-16444076 ] Nikolay Izhikov commented on IGNITE-7691: - [~vozerov] As far as I can see there is no backward

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443948#comment-16443948 ] Nikolay Izhikov commented on IGNITE-7691: - [~NIzhikov] > 1) Binary compatibility for thin .NET

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443979#comment-16443979 ] Nikolay Izhikov commented on IGNITE-7691: - [~vozerov] Actually, this ticket is based on your

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Dmitriy Pavlov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443978#comment-16443978 ] Dmitriy Pavlov commented on IGNITE-7691: [~vozerov] which compatibilty do you mean? All

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443975#comment-16443975 ] Vladimir Ozerov commented on IGNITE-7691: - [~NIzhikov], the main problem is that we implemented a

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443980#comment-16443980 ] Nikolay Izhikov commented on IGNITE-7691: - [~vozerov] > Ignite hadn't supported scale/precision

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443969#comment-16443969 ] Vladimir Ozerov commented on IGNITE-7691: - Solution which makes sense to me: 1) Revert current

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443954#comment-16443954 ] Nikolay Izhikov commented on IGNITE-7691: - [~vozerov] > even though we set the precision, it is

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443939#comment-16443939 ] Vladimir Ozerov commented on IGNITE-7691: - [~NIzhikov], [~dpavlov], another critical comment is

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-19 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443936#comment-16443936 ] Vladimir Ozerov commented on IGNITE-7691: - [~NIzhikov], [~dpavlov], [~tledkov-gridgain], Folks,

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437038#comment-16437038 ] ASF GitHub Bot commented on IGNITE-7691: Github user asfgit closed the pull request at:

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-12 Thread Dmitriy Pavlov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435386#comment-16435386 ] Dmitriy Pavlov commented on IGNITE-7691: It seems there are no test left, all others are failing

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-12 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435345#comment-16435345 ] Nikolay Izhikov commented on IGNITE-7691: - Latest "Run All" for my PR -

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-11 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433876#comment-16433876 ] Nikolay Izhikov commented on IGNITE-7691: - [~dpavlov] Thank you. Actually, these failures ARE

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-10 Thread Dmitriy Pavlov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432152#comment-16432152 ] Dmitriy Pavlov commented on IGNITE-7691: There is still concern about failing tests: {noformat}

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-10 Thread Taras Ledkov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432070#comment-16432070 ] Taras Ledkov commented on IGNITE-7691: -- [~NIzhikov] you are right. Please merge the path. > Provide

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-09 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430553#comment-16430553 ] Nikolay Izhikov commented on IGNITE-7691: - Hello, [~tledkov-gridgain]. Thanks for the review. >

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-09 Thread Taras Ledkov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430507#comment-16430507 ] Taras Ledkov commented on IGNITE-7691: -- [~NIzhikov], [~vozerov], the patch looks good. But I have

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-04 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425785#comment-16425785 ] Nikolay Izhikov commented on IGNITE-7691: - Run All -

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-04 Thread Dmitriy Pavlov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425762#comment-16425762 ] Dmitriy Pavlov commented on IGNITE-7691: [~tledkov-gridgain], could you please review SQL part?

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-04 Thread Dmitriy Pavlov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425724#comment-16425724 ] Dmitriy Pavlov commented on IGNITE-7691: I've checked the tests, most of failures are common with

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-04-01 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421624#comment-16421624 ] Nikolay Izhikov commented on IGNITE-7691: - [~dpavlov] Here they are -

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-03-30 Thread Dmitriy Pavlov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420682#comment-16420682 ] Dmitriy Pavlov commented on IGNITE-7691: First run is more or less ok, let's wait for second run.

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-03-30 Thread Pavel Tupitsyn (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420238#comment-16420238 ] Pavel Tupitsyn commented on IGNITE-7691: Hi [~NIzhikov], changes look good to me in gerenal,

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-03-29 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419077#comment-16419077 ] Nikolay Izhikov commented on IGNITE-7691: - Hello, [~ptupitsyn] Could you, please, review .Net

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-03-29 Thread Nikolay Izhikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419075#comment-16419075 ] Nikolay Izhikov commented on IGNITE-7691: - Hello, [~vozerov]. Could you, please, review my

[jira] [Commented] (IGNITE-7691) Provide info about DECIMAL column scale and precision

2018-03-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411202#comment-16411202 ] ASF GitHub Bot commented on IGNITE-7691: GitHub user nizhikov opened a pull request: